Skip to content

Commit 00879f0

Browse files
committed
internal/ci: ensure internal/_e2e isn't broken in CI
I have broken the build of the internal/_e2e tests more than once, most recently fixed in https://cuelang.org/cl/1198297, as we only actually run these tests on pushes to protected branches. However, it's easy to build the tests in a CI run before merging, and that will catch most of these mistakes which can happen as a result of refactors or other API changes which internal/_e2e uses. Signed-off-by: Daniel Martí <[email protected]> Change-Id: I529ed3b1d52e86ef1f9c41744ebc2d97ef3d77a2 Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1198300 TryBot-Result: CUEcueckoo <[email protected]> Reviewed-by: Paul Jolly <[email protected]> Unity-Result: CUE porcuepine <[email protected]>
1 parent cf6641c commit 00879f0

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

.github/workflows/trybot.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,7 @@ jobs:
146146
run: |-
147147
go vet ./...
148148
go mod tidy
149+
(cd internal/_e2e && go test -run=-)
149150
- if: always()
150151
name: Check that git is clean at the end of the job
151152
run: test -z "$(git status --porcelain)" || (git status; git diff; false)

internal/ci/github/trybot.cue

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -158,12 +158,17 @@ workflows: trybot: _repo.bashWorkflow & {
158158
// However, CUE does not have any such build tags yet, and we don't use
159159
// dependencies that vary wildly between platforms.
160160
// For now, to save CI resources, just run the checks on one matrix job.
161+
//
162+
// Also ensure that the end-to-end tests in ./internal/_e2e, which are only run
163+
// on pushes to protected branches, still build correctly before merging.
164+
//
161165
// TODO: consider adding more checks as per https://github.com/golang/go/issues/42119.
162166
if: "\(_isLatestLinux)"
163167
name: "Check"
164168
run: """
165169
go vet ./...
166170
go mod tidy
171+
(cd internal/_e2e && go test -run=-)
167172
"""
168173
}
169174

0 commit comments

Comments
 (0)