Skip to content

Commit b08d86e

Browse files
ChanWoo Leemartinkpetersen
authored andcommitted
scsi: ufs: qcom: Remove unnecessary goto statement from ufs_qcom_config_esi()
There is only one place where goto is used, and it is unnecessary to check the ret value through 'goto out' because the ret value is already true. Therefore, remove the goto statement and integrate the '!ret' condition into the existing code. Signed-off-by: ChanWoo Lee <[email protected]> Link: https://lore.kernel.org/r/[email protected] Reviewed-by: Christophe JAILLET <[email protected]> Reviewed-by: Manivannan Sadhasivam <[email protected]> Signed-off-by: Martin K. Petersen <[email protected]>
1 parent ee36710 commit b08d86e

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

drivers/ufs/host/ufs-qcom.c

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1714,7 +1714,7 @@ static int ufs_qcom_config_esi(struct ufs_hba *hba)
17141714
ufs_qcom_write_msi_msg);
17151715
if (ret) {
17161716
dev_err(hba->dev, "Failed to request Platform MSI %d\n", ret);
1717-
goto out;
1717+
return ret;
17181718
}
17191719

17201720
msi_lock_descs(hba->dev);
@@ -1748,11 +1748,8 @@ static int ufs_qcom_config_esi(struct ufs_hba *hba)
17481748
FIELD_PREP(ESI_VEC_MASK, MAX_ESI_VEC - 1),
17491749
REG_UFS_CFG3);
17501750
ufshcd_mcq_enable_esi(hba);
1751-
}
1752-
1753-
out:
1754-
if (!ret)
17551751
host->esi_enabled = true;
1752+
}
17561753

17571754
return ret;
17581755
}

0 commit comments

Comments
 (0)