Skip to content

Commit 631a4b3

Browse files
Florian Westphalummakynes
authored andcommitted
netfilter: nfnetlink_queue: drop bogus WARN_ON
Happens when rules get flushed/deleted while packet is out, so remove this WARN_ON. This WARN exists in one form or another since v4.14, no need to backport this to older releases, hence use a more recent fixes tag. Fixes: 3f80196 ("netfilter: move nf_reinject into nfnetlink_queue modules") Reported-by: kernel test robot <[email protected]> Closes: https://lore.kernel.org/oe-lkp/[email protected] Signed-off-by: Florian Westphal <[email protected]> Signed-off-by: Pablo Neira Ayuso <[email protected]>
1 parent c184cf9 commit 631a4b3

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

net/netfilter/nfnetlink_queue.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,7 @@ static void nf_reinject(struct nf_queue_entry *entry, unsigned int verdict)
325325
hooks = nf_hook_entries_head(net, pf, entry->state.hook);
326326

327327
i = entry->hook_index;
328-
if (WARN_ON_ONCE(!hooks || i >= hooks->num_hook_entries)) {
328+
if (!hooks || i >= hooks->num_hook_entries) {
329329
kfree_skb_reason(skb, SKB_DROP_REASON_NETFILTER_DROP);
330330
nf_queue_entry_free(entry);
331331
return;

0 commit comments

Comments
 (0)