Skip to content

Commit 1daa4bc

Browse files
authored
Merge pull request #615 from mukesh22584/11.0
QS: Remove divider between QS tiles and media player
2 parents c6e804e + b93366d commit 1daa4bc

File tree

4 files changed

+0
-37
lines changed

4 files changed

+0
-37
lines changed

packages/SystemUI/res-keyguard/layout/qs_media_divider.xml

Lines changed: 0 additions & 7 deletions
This file was deleted.

packages/SystemUI/res/layout/qs_panel.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,6 @@
7171
android:focusable="true"
7272
android:accessibilityTraversalBefore="@android:id/edit">
7373
<include layout="@layout/qs_footer_impl" />
74-
<include layout="@layout/qs_media_divider"
75-
android:id="@+id/divider"/>
7674
</com.android.systemui.qs.QSPanel>
7775
</com.android.systemui.qs.NonInterceptingScrollView>
7876

packages/SystemUI/src/com/android/systemui/qs/QSAnimator.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -314,16 +314,10 @@ private void updateAnimators() {
314314
if (mQsPanel.getSecurityFooter() != null) {
315315
builder.addFloat(mQsPanel.getSecurityFooter().getView(), "alpha", 0, 1);
316316
}
317-
if (mQsPanel.getDivider() != null) {
318-
builder.addFloat(mQsPanel.getDivider(), "alpha", 0, 1);
319-
}
320317
mAllPagesDelayedAnimator = builder.build();
321318
if (mQsPanel.getSecurityFooter() != null) {
322319
mAllViews.add(mQsPanel.getSecurityFooter().getView());
323320
}
324-
if (mQsPanel.getDivider() != null) {
325-
mAllViews.add(mQsPanel.getDivider());
326-
}
327321

328322
float px = 0;
329323
float py = 1;

packages/SystemUI/src/com/android/systemui/qs/QSPanel.java

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -128,8 +128,6 @@ public class QSPanel extends LinearLayout implements Tunable, Callback, Brightne
128128

129129
@Nullable
130130
protected View mFooter;
131-
@Nullable
132-
protected View mDivider;
133131

134132
@Nullable
135133
private ViewGroup mHeaderContainer;
@@ -540,7 +538,6 @@ protected void onConfigurationChanged(Configuration newConfig) {
540538
protected void onFinishInflate() {
541539
super.onFinishInflate();
542540
mFooter = findViewById(R.id.qs_footer);
543-
mDivider = findViewById(R.id.divider);
544541
switchTileLayout(true /* force */);
545542
}
546543

@@ -551,13 +548,6 @@ boolean switchTileLayout() {
551548
private boolean switchTileLayout(boolean force) {
552549
/** Whether or not the QuickQSPanel currently contains a media player. */
553550
boolean horizontal = shouldUseHorizontalLayout();
554-
if (mDivider != null) {
555-
if (!horizontal && mUsingMediaPlayer && mMediaHost.getVisible()) {
556-
mDivider.setVisibility(View.VISIBLE);
557-
} else {
558-
mDivider.setVisibility(View.GONE);
559-
}
560-
}
561551
if (horizontal != mUsingHorizontalLayout || force) {
562552
mUsingHorizontalLayout = horizontal;
563553
View visibleView = horizontal ? mHorizontalLinearLayout : (View) mRegularTileLayout;
@@ -595,7 +585,6 @@ private boolean switchTileLayout(boolean force) {
595585
}
596586
updateTileLayoutMargins();
597587
updateFooterMargin();
598-
updateDividerMargin();
599588
updateMediaDisappearParameters();
600589
updateMediaHostContentMargins();
601590
updateHorizontalLinearLayoutMargins();
@@ -1047,11 +1036,6 @@ public QSSecurityFooter getSecurityFooter() {
10471036
return mSecurityFooter;
10481037
}
10491038

1050-
@Nullable
1051-
public View getDivider() {
1052-
return mDivider;
1053-
}
1054-
10551039
public void showDeviceMonitoringDialog() {
10561040
if (mSecurityFooter != null) {
10571041
mSecurityFooter.showDeviceMonitoringDialog();
@@ -1067,7 +1051,6 @@ public void setContentMargins(int startMargin, int endMargin) {
10671051
mContentMarginEnd - mVisualTilePadding);
10681052
updateMediaHostContentMargins();
10691053
updateFooterMargin();
1070-
updateDividerMargin();
10711054
}
10721055

10731056
private void updateFooterMargin() {
@@ -1109,11 +1092,6 @@ private void updateTileLayoutMargins() {
11091092
updateMargins((View) mTileLayout, mVisualMarginStart, marginEnd);
11101093
}
11111094

1112-
private void updateDividerMargin() {
1113-
if (mDivider == null) return;
1114-
updateMargins(mDivider, mContentMarginStart, mContentMarginEnd);
1115-
}
1116-
11171095
/**
11181096
* Update the margins of the media hosts
11191097
*/

0 commit comments

Comments
 (0)