use http.Server with timeout instead of http.Serve

this change is same as what github.com/containers/gvisor-tap-vsock/pull/144
did for gvisor-tap-vsock

golangci-lint complains about calling http.Serve that doesn't have any
timeouts:

cmd/crc/cmd/daemon.go:146:13: G114: Use of net/http serve function that has no support for setting timeouts (gosec)
		if err := http.Serve(listener, handlers.LoggingHandler(os.Stderr, mux)); err != nil {
		         ^
cmd/crc/cmd/daemon.go:157:13: G114: Use of net/http serve function that has no support for setting timeouts (gosec)
		if err := http.Serve(ln, handlers.LoggingHandler(os.Stderr, mux)); err != nil {
		         ^
cmd/crc/cmd/daemon.go:168:13: G114: Use of net/http serve function that has no support for setting timeouts (gosec)
		if err := http.Serve(networkListener, handlers.LoggingHandler(os.Stderr, mux)); err != nil {
		         ^

Author: anjannath

cmd/crc/cmd/daemon.go

@@ -146,7 +146,12 @@ func run(configuration *types.Configuration) error {
 		machineClient := newMachine()
 		mux.Handle("/api/", http.StripPrefix("/api", api.NewMux(config, machineClient, logging.Memory, segmentClient)))
 		mux.Handle("/socket/", http.StripPrefix("/socket", websocket.NewWebsocketServer(machineClient)))
-		if err := http.Serve(listener, handlers.LoggingHandler(os.Stderr, mux)); err != nil {
+		s := &http.Server{
+			Handler:      handlers.LoggingHandler(os.Stderr, mux),
+			ReadTimeout:  10 * time.Second,
+			WriteTimeout: 10 * time.Second,
+		}
+		if err := s.Serve(listener); err != nil {
 			errCh <- errors.Wrap(err, "api http.Serve failed")
 		}
 	}()
@@ -157,7 +162,12 @@ func run(configuration *types.Configuration) error {
 	}
 	go func() {
 		mux := gatewayAPIMux()
-		if err := http.Serve(ln, handlers.LoggingHandler(os.Stderr, mux)); err != nil {
+		s := &http.Server{
+			Handler:      handlers.LoggingHandler(os.Stderr, mux),
+			ReadTimeout:  10 * time.Second,
+			WriteTimeout: 10 * time.Second,
+		}
+		if err := s.Serve(ln); err != nil {
 			errCh <- errors.Wrap(err, "gateway http.Serve failed")
 		}
 	}()
@@ -168,15 +178,25 @@ func run(configuration *types.Configuration) error {
 	}
 	go func() {
 		mux := networkAPIMux(vn)
-		if err := http.Serve(networkListener, handlers.LoggingHandler(os.Stderr, mux)); err != nil {
+		s := &http.Server{
+			Handler:      handlers.LoggingHandler(os.Stderr, mux),
+			ReadTimeout:  10 * time.Second,
+			WriteTimeout: 10 * time.Second,
+		}
+		if err := s.Serve(networkListener); err != nil {
 			errCh <- errors.Wrap(err, "host virtual IP http.Serve failed")
 		}
 	}()
 
 	go func() {
 		mux := http.NewServeMux()
 		mux.Handle(types.ConnectPath, vn.Mux())
-		if err := http.Serve(vsockListener, mux); err != nil {
+		s := &http.Server{
+			Handler:      mux,
+			ReadTimeout:  10 * time.Second,
+			WriteTimeout: 10 * time.Second,
+		}
+		if err := s.Serve(vsockListener); err != nil {
 			errCh <- errors.Wrap(err, "virtualnetwork http.Serve failed")
 		}
 	}()