segment: return error if cached identifier is not 8 bytes long

anjannath · anjannath · commit 8e081620dda4 · 2023-06-08T11:49:06.000+05:30
diff --git a/pkg/crc/segment/segment.go b/pkg/crc/segment/segment.go
@@ -139,6 +139,10 @@ func readIdentifyHash(identifyHashPath string) (uint64, error) {
 		return 0, err
 	}
 
+	if length := len(cachedHashBytes); length != 8 {
+		return 0, fmt.Errorf("Got %d bytes hash, expected 8", length)
+	}
+
 	return binary.LittleEndian.Uint64(cachedHashBytes), nil
 }
 

Original file line number	Diff line number	Diff line change
`@@ -139,6 +139,10 @@ func readIdentifyHash(identifyHashPath string) (uint64, error) {`
`139`	`139`	`return 0, err`
`140`	`140`	`}`
`141`	`141`
	`142`	`+ if length := len(cachedHashBytes); length != 8 {`
	`143`	`+ return 0, fmt.Errorf("Got %d bytes hash, expected 8", length)`
	`144`	`+ }`
	`145`	`+`
`142`	`146`	`return binary.LittleEndian.Uint64(cachedHashBytes), nil`
`143`	`147`	`}`
`144`	`148`