Skip to content

Commit 8c4fdb5

Browse files
cfergeaupraveenkumar
authored andcommitted
build: Re-add release flags to 'linux-release-binary'
$(RELEASE_VERSION_VARIABLES) needs to be used when building a release binary in order to use the correct telemetry key. This was broken in 27cd148 and explains why linux usage dropped since release 2.10.1.
1 parent c4518fe commit 8c4fdb5

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -267,6 +267,7 @@ gen_release_info:
267267
@sed -i s/@PODMAN_VERSION@/$(PODMAN_VERSION)/ $(RELEASE_INFO)
268268

269269
.PHONY: linux-release-binary macos-release-binary windows-release-binary
270+
linux-release-binary: LDFLAGS+= $(RELEASE_VERSION_VARIABLES)
270271
linux-release-binary: $(BUILD_DIR)/linux-amd64/crc
271272

272273
macos-release-binary: LDFLAGS+= -X '$(REPOPATH)/pkg/crc/version.installerBuild=true' $(RELEASE_VERSION_VARIABLES)

0 commit comments

Comments
 (0)