Skip to content

Commit 89245e0

Browse files
cfergeaupraveenkumar
authored andcommitted
Issue #438: Move fillClusterConfig() after VM loading/creation
This is in preparation for the next commits, so that we can have different bundle info metadata depending on load/create This is related to #438
1 parent 1070231 commit 89245e0

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

pkg/crc/machine/machine.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -71,12 +71,6 @@ func Start(startConfig StartConfig) (StartResult, error) {
7171
return *result, errors.Newf("Error to get bundle Metadata %v", err)
7272
}
7373

74-
err = fillClusterConfig(crcBundleMetadata, &result.ClusterConfig)
75-
if err != nil {
76-
result.Error = err.Error()
77-
return *result, errors.Newf("%s", err.Error())
78-
}
79-
8074
// Pre-VM start
8175
driverInfo, _ := getDriverInfo(startConfig.VMDriver)
8276
exists, err := existVM(libMachineAPIClient, startConfig.Name)
@@ -156,6 +150,12 @@ func Start(startConfig StartConfig) (StartResult, error) {
156150
result.Status = vmState.String()
157151
}
158152

153+
err = fillClusterConfig(crcBundleMetadata, &result.ClusterConfig)
154+
if err != nil {
155+
result.Error = err.Error()
156+
return *result, errors.Newf("%s", err.Error())
157+
}
158+
159159
// Post-VM start
160160
host, err := libMachineAPIClient.Load(startConfig.Name)
161161
if err != nil {

0 commit comments

Comments
 (0)