Issue #396 Add windows target to embed bundle in the binary

Don't show an warning message if the bundle was passed to crc
start command. If no bundle was passed to start command, ask
user to run setup command to unpack the bundle to disk

Author: anjannath

Makefile

@@ -127,7 +127,7 @@ fmtcheck: ## Checks for style violation using gofmt
 	@gofmt -l $(SOURCE_DIRS) | grep ".*\.go"; if [ "$$?" = "0" ]; then exit 1; fi
 
 .PHONY: release
-release: clean fmtcheck cross
+release: clean fmtcheck embed_bundle
 	mkdir $(RELEASE_DIR)
 
 	@mkdir -p $(BUILD_DIR)/crc-$(CRC_VERSION)-darwin-amd64
@@ -148,3 +148,4 @@ embed_bundle: cross binappend
 	@$(call check_defined, BUNDLE_DIR, "Embedding bundle requires BUNDLE_DIR set to a directory containing CRC bundles for all hypervisors")
 	binappend-cli write $(BUILD_DIR)/linux-amd64/crc $(BUNDLE_DIR)/crc_libvirt_$(BUNDLE_VERSION).$(BUNDLE_EXTENSION)
 	binappend-cli write $(BUILD_DIR)/darwin-amd64/crc $(BUNDLE_DIR)/crc_hyperkit_$(BUNDLE_VERSION).$(BUNDLE_EXTENSION)
+	binappend-cli write $(BUILD_DIR)/windows-amd64/crc.exe $(BUNDLE_DIR)/crc_hyperv_$(BUNDLE_VERSION).$(BUNDLE_EXTENSION)

pkg/crc/preflight/preflight_common.go renamed to pkg/crc/preflight/preflight.go

@@ -8,11 +8,13 @@ import (
 	"github.com/YourFin/binappend"
 	"github.com/kardianos/osext"
 
+	cmdConfig "github.com/code-ready/crc/cmd/crc/cmd/config"
+	"github.com/code-ready/crc/pkg/crc/config"
 	"github.com/code-ready/crc/pkg/crc/constants"
 )
 
 func checkBundleCached() (bool, error) {
-	if _, err := os.Stat(constants.DefaultBundlePath); os.IsNotExist(err) {
+	if _, err := os.Stat(config.GetString(cmdConfig.Bundle.Name)); os.IsNotExist(err) {
 		return false, err
 	}
 	return true, nil

pkg/crc/preflight/preflight_checks_common.go

@@ -43,7 +43,7 @@ func ValidateMemory(value int) error {
 // ValidateBundle checks if provided bundle path exist
 func ValidateBundle(bundle string) error {
 	if err := ValidatePath(bundle); err != nil {
-		return err
+		return errors.Newf("Run 'crc setup' to unpack the bundle to disk.")
 	}
 	// Check if the version of the bundle provided by user is same as what is released with crc.
 	releaseBundleVersion := version.GetBundleVersion()