start: Configure proxy as early as possible

The machine-config operator tries to do some remote registry checks
when it starts, so it's better to set the cluster proxy settings as
early as possible after starting the kubelet.

Author: cfergeau

pkg/crc/machine/start.go

@@ -500,6 +500,10 @@ func (client *client) Start(ctx context.Context, startConfig types.StartConfig)
 		return nil, errors.Wrap(err, "Error waiting for apiserver")
 	}
 
+	if err := ensureProxyIsConfiguredInOpenShift(ctx, ocConfig, sshRunner, proxyConfig); err != nil {
+		return nil, errors.Wrap(err, "Failed to update cluster proxy configuration")
+	}
+
 	if err := cluster.DeleteMCOLeaderLease(ctx, ocConfig); err != nil {
 		return nil, err
 	}
@@ -516,10 +520,6 @@ func (client *client) Start(ctx context.Context, startConfig types.StartConfig)
 		return nil, errors.Wrap(err, "Failed to update pull secret on the disk")
 	}
 
-	if err := ensureProxyIsConfiguredInOpenShift(ctx, ocConfig, sshRunner, proxyConfig); err != nil {
-		return nil, errors.Wrap(err, "Failed to update cluster proxy configuration")
-	}
-
 	if err := cluster.UpdateKubeAdminUserPassword(ctx, ocConfig, startConfig.KubeAdminPassword); err != nil {
 		return nil, errors.Wrap(err, "Failed to update kubeadmin user password")
 	}