Skip to content

Commit 16d015a

Browse files
committed
Use deployment instead deploymentconfigs (dc) for rollout status
With newer version of oc binary when you use a mapping github repo for your app deployment which have deploymentconfig as template then it uses deployment instead dc. ``` $ ~/.crc/bin/oc/oc version Client Version: 4.5.0-202005291417-9933eb9 $ ~/.crc/bin/oc/oc new-app centos/httpd-24-centos7~https://github.com/sclorg/httpd-ex [...] deployment.apps "httpd-ex" created $ oc version Client Version: 4.5.0-20200326-010450 $ oc new-app centos/httpd-24-centos7~https://github.com/sclorg/httpd-ex && oc rollout status dc/httpd-ex [...] deploymentconfig.apps.openshift.io "httpd-ex" created ```
1 parent d86465f commit 16d015a

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

test/integration/features/story_health.feature

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ Feature:
4949
"""
5050
service "httpd-ex" created
5151
"""
52-
When executing "oc rollout status dc/httpd-ex" succeeds
52+
When executing "oc rollout status deployment httpd-ex" succeeds
5353
Then stdout should contain "successfully rolled out"
5454
And executing "oc expose svc/httpd-ex" succeeds
5555
And with up to "2" retries with wait period of "60s" http response from "http://httpd-ex-testproj.apps-crc.testing" has status code "200"

test/integration/features/story_registry.feature

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ Feature: Local image to image-registry to deployment
2929

3030
Scenario: Deploy the image
3131
Given executing "oc new-app testproj-img/hello:test" succeeds
32-
When executing "oc rollout status dc/hello" succeeds
32+
When executing "oc rollout status deployment hello" succeeds
3333
Then stdout should contain "successfully rolled out"
3434
When executing "oc get pods" succeeds
3535
Then stdout should contain "Running"

0 commit comments

Comments
 (0)