move func RemoveCRCHostEntriesFromKnownHosts() to pkg/crc/ssh package

we need to call this function from atleast two places this'd allow us to do that

Author: anjannath

pkg/crc/machine/delete.go

@@ -1,15 +1,11 @@
 package machine
 
 import (
-	"bufio"
-	"fmt"
 	"os"
-	"path/filepath"
-	"strings"
 
-	"github.com/crc-org/crc/pkg/crc/constants"
 	"github.com/crc-org/crc/pkg/crc/logging"
 	"github.com/crc-org/crc/pkg/crc/podman"
+	"github.com/crc-org/crc/pkg/crc/ssh"
 	"github.com/pkg/errors"
 )
 
@@ -44,58 +40,5 @@ func (client *client) Delete() error {
 			logging.Warnf("Failed to remove crc contexts from kubeconfig: %v", err)
 		}
 	}
-	return removeCRCHostEntriesFromKnownHosts()
-}
-
-func removeCRCHostEntriesFromKnownHosts() error {
-	knownHostsPath := filepath.Join(constants.GetHomeDir(), ".ssh", "known_hosts")
-	if _, err := os.Stat(knownHostsPath); err != nil {
-		return nil
-	}
-	f, err := os.Open(knownHostsPath)
-	if err != nil {
-		return fmt.Errorf("Unable to open user's 'known_hosts' file: %w", err)
-	}
-	defer f.Close()
-
-	tempHostsFile, err := os.CreateTemp(filepath.Join(constants.GetHomeDir(), ".ssh"), "crc")
-	if err != nil {
-		return fmt.Errorf("Unable to create temp file: %w", err)
-	}
-	defer func() {
-		tempHostsFile.Close()
-		os.Remove(tempHostsFile.Name())
-	}()
-
-	if err := tempHostsFile.Chmod(0600); err != nil {
-		return fmt.Errorf("Error trying to change permissions for temp file: %w", err)
-	}
-
-	var foundCRCEntries bool
-	scanner := bufio.NewScanner(f)
-	writer := bufio.NewWriter(tempHostsFile)
-	for scanner.Scan() {
-		if strings.Contains(scanner.Text(), "[127.0.0.1]:2222") || strings.Contains(scanner.Text(), "192.168.130.11") {
-			foundCRCEntries = true
-			continue
-		}
-		if _, err := writer.WriteString(fmt.Sprintf("%s\n", scanner.Text())); err != nil {
-			return fmt.Errorf("Error while writing hostsfile content to temp file: %w", err)
-		}
-	}
-
-	if err := writer.Flush(); err != nil {
-		return fmt.Errorf("Error while flushing buffered content to temp file: %w", err)
-	}
-
-	if foundCRCEntries {
-		if err := f.Close(); err != nil {
-			return fmt.Errorf("Error closing known_hosts file: %w", err)
-		}
-		if err := tempHostsFile.Close(); err != nil {
-			return fmt.Errorf("Error closing temp file: %w", err)
-		}
-		return os.Rename(tempHostsFile.Name(), knownHostsPath)
-	}
-	return nil
+	return ssh.RemoveCRCHostEntriesFromKnownHosts()
 }

pkg/crc/ssh/keys.go

@@ -1,14 +1,18 @@
 package ssh
 
 import (
+	"bufio"
 	"crypto/ecdsa"
 	"crypto/elliptic"
 	"crypto/rand"
 	"crypto/x509"
 	"errors"
 	"fmt"
 	"os"
+	"path/filepath"
+	"strings"
 
+	"github.com/crc-org/crc/pkg/crc/constants"
 	gossh "golang.org/x/crypto/ssh"
 )
 
@@ -69,3 +73,56 @@ func GenerateSSHKey(path string) error {
 
 	return nil
 }
+
+func RemoveCRCHostEntriesFromKnownHosts() error {
+	knownHostsPath := filepath.Join(constants.GetHomeDir(), ".ssh", "known_hosts")
+	if _, err := os.Stat(knownHostsPath); err != nil {
+		return nil
+	}
+	f, err := os.Open(knownHostsPath)
+	if err != nil {
+		return fmt.Errorf("Unable to open user's 'known_hosts' file: %w", err)
+	}
+	defer f.Close()
+
+	tempHostsFile, err := os.CreateTemp(filepath.Join(constants.GetHomeDir(), ".ssh"), "crc")
+	if err != nil {
+		return fmt.Errorf("Unable to create temp file: %w", err)
+	}
+	defer func() {
+		tempHostsFile.Close()
+		os.Remove(tempHostsFile.Name())
+	}()
+
+	if err := tempHostsFile.Chmod(0600); err != nil {
+		return fmt.Errorf("Error trying to change permissions for temp file: %w", err)
+	}
+
+	var foundCRCEntries bool
+	scanner := bufio.NewScanner(f)
+	writer := bufio.NewWriter(tempHostsFile)
+	for scanner.Scan() {
+		if strings.Contains(scanner.Text(), "[127.0.0.1]:2222") || strings.Contains(scanner.Text(), "192.168.130.11") {
+			foundCRCEntries = true
+			continue
+		}
+		if _, err := writer.WriteString(fmt.Sprintf("%s\n", scanner.Text())); err != nil {
+			return fmt.Errorf("Error while writing hostsfile content to temp file: %w", err)
+		}
+	}
+
+	if err := writer.Flush(); err != nil {
+		return fmt.Errorf("Error while flushing buffered content to temp file: %w", err)
+	}
+
+	if foundCRCEntries {
+		if err := f.Close(); err != nil {
+			return fmt.Errorf("Error closing known_hosts file: %w", err)
+		}
+		if err := tempHostsFile.Close(); err != nil {
+			return fmt.Errorf("Error closing temp file: %w", err)
+		}
+		return os.Rename(tempHostsFile.Name(), knownHostsPath)
+	}
+	return nil
+}