Skip to content

Commit e5c0696

Browse files
committed
removed "data" wrapper on responses
1 parent 3b31abf commit e5c0696

File tree

4 files changed

+11
-15
lines changed

4 files changed

+11
-15
lines changed

app/resources/roadmap/roadmap.controllers.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,7 @@ export const getRoadmap = async (req: any, res: any) => {
2222
return res.status(400).end();
2323
}
2424

25-
const data = {
26-
...roadmap,
27-
subjects,
28-
};
29-
res.status(200).json({ data });
25+
res.status(200).json({ ...roadmap, subjects });
3026
} catch (e) {
3127
console.error(e);
3228
res.status(400).end();

app/resources/subject/subject.controller.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import subjectModel from './subject.model';
33
export const createOne = async (req: any, res: any) => {
44
try {
55
const doc = await subjectModel.create(req.body);
6-
res.status(201).json({ data: doc });
6+
res.status(201).json(doc);
77
} catch (e) {
88
console.error(e);
99
res.status(400).end();
@@ -14,7 +14,7 @@ export const getMany = async (_: any, res: any) => {
1414
try {
1515
const docs = await subjectModel.find({}).lean().exec();
1616

17-
res.status(200).json({ data: docs });
17+
res.status(200).json(docs);
1818
} catch (e) {
1919
console.error(e);
2020
res.status(400).end();

app/resources/visit/visit.controllers.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export const getCount = async (_: any, res: any) => {
1717
await visitModel.create({});
1818
const count = await countVisits();
1919

20-
res.status(200).send({ data: { visits: count } });
20+
res.status(200).send({ visits: count });
2121
} catch (e) {
2222
console.error(e);
2323
res.status(400).send({ message: e });

app/utils/crud.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ export const createOneFromUser = (
66
const createdBy = req.user._id;
77
try {
88
const doc = await model.create({ ...req.body, createdBy });
9-
res.status(201).json({ data: doc });
9+
res.status(201).json(doc);
1010
} catch (e) {
1111
console.error(e);
1212
res.status(400).end();
@@ -26,7 +26,7 @@ export const getOneFromUser = (
2626
return res.status(400).end();
2727
}
2828

29-
res.status(200).json({ data: doc });
29+
res.status(200).json(doc);
3030
} catch (e) {
3131
console.error(e);
3232
res.status(400).end();
@@ -39,7 +39,7 @@ export const getManyFromUser = (
3939
try {
4040
const docs = await model.find({ createdBy: req.user._id }).lean().exec();
4141

42-
res.status(200).json({ data: docs });
42+
res.status(200).json(docs);
4343
} catch (e) {
4444
console.error(e);
4545
res.status(400).end();
@@ -66,7 +66,7 @@ export const updateOneFromUser = (
6666
return res.status(400).end();
6767
}
6868

69-
res.status(200).json({ data: updatedDoc });
69+
res.status(200).json(updatedDoc);
7070
} catch (e) {
7171
console.error(e);
7272
res.status(400).end();
@@ -86,7 +86,7 @@ export const removeOneFromUser = (
8686
return res.status(400).end();
8787
}
8888

89-
return res.status(200).json({ data: removed });
89+
return res.status(200).json(removed);
9090
} catch (e) {
9191
console.error(e);
9292
res.status(400).end();
@@ -100,7 +100,7 @@ export const getMany = (model: mongoose.Model<mongoose.Document, {}>) => async (
100100
try {
101101
const docs = await model.find({}).lean().exec();
102102

103-
res.status(200).json({ data: docs });
103+
res.status(200).json(docs);
104104
} catch (e) {
105105
console.error(e);
106106
res.status(400).end();
@@ -118,7 +118,7 @@ export const getOne = (model: mongoose.Model<mongoose.Document, {}>) => async (
118118
return res.status(400).end();
119119
}
120120

121-
res.status(200).json({ data: doc });
121+
res.status(200).json(doc);
122122
} catch (e) {
123123
console.error(e);
124124
res.status(400).end();

0 commit comments

Comments
 (0)