Skip to content

Commit 8244463

Browse files
committed
Mostly restore command-line parity
Restore most everything and remove the added server arguments. This will let us add and remove options after later so we can contain the number of breaking changes. To accomplish this a hard separation is added between the CLI arguments and the server arguments. The separation between user-provided arguments and arguments with defaults is also made more clear. The extra directory flags have been left out as they were buggy and should be implemented upstream although I think there are better solutions anyway. locale and install-source are unsupported with the web remote and are left removed. It is unclear whether they were used before anyway. Some restored flags still need to have their behavior re-implemented.
1 parent d03c9f5 commit 8244463

File tree

9 files changed

+216
-259
lines changed

9 files changed

+216
-259
lines changed

src/node/app.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ const listen = (server: http.Server, { host, port, socket }: ListenOptions) => {
4444
server.listen(socket, onListen)
4545
} else {
4646
// [] is the correct format when using :: but Node errors with them.
47-
server.listen(parseInt(port, 10), host.replace(/^\[|\]$/g, ""), onListen)
47+
server.listen(port, host.replace(/^\[|\]$/g, ""), onListen)
4848
}
4949
})
5050
}

0 commit comments

Comments
 (0)