Fix custom locator registration with proper timing and format

Co-authored-by: kobenguyent <[email protected]>

Author: Copilot

lib/helper/Playwright.js

@@ -359,8 +359,10 @@ class Playwright extends Helper {
     // override defaults with config
     this._setConfig(config)
 
-    // Ensure _init() is called early to register custom selectors
-    this._init().catch(console.warn)
+    // Call _init() to register selector engines - use setTimeout to avoid blocking constructor
+    setTimeout(() => {
+      this._init().catch(console.error)
+    }, 0)
   }
 
   _validateConfig(config) {
@@ -477,12 +479,54 @@ class Playwright extends Helper {
 
   async _init() {
     // register an internal selector engine for reading value property of elements in a selector
-    if (defaultSelectorEnginesInitialized) return
-    defaultSelectorEnginesInitialized = true
     try {
-      await playwright.selectors.register('__value', createValueEngine)
-      await playwright.selectors.register('__disabled', createDisabledEngine)
-      if (process.env.testIdAttribute) await playwright.selectors.setTestIdAttribute(process.env.testIdAttribute)
+      if (!defaultSelectorEnginesInitialized) {
+        await playwright.selectors.register('__value', createValueEngine)
+        await playwright.selectors.register('__disabled', createDisabledEngine)
+        if (process.env.testIdAttribute) await playwright.selectors.setTestIdAttribute(process.env.testIdAttribute)
+        defaultSelectorEnginesInitialized = true
+      }
+      
+      // Register all custom locator strategies from the global registry
+      for (const [strategyName, strategyFunction] of globalCustomLocatorStrategies.entries()) {
+        if (!registeredCustomLocatorStrategies.has(strategyName)) {
+          try {
+            // Create a selector engine factory function exactly like createValueEngine pattern
+            const createCustomEngine = () => {
+              return {
+                create(root, target) {
+                  return null;
+                },
+                query(root, selector) {
+                  try {
+                    const result = strategyFunction(selector, root);
+                    return Array.isArray(result) ? result[0] : result;
+                  } catch (error) {
+                    console.warn(`Error in custom locator "${strategyName}":`, error);
+                    return null;
+                  }
+                },
+                queryAll(root, selector) {
+                  try {
+                    const result = strategyFunction(selector, root);
+                    return Array.isArray(result) ? result : result ? [result] : [];
+                  } catch (error) {
+                    console.warn(`Error in custom locator "${strategyName}":`, error);
+                    return [];
+                  }
+                }
+              };
+            };
+
+            await playwright.selectors.register(strategyName, createCustomEngine)
+            registeredCustomLocatorStrategies.add(strategyName)
+          } catch (error) {
+            if (!error.message.includes('already registered')) {
+              console.warn(`Failed to register custom locator strategy '${strategyName}':`, error)
+            }
+          }
+        }
+      }
     } catch (e) {
       console.warn(e)
     }
@@ -872,56 +916,10 @@ class Playwright extends Helper {
       this.debugSection('Url', target.url())
     })
 
-    // Register custom locator strategies after browser is started
-    await this._ensureCustomLocatorsRegistered()
-
     this.isRunning = true
     return this.browser
   }
 
-  async _ensureCustomLocatorsRegistered() {
-    // Register all custom locator strategies from the global registry
-    for (const [strategyName, strategyFunction] of globalCustomLocatorStrategies.entries()) {
-      if (!registeredCustomLocatorStrategies.has(strategyName)) {
-        try {
-          // Create a selector engine factory function like createValueEngine
-          const createCustomEngine = () => {
-            return {
-              create(root, target) {
-                return null;
-              },
-              query(root, selector) {
-                try {
-                  const result = strategyFunction(selector, root);
-                  return Array.isArray(result) ? result[0] : result;
-                } catch (error) {
-                  console.warn(`Error in custom locator "${strategyName}":`, error);
-                  return null;
-                }
-              },
-              queryAll(root, selector) {
-                try {
-                  const result = strategyFunction(selector, root);
-                  return Array.isArray(result) ? result : result ? [result] : [];
-                } catch (error) {
-                  console.warn(`Error in custom locator "${strategyName}":`, error);
-                  return [];
-                }
-              }
-            };
-          };
-
-          await playwright.selectors.register(strategyName, createCustomEngine)
-          registeredCustomLocatorStrategies.add(strategyName)
-        } catch (error) {
-          if (!error.message.includes('already registered')) {
-            console.warn(`Failed to register custom locator strategy '${strategyName}':`, error)
-          }
-        }
-      }
-    }
-  }
-
   _lookupCustomLocator(customStrategy) {
     if (typeof this.customLocatorStrategies !== 'object' || this.customLocatorStrategies === null) {
       return null
@@ -1348,9 +1346,6 @@ class Playwright extends Helper {
    * ```
    */
   async _locate(locator) {
-    // Ensure custom locators are registered before any locator operations
-    await this._ensureCustomLocatorsRegistered()
-    
     const context = await this._getContext()
 
     if (this.frame) return findElements(this.frame, locator)
@@ -1382,9 +1377,6 @@ class Playwright extends Helper {
    * ```
    */
   async _locateElement(locator) {
-    // Ensure custom locators are registered before any locator operations
-    await this._ensureCustomLocatorsRegistered()
-    
     const context = await this._getContext()
     return findElement(context, locator)
   }