Skip to content

Commit c0dce7b

Browse files
committed
[improvement] Add image preview, links to config page
1 parent b42cfea commit c0dce7b

File tree

3 files changed

+32
-6
lines changed

3 files changed

+32
-6
lines changed

app/assets/stylesheets/manage/dashboard.css

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ body {
7272
* Content
7373
*/
7474

75-
[role="main"] {
75+
[role='main'] {
7676
padding-top: 48px; /* Space for fixed navbar */
7777
}
7878

@@ -117,3 +117,12 @@ body {
117117
.border-bottom {
118118
border-bottom: 1px solid #e5e5e5;
119119
}
120+
121+
.img-template {
122+
background-image: linear-gradient(45deg, #eee 25%, transparent 25%),
123+
linear-gradient(-45deg, #eee 25%, transparent 25%),
124+
linear-gradient(45deg, transparent 75%, #eee 75%),
125+
linear-gradient(-45deg, transparent 75%, #eee 75%);
126+
background-size: 20px 20px;
127+
background-position: 0 0, 0 10px, 10px -10px, -10px 0px;
128+
}

app/views/manage/configs/_config_row.html.haml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
- secret ||= false # default value if prop not set
22
- default ||= nil # default value if prop not set
3+
- required = true if required.nil? # default value if prop not set
34
- value = ENV[key] || default
45

56
%p
@@ -13,5 +14,8 @@
1314
%span.badge.badge-success Set
1415
- else
1516
%pre= value
16-
- else
17+
- elsif required
1718
%span.badge.badge-danger Not set
19+
- else
20+
%span.badge.badge-secondary Not set
21+
%span.badge.badge-secondary Optional

app/views/manage/configs/index.html.haml

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
.row
44
.col-lg-6.mb-3
55
- @config.each_key do |key|
6+
- value = @config[key]
67
.card.mb-3
78
.card-body
89
%p.mb-1
@@ -14,11 +15,23 @@
1415
%small
1516
%code= key
1617
%p.text-muted= t("simple_form.hints.hackathon_config.#{key}").html_safe
17-
- if @config[key] == ''
18+
- if value == ''
1819
%p.mb-0
1920
%span.badge.badge-secondary Not set
2021
- else
21-
%pre.mb-0= @config[key]
22+
%pre.mb-0= value
23+
- if value.is_a?(String)
24+
- images = ['.ico', '.jpg', '.jpeg', '.png', '.gif', '.svg'].freeze
25+
- links = ['http://', 'https://'].freeze
26+
- if value.end_with?(*images)
27+
%br
28+
= image_tag value, style: 'max-height: 100px;', class: 'img-thumbnail img-template'
29+
- elsif value.start_with?(*links)
30+
%br
31+
= link_to value, target: 'blank' do
32+
%span
33+
%span.fa.fa-external-link.icon-space-r-half
34+
Open link
2235

2336
.col-lg-6.mb-3
2437
.card.mb-3
@@ -29,9 +42,9 @@
2942
%hr
3043
= render 'config_row', name: 'AWS S3 Bucket for Resumes', key: 'AWS_BUCKET'
3144
= render 'config_row', name: 'AWS S3 Region', key: 'AWS_REGION'
32-
= render 'config_row', name: 'AWS S3 Region', key: 'AWS_REGION'
3345
= render 'config_row', name: 'AWS S3 Access Key ID', key: 'AWS_ACCESS_KEY_ID'
3446
= render 'config_row', name: 'AWS S3 Secret Access Key', key: 'AWS_SECRET_ACCESS_KEY', secret: true
47+
= render 'config_row', name: 'AWS S3 Endpoint', key: 'AWS_ENDPOINT', required: false
3548
%hr
3649
= render 'config_row', name: 'Domain Name', key: 'HM_DOMAIN_NAME'
3750
= render 'config_row', name: 'Domain Protocol', key: 'HM_DOMAIN_PROTOCOL', default: 'https'
@@ -42,4 +55,4 @@
4255
= render 'config_row', name: 'My MLH Application ID', key: 'MLH_KEY'
4356
= render 'config_row', name: 'My MLH Secret', key: 'MLH_SECRET', secret: true
4457
%hr
45-
= render 'config_row', name: 'Rollbar Access Token', key: 'ROLLBAR_ACCESS_TOKEN', secret: true
58+
= render 'config_row', name: 'Rollbar Access Token', key: 'ROLLBAR_ACCESS_TOKEN', secret: true, required: false

0 commit comments

Comments
 (0)