Move transaction server integrations into own file

Author: jeffyanta

pkg/code/server/transaction/airdrop.go

@@ -50,24 +50,6 @@ var (
 	cachedAirdropStatus = cache.NewCache(10_000)
 )
 
-type AirdropIntegration interface {
-	// GetWelcomeBonusAmount returns the amount that should be paid for the
-	// welcome bonus. Return 0 amount if the airdrop should not be sent.
-	GetWelcomeBonusAmount(ctx context.Context, owner *common.Account) (float64, currency_lib.Code, error)
-}
-
-type defaultAirdropIntegration struct{}
-
-// NewDefaultAirdropIntegration retuns an AirdropIntegration that sends $1 USD
-// to everyone
-func NewDefaultAirdropIntegration() AirdropIntegration {
-	return &defaultAirdropIntegration{}
-}
-
-func (i *defaultAirdropIntegration) GetWelcomeBonusAmount(ctx context.Context, owner *common.Account) (float64, currency_lib.Code, error) {
-	return 1.0, currency_lib.USD, nil
-}
-
 func (s *transactionServer) Airdrop(ctx context.Context, req *transactionpb.AirdropRequest) (*transactionpb.AirdropResponse, error) {
 	log := s.log.WithFields(logrus.Fields{
 		"method":       "Airdrop",

pkg/code/server/transaction/integration.go

@@ -0,0 +1,55 @@
+package transaction_v2
+
+import (
+	"context"
+
+	transactionpb "github.com/code-payments/code-protobuf-api/generated/go/transaction/v2"
+
+	"github.com/code-payments/code-server/pkg/code/common"
+	"github.com/code-payments/code-server/pkg/code/data/intent"
+	currency_lib "github.com/code-payments/code-server/pkg/currency"
+)
+
+type SubmitIntentIntegration interface {
+	// AllowCreation determines whether the new intent creation should be allowed
+	// with app-specific validation rules
+	AllowCreation(ctx context.Context, intentRecord *intent.Record, metadata *transactionpb.Metadata, actions []*transactionpb.Action) error
+
+	// OnSuccess is a best-effort callback when an intent has been successfully
+	// submitted
+	OnSuccess(ctx context.Context, intentRecord *intent.Record) error
+}
+
+type defaultSubmitIntentIntegration struct {
+}
+
+// NewDefaultSubmitIntentIntegration retuns a SubmitIntentIntegration that allows everything
+func NewDefaultSubmitIntentIntegration() SubmitIntentIntegration {
+	return &defaultSubmitIntentIntegration{}
+}
+
+func (i *defaultSubmitIntentIntegration) AllowCreation(ctx context.Context, intentRecord *intent.Record, metadata *transactionpb.Metadata, actions []*transactionpb.Action) error {
+	return nil
+}
+
+func (i *defaultSubmitIntentIntegration) OnSuccess(ctx context.Context, intentRecord *intent.Record) error {
+	return nil
+}
+
+type AirdropIntegration interface {
+	// GetWelcomeBonusAmount returns the amount that should be paid for the
+	// welcome bonus. Return 0 amount if the airdrop should not be sent.
+	GetWelcomeBonusAmount(ctx context.Context, owner *common.Account) (float64, currency_lib.Code, error)
+}
+
+type defaultAirdropIntegration struct{}
+
+// NewDefaultAirdropIntegration retuns an AirdropIntegration that sends $1 USD
+// to everyone
+func NewDefaultAirdropIntegration() AirdropIntegration {
+	return &defaultAirdropIntegration{}
+}
+
+func (i *defaultAirdropIntegration) GetWelcomeBonusAmount(ctx context.Context, owner *common.Account) (float64, currency_lib.Code, error) {
+	return 1.0, currency_lib.USD, nil
+}

pkg/code/server/transaction/intent.go

@@ -37,32 +37,6 @@ import (
 	"github.com/code-payments/code-server/pkg/solana/token"
 )
 
-type SubmitIntentIntegration interface {
-	// AllowCreation determines whether the new intent creation should be allowed
-	// with app-specific validation rules
-	AllowCreation(ctx context.Context, intentRecord *intent.Record, metadata *transactionpb.Metadata, actions []*transactionpb.Action) error
-
-	// OnSuccess is a best-effort callback when an intent has been successfully
-	// submitted
-	OnSuccess(ctx context.Context, intentRecord *intent.Record) error
-}
-
-type defaultSubmitIntentIntegration struct {
-}
-
-// NewDefaultSubmitIntentIntegration retuns a SubmitIntentIntegration that allows everything
-func NewDefaultSubmitIntentIntegration() SubmitIntentIntegration {
-	return &defaultSubmitIntentIntegration{}
-}
-
-func (i *defaultSubmitIntentIntegration) AllowCreation(ctx context.Context, intentRecord *intent.Record, metadata *transactionpb.Metadata, actions []*transactionpb.Action) error {
-	return nil
-}
-
-func (i *defaultSubmitIntentIntegration) OnSuccess(ctx context.Context, intentRecord *intent.Record) error {
-	return nil
-}
-
 func (s *transactionServer) SubmitIntent(streamer transactionpb.Transaction_SubmitIntentServer) error {
 	// Bound the total RPC. Keeping the timeout higher to see where we land because
 	// there's a lot of stuff happening in this method.