Skip to content

Commit c979972

Browse files
committed
Cleanup
1 parent c515e30 commit c979972

File tree

3 files changed

+0
-5
lines changed

3 files changed

+0
-5
lines changed

src/modcamera.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -369,7 +369,6 @@ const mp_rom_map_elem_t mp_camera_hal_gainceiling_table[] = {
369369
{ MP_ROM_QSTR(MP_QSTR_128X), MP_ROM_INT(GAINCEILING_128X) },
370370
};
371371

372-
//TODO: Makros with convertion function, since the API will use standarized values.
373372
// Helper functions to get and set camera and sensor information
374373
#define SENSOR_STATUS_GETSET(type, name, status_field_name, setter_function_name) \
375374
SENSOR_GETSET(type, name, status.status_field_name, setter_function_name)

src/modcamera.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,6 @@ defined (MICROPY_CAMERA_PIN_PCLK) && defined (MICROPY_CAMERA_PIN_VSYNC) && defin
8888

8989
typedef pixformat_t hal_camera_pixformat_t;
9090
typedef framesize_t hal_camera_framesize_t;
91-
typedef camera_fb_location_t hal_camera_fb_location_t;
9291
typedef camera_grab_mode_t hal_camera_grabmode_t;
9392
typedef gainceiling_t hal_camera_gainceiling_t;
9493

@@ -109,9 +108,7 @@ typedef hal_camera_pixformat_t mp_camera_pixformat_t;
109108
typedef hal_camera_framesize_t mp_camera_framesize_t;
110109
typedef hal_camera_grabmode_t mp_camera_grabmode_t;
111110
typedef hal_camera_gainceiling_t mp_camera_gainceiling_t;
112-
// typedef hal_camera_fb_location_t mp_camera_fb_location_t; //not used at the moment, but might be used in the future
113111

114-
// TODO: Define how to integrate external time source in constructor (e.g. in ESP is LED-Timer).
115112
/**
116113
* @brief Constructs the camera hardware abstraction layer.
117114
* @details The Port-plattform shall define a default pwm-time source and also frame buffer location (no input)

src/modcamera_api.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,6 @@ static mp_obj_t camera_convert(mp_obj_t self_in, mp_obj_t arg) {
162162
static MP_DEFINE_CONST_FUN_OBJ_2(camera_convert_obj, camera_convert);
163163

164164
static mp_obj_t camera_reconfigure(size_t n_args, const mp_obj_t *pos_args, mp_map_t *kw_args){
165-
//OPEN: Validate inputs
166165
mp_camera_obj_t *self = MP_OBJ_TO_PTR(pos_args[0]);
167166
enum { ARG_frame_size, ARG_pixel_format, ARG_grab_mode, ARG_fb_count };
168167
static const mp_arg_t allowed_args[] = {

0 commit comments

Comments
 (0)