feat(Makefile): update golangci-lint 1.56.2->1.63.4

Author: aauren

.golangci.yml

@@ -3,21 +3,21 @@ run:
 linters:
   enable:
     - bodyclose
+    - copyloopvar
     - dogsled
     - dupl
     - durationcheck
-    - exportloopref
     - exhaustive
     - gochecknoinits
     - goconst
     - gocritic
     - gofmt
     - goimports
-    - gomnd
     - gosec
     - govet
     - lll
     - misspell
+    - mnd
     - nakedret
     - noctx
     - nolintlint
@@ -35,24 +35,24 @@ issues:
     # Excluding single digits from magic number detector because it produces too many obvious results (like klog)
     - text: "Magic number: [0-9]{1},"
       linters:
-        - gomnd
+        - mnd
     # Exclude file masks from magic number detector because these numbers are obvious
     - text: "Magic number: 0[0-7]{3},"
       linters:
-        - gomnd
+        - mnd
     # Exlude IP masks netmasks as substituting them for constants only makes these less obvious
     - text: "Magic number: 255,"
       linters:
-        - gomnd
+        - mnd
       path: pkg/controllers/proxy/network_services_controller.go
     # Exclude IP netmasks from magic number detector because these numbers are obvious
     - text: "Magic number: 32,"
       linters:
-        - gomnd
+        - mnd
     # Exclude decimal bases from magic number detector because these numbers are obvious
     - text: "Magic number: 10,"
       linters:
-        - gomnd
+        - mnd
     # Exclude file mask security findings as we are always intentional about the file masks we use
     - text: "G306:"
       linters:
@@ -70,6 +70,7 @@ issues:
   # always show all issues of a type rather than showing 3
   max-same-issues: 0
 output:
-  format: tab
+  formats:
+    - format: tab
   print-issued-lines: true
   print-linter-name: true

Makefile

@@ -26,7 +26,7 @@ BUILDTIME_BASE?=$(DOCKER_BUILD_IMAGE)
 # Do not bump past Alpine 3.18 until upstream netfilter problems in iptables v1.8.10 are resolved. See:
 # https://github.com/cloudnativelabs/kube-router/issues/1676
 RUNTIME_BASE?=alpine:3.21
-DOCKER_LINT_IMAGE?=golangci/golangci-lint:v1.56.2
+DOCKER_LINT_IMAGE?=golangci/golangci-lint:v1.63.4
 DOCKER_MARKDOWNLINT_IMAGE?=tmknom/markdownlint:0.39.0
 GOBGP_VERSION=v3.29.0
 QEMU_IMAGE?=multiarch/qemu-user-static

pkg/controllers/lballoc/lballoc.go

@@ -155,7 +155,7 @@ func (lbc *LoadBalancerController) runLeaderElection(ctx context.Context, isLead
 	leaderelection.RunOrDie(ctx, leaderelection.LeaderElectionConfig{
 		Lock:            lbc.lock,
 		ReleaseOnCancel: true,
-		LeaseDuration:   15 * time.Second, //nolint:gomnd // No reason for a 15 second constant
+		LeaseDuration:   15 * time.Second, //nolint:mnd // No reason for a 15 second constant
 		RenewDeadline:   10 * time.Second,
 		RetryPeriod:     2 * time.Second,
 		Callbacks: leaderelection.LeaderCallbacks{

pkg/options/options.go

@@ -89,7 +89,7 @@ type KubeRouterConfig struct {
 }
 
 func NewKubeRouterConfig() *KubeRouterConfig {
-	//nolint:gomnd // Here we are specifying the names of the literals which is very similar to constant behavior
+	//nolint:mnd // Here we are specifying the names of the literals which is very similar to constant behavior
 	return &KubeRouterConfig{
 		BGPGracefulRestartDeferralTime: 360 * time.Second,
 		BGPGracefulRestartTime:         90 * time.Second,

pkg/utils/linux_routingtest.go

@@ -32,10 +32,10 @@ func NewFakeLocalLinkQuerier(addrStrings []string, mtus []int) *FakeLocalLinkQue
 		ip := net.ParseIP(addr)
 		var netMask net.IPMask
 		if ip.To4() != nil {
-			//nolint:gomnd // Hardcoded value is used for testing purposes
+			//nolint:mnd // Hardcoded value is used for testing purposes
 			netMask = net.CIDRMask(24, 32)
 		} else {
-			//nolint:gomnd // Hardcoded value is used for testing purposes
+			//nolint:mnd // Hardcoded value is used for testing purposes
 			netMask = net.CIDRMask(64, 128)
 		}
 		ipNet := &net.IPNet{