You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@@ -154,25 +153,25 @@ Here is a tutorial about how to sent a patch request for review.
154
153
155
154
### Setup
156
155
157
-
Hue project uses GitHub Pull Requests (PR) for code reviews. The advantage of Pull Request is that the CI (syntax check, tests...) automatically runs for you.
156
+
Hue project uses GitHub Pull Requests (PR) for code reviews. It also automatically runs the CI (syntax check, tests...) for you.
158
157
159
158
If you've never used git and github before, there are bunch of things you need to [do](https://kbroman.org/github_tutorial/pages/first_time.html) before going further.
Create a new branch with the jira id (HUE-XXX) as the branch name:
164
+
Create a new branch with the Github issue GH-XXX or explicit name as the branch name:
166
165
167
166
git checkout master
168
167
git pull --rebase origin master
169
-
git checkout -b HUE-XXX
168
+
git checkout -b GH-XXX
170
169
171
170
Then make your changes in code:
172
171
173
172
git add <file>
174
173
git diff --cached
175
-
git commit -m "HUE-XXX <Ticket summary>"
174
+
git commit -m "GH-XXX <Ticket summary>"
176
175
177
176
### Post a review
178
177
@@ -187,9 +186,9 @@ Or push to your branch in your repository forks by doing one time:
187
186
188
187
Then just:
189
188
190
-
git push bob HEAD:ISSUE-1000-fix
189
+
git push bob HEAD:GH-1000-fix
191
190
192
-
And create the pull request via the button on the https://github.com/cloudera/hue/tree/ISSUE-1000-fix page.
191
+
And create the pull request via the button on the https://github.com/cloudera/hue/tree/GH-1000-fix page.
193
192
194
193
**Note**:
195
194
If you have more than one diff, update `HEAD~1..HEAD` accordingly (e.g. `HEAD~2..HEAD`)
@@ -230,7 +229,7 @@ Once we get ship it from at least one reviewer, we can push the changes to maste
230
229
231
230
We hope that these commands will make your life easier and encourage you to [contribute to Hue](https://github.com/cloudera/hue/blob/master/CONTRIBUTING.md) 😉
232
231
233
-
As usual feel free to send feedback on the [Forum](https://discourse.gethue.com/) list or [@gethue](https://twitter.com/gethue)!
232
+
As usual feel free to send feedback on the [Forum](https://discourse.gethue.com/) list or [GitHub issues](https://github.com/cloudera/hue/issues)!
234
233
235
234
236
235
## API Server
@@ -533,10 +532,10 @@ Developing applications for Hue requires a minimal amount of CSS
533
532
534
533
In a nutshell, front-end development is using:
535
534
536
-
*[Mako](http://www.makotemplates.org/) is the templating language (Mako to be slowly removed in [HUE-9036](https://issues.cloudera.org/browse/HUE-9036))
535
+
*[Vue.js](https://vuejs.org/) to script the custom interactions
536
+
* TypeScript
537
537
*[Bootstrap](http://twitter.github.com/bootstrap/) to layout your app
538
-
*[Knockout js](http://knockoutjs.com/) to script the custom interactions
539
-
538
+
*[Mako](http://www.makotemplates.org/) is the templating language (currently being removed in favor of Vue.js))
540
539
541
540
### Javascript
542
541
@@ -813,18 +812,10 @@ Those are tagged with `integration` either at the class or method level:
813
812
@attr('integration')
814
813
def test_add_ldap_users_case_sensitivity(self):
815
814
if is_live_cluster():
816
-
raise SkipTest('HUE-2897: Cannot yet guarantee database is case sensitive')
815
+
raise SkipTest('GH-2897: Cannot yet guarantee database is case sensitive')
817
816
818
817
...
819
818
820
-
Historically, the same thing used to be done with the `requires_hadoop` tag:
821
-
822
-
from nose.plugins.attrib import attr
823
-
824
-
@attr('requires_hadoop')
825
-
def your_test():
826
-
...
827
-
828
819
## Releasing
829
820
830
821
The checklist below details the steps. Then send the release notes to the [Forum](https://discourse.gethue.com/) and https://twitter.com/gethue!
@@ -833,7 +824,7 @@ Also update https://wikipedia.org/wiki/Hue_(Software).
833
824
834
825
### Version
835
826
836
-
Here is an example of [commit](https://github.com/cloudera/hue/commit/9de217d6b6).
827
+
Here is an example of [release commit](https://github.com/cloudera/hue/commit/9de217d6b6).
837
828
838
829
Update the versions to the next release (current release +1):
0 commit comments