tests: fixes tests after package updates

Signed-off-by: Pamfilos Fokianos <[email protected]>

Author: pamfilos

setup.py

@@ -58,6 +58,7 @@
     'Flask-Debugtoolbar',
     'flask-wtf==0.15.1',
     'flask-login==0.4.1',
+    'flask-mail<0.10.0',
 
     # CAP specific libraries
     'jsonref>=1.0.0',

tests/conftest.py

@@ -126,7 +126,7 @@ def default_config():
                 DEBUG=False,
                 TESTING=True,
                 APP_GITLAB_OAUTH_ACCESS_TOKEN='testtoken',
-                MAIL_DEFAULT_SENDER="analysis-preservation-support@cern.ch",
+                MAIL_DEFAULT_SENDER="testtest@cern0.ch",
                 CADI_REGEX="^[A-Z]{3}-[0-9]{2}-[0-9]{3}$",
                 CMS_STATS_COMMITEE_AND_PAGS=dict({
                     'ABC': {

tests/integration/deposits/test_files_for_deposit.py

@@ -123,7 +123,7 @@ def test_deposit_files_returns_list_with_files_info(client, users,
     resp = client.get('/deposits/{}/files'.format(pid),
                       headers=auth_headers_for_user(owner))
 
-    files = resp.json
+    files = json.loads(resp.data)
 
     assert files[0]["filename"] == 'file_1.txt'
     assert files[0]["filesize"] == 12

tests/integration/deposits/test_get_deposits.py

@@ -1085,7 +1085,7 @@ def test_get_deposits_with_range_query(
 def test_get_deposit_when_superuser_returns_deposit_that_he_even_has_no_access_to(
     client, users, auth_headers_for_superuser, create_deposit
 ):
-    deposit = create_deposit(users['alice_user'], 'alice')
+    deposit = create_deposit(users['lhcb_user'], 'lhcb')
 
     resp = client.get(
         '/deposits/{}'.format(deposit['_deposit']['id']),
@@ -1098,8 +1098,8 @@ def test_get_deposit_when_superuser_returns_deposit_that_he_even_has_no_access_t
 def test_get_deposit_when_owner_returns_deposit(
     client, users, auth_headers_for_user, create_deposit
 ):
-    user = users['alice_user']
-    deposit = create_deposit(user, 'alice')
+    user = users['lhcb_user']
+    deposit = create_deposit(user, 'lhcb')
 
     resp = client.get(
         '/deposits/{}'.format(deposit['_deposit']['id']),
@@ -1112,8 +1112,8 @@ def test_get_deposit_when_owner_returns_deposit(
 def test_get_deposit_when_other_member_of_collaboration_returns_403(
     client, users, auth_headers_for_user, create_deposit
 ):
-    user, other_user = users['alice_user'], users['alice_user2']
-    deposit = create_deposit(user, 'alice')
+    user, other_user = users['lhcb_user'], users['lhcb_user2']
+    deposit = create_deposit(user, 'lhcb')
 
     resp = client.get(
         '/deposits/{}'.format(deposit['_deposit']['id']),
@@ -1127,8 +1127,8 @@ def test_get_deposit_when_other_member_of_collaboration_returns_403(
 def test_get_deposit_when_user_has_read_or_admin_acces_can_see_deposit(
     action, client, users, auth_headers_for_user, create_deposit
 ):
-    user, other_user = users['alice_user'], users['alice_user2']
-    deposit = create_deposit(user, 'alice')
+    user, other_user = users['atlas_user'], users['atlas_user2']
+    deposit = create_deposit(user, 'atlas')
     pid = deposit['_deposit']['id']
     permissions = [
         {'email': other_user.email, 'type': 'user', 'op': 'add', 'action': action}
@@ -1153,9 +1153,10 @@ def test_get_deposit_when_user_has_read_or_admin_acces_can_see_deposit(
 def test_get_deposit_when_user_is_member_of_egroup_with_read_or_admin_acces_can_see_deposit(
     action, client, users, auth_headers_for_user, create_deposit
 ):
-    user, other_user = users['alice_user'], users['lhcb_user']
+    user = users['atlas_user']
+    other_user = users['lhcb_user']
     add_role_to_user(other_user, '[email protected]')
-    deposit = create_deposit(user, 'alice')
+    deposit = create_deposit(user, 'atlas')
     pid = deposit['_deposit']['id']
     permissions = [
         {

tests/integration/schemas/test_schemas_views.py

@@ -1867,7 +1867,8 @@ def test_patch_notifications_config(
         headers=json_headers + auth_headers_for_user(owner),
     )
     assert resp.status_code == 400
-    assert resp.json['message'] == 'Could not apply json-patch to object: string indices must be integers'
+    assert resp.json['message'] == ('Could not apply json-patch to object: '
+        'Document is expected to be sequence of operations, got a sequence of strings.')
 
 
 def test_post_notifications_config(