Skip to content

Commit a654e4b

Browse files
horenmarhorenmar
committed
Don't include numerically unstable tests in approvals
1 parent ef71358 commit a654e4b

18 files changed

+19
-255
lines changed

‎tests/SelfTest/Baselines/automake.sw.approved.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -354,7 +354,6 @@ b1!
354354
:test-result: FAIL nested sections can be skipped dynamically at runtime
355355
:test-result: PASS non streamable - with conv. op
356356
:test-result: PASS non-copyable objects
357-
:test-result: PASS normal_cdf
358357
:test-result: PASS normal_quantile
359358
:test-result: PASS not allowed
360359
:test-result: FAIL not prints unscoped info from previous failures

‎tests/SelfTest/Baselines/automake.sw.multi.approved.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -343,7 +343,6 @@
343343
:test-result: FAIL nested sections can be skipped dynamically at runtime
344344
:test-result: PASS non streamable - with conv. op
345345
:test-result: PASS non-copyable objects
346-
:test-result: PASS normal_cdf
347346
:test-result: PASS normal_quantile
348347
:test-result: PASS not allowed
349348
:test-result: FAIL not prints unscoped info from previous failures

‎tests/SelfTest/Baselines/compact.sw.approved.txt

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -2582,19 +2582,6 @@ Skip.tests.cpp:<line number>: skipped:
25822582
!
25832583
Tricky.tests.cpp:<line number>: passed: s == "7" for: "7" == "7"
25842584
Tricky.tests.cpp:<line number>: passed: ti == typeid(int) for: {?} == {?}
2585-
InternalBenchmark.tests.cpp:<line number>: passed: normal_cdf(0.000000) == Approx(0.50000000000000000) for: 0.5 == Approx( 0.5 )
2586-
InternalBenchmark.tests.cpp:<line number>: passed: normal_cdf(1.000000) == Approx(0.84134474606854293) for: 0.84134474606854293
2587-
==
2588-
Approx( 0.84134474606854293 )
2589-
InternalBenchmark.tests.cpp:<line number>: passed: normal_cdf(-1.000000) == Approx(0.15865525393145705) for: 0.15865525393145707
2590-
==
2591-
Approx( 0.15865525393145705 )
2592-
InternalBenchmark.tests.cpp:<line number>: passed: normal_cdf(2.809729) == Approx(0.99752083845315409) for: 0.99752083845315409
2593-
==
2594-
Approx( 0.99752083845315409 )
2595-
InternalBenchmark.tests.cpp:<line number>: passed: normal_cdf(-1.352570) == Approx(0.08809652095066035) for: 0.08809652095066035
2596-
==
2597-
Approx( 0.08809652095066035 )
25982585
InternalBenchmark.tests.cpp:<line number>: passed: normal_quantile(0.551780) == Approx(0.13015979861484198) for: 0.13015979861484195
25992586
==
26002587
Approx( 0.13015979861484198 )
@@ -2853,7 +2840,7 @@ InternalBenchmark.tests.cpp:<line number>: passed: med == 18. for: 18.0 == 18.0
28532840
InternalBenchmark.tests.cpp:<line number>: passed: q3 == 23. for: 23.0 == 23.0
28542841
Misc.tests.cpp:<line number>: passed:
28552842
Misc.tests.cpp:<line number>: passed:
2856-
test cases: 417 | 312 passed | 85 failed | 6 skipped | 14 failed as expected
2857-
assertions: 2260 | 2079 passed | 146 failed | 35 failed as expected
2843+
test cases: 416 | 311 passed | 85 failed | 6 skipped | 14 failed as expected
2844+
assertions: 2255 | 2074 passed | 146 failed | 35 failed as expected
28582845

28592846

‎tests/SelfTest/Baselines/compact.sw.multi.approved.txt

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -2571,19 +2571,6 @@ Misc.tests.cpp:<line number>: passed: a != b for: 1 != 2
25712571
Skip.tests.cpp:<line number>: skipped:
25722572
Tricky.tests.cpp:<line number>: passed: s == "7" for: "7" == "7"
25732573
Tricky.tests.cpp:<line number>: passed: ti == typeid(int) for: {?} == {?}
2574-
InternalBenchmark.tests.cpp:<line number>: passed: normal_cdf(0.000000) == Approx(0.50000000000000000) for: 0.5 == Approx( 0.5 )
2575-
InternalBenchmark.tests.cpp:<line number>: passed: normal_cdf(1.000000) == Approx(0.84134474606854293) for: 0.84134474606854293
2576-
==
2577-
Approx( 0.84134474606854293 )
2578-
InternalBenchmark.tests.cpp:<line number>: passed: normal_cdf(-1.000000) == Approx(0.15865525393145705) for: 0.15865525393145707
2579-
==
2580-
Approx( 0.15865525393145705 )
2581-
InternalBenchmark.tests.cpp:<line number>: passed: normal_cdf(2.809729) == Approx(0.99752083845315409) for: 0.99752083845315409
2582-
==
2583-
Approx( 0.99752083845315409 )
2584-
InternalBenchmark.tests.cpp:<line number>: passed: normal_cdf(-1.352570) == Approx(0.08809652095066035) for: 0.08809652095066035
2585-
==
2586-
Approx( 0.08809652095066035 )
25872574
InternalBenchmark.tests.cpp:<line number>: passed: normal_quantile(0.551780) == Approx(0.13015979861484198) for: 0.13015979861484195
25882575
==
25892576
Approx( 0.13015979861484198 )
@@ -2842,7 +2829,7 @@ InternalBenchmark.tests.cpp:<line number>: passed: med == 18. for: 18.0 == 18.0
28422829
InternalBenchmark.tests.cpp:<line number>: passed: q3 == 23. for: 23.0 == 23.0
28432830
Misc.tests.cpp:<line number>: passed:
28442831
Misc.tests.cpp:<line number>: passed:
2845-
test cases: 417 | 312 passed | 85 failed | 6 skipped | 14 failed as expected
2846-
assertions: 2260 | 2079 passed | 146 failed | 35 failed as expected
2832+
test cases: 416 | 311 passed | 85 failed | 6 skipped | 14 failed as expected
2833+
assertions: 2255 | 2074 passed | 146 failed | 35 failed as expected
28472834

28482835

‎tests/SelfTest/Baselines/console.std.approved.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1598,6 +1598,6 @@ due to unexpected exception with message:
15981598
Why would you throw a std::string?
15991599

16001600
===============================================================================
1601-
test cases: 417 | 326 passed | 70 failed | 7 skipped | 14 failed as expected
1602-
assertions: 2243 | 2079 passed | 129 failed | 35 failed as expected
1601+
test cases: 416 | 325 passed | 70 failed | 7 skipped | 14 failed as expected
1602+
assertions: 2238 | 2074 passed | 129 failed | 35 failed as expected
16031603

‎tests/SelfTest/Baselines/console.sw.approved.txt

Lines changed: 2 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -17075,45 +17075,6 @@ Tricky.tests.cpp:<line number>: PASSED:
1707517075
with expansion:
1707617076
{?} == {?}
1707717077

17078-
-------------------------------------------------------------------------------
17079-
normal_cdf
17080-
-------------------------------------------------------------------------------
17081-
InternalBenchmark.tests.cpp:<line number>
17082-
...............................................................................
17083-
17084-
InternalBenchmark.tests.cpp:<line number>: PASSED:
17085-
CHECK( normal_cdf(0.000000) == Approx(0.50000000000000000) )
17086-
with expansion:
17087-
0.5 == Approx( 0.5 )
17088-
17089-
InternalBenchmark.tests.cpp:<line number>: PASSED:
17090-
CHECK( normal_cdf(1.000000) == Approx(0.84134474606854293) )
17091-
with expansion:
17092-
0.84134474606854293
17093-
==
17094-
Approx( 0.84134474606854293 )
17095-
17096-
InternalBenchmark.tests.cpp:<line number>: PASSED:
17097-
CHECK( normal_cdf(-1.000000) == Approx(0.15865525393145705) )
17098-
with expansion:
17099-
0.15865525393145707
17100-
==
17101-
Approx( 0.15865525393145705 )
17102-
17103-
InternalBenchmark.tests.cpp:<line number>: PASSED:
17104-
CHECK( normal_cdf(2.809729) == Approx(0.99752083845315409) )
17105-
with expansion:
17106-
0.99752083845315409
17107-
==
17108-
Approx( 0.99752083845315409 )
17109-
17110-
InternalBenchmark.tests.cpp:<line number>: PASSED:
17111-
CHECK( normal_cdf(-1.352570) == Approx(0.08809652095066035) )
17112-
with expansion:
17113-
0.08809652095066035
17114-
==
17115-
Approx( 0.08809652095066035 )
17116-
1711717078
-------------------------------------------------------------------------------
1711817079
normal_quantile
1711917080
-------------------------------------------------------------------------------
@@ -18933,6 +18894,6 @@ Misc.tests.cpp:<line number>
1893318894
Misc.tests.cpp:<line number>: PASSED:
1893418895

1893518896
===============================================================================
18936-
test cases: 417 | 312 passed | 85 failed | 6 skipped | 14 failed as expected
18937-
assertions: 2260 | 2079 passed | 146 failed | 35 failed as expected
18897+
test cases: 416 | 311 passed | 85 failed | 6 skipped | 14 failed as expected
18898+
assertions: 2255 | 2074 passed | 146 failed | 35 failed as expected
1893818899

‎tests/SelfTest/Baselines/console.sw.multi.approved.txt

Lines changed: 2 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -17064,45 +17064,6 @@ Tricky.tests.cpp:<line number>: PASSED:
1706417064
with expansion:
1706517065
{?} == {?}
1706617066

17067-
-------------------------------------------------------------------------------
17068-
normal_cdf
17069-
-------------------------------------------------------------------------------
17070-
InternalBenchmark.tests.cpp:<line number>
17071-
...............................................................................
17072-
17073-
InternalBenchmark.tests.cpp:<line number>: PASSED:
17074-
CHECK( normal_cdf(0.000000) == Approx(0.50000000000000000) )
17075-
with expansion:
17076-
0.5 == Approx( 0.5 )
17077-
17078-
InternalBenchmark.tests.cpp:<line number>: PASSED:
17079-
CHECK( normal_cdf(1.000000) == Approx(0.84134474606854293) )
17080-
with expansion:
17081-
0.84134474606854293
17082-
==
17083-
Approx( 0.84134474606854293 )
17084-
17085-
InternalBenchmark.tests.cpp:<line number>: PASSED:
17086-
CHECK( normal_cdf(-1.000000) == Approx(0.15865525393145705) )
17087-
with expansion:
17088-
0.15865525393145707
17089-
==
17090-
Approx( 0.15865525393145705 )
17091-
17092-
InternalBenchmark.tests.cpp:<line number>: PASSED:
17093-
CHECK( normal_cdf(2.809729) == Approx(0.99752083845315409) )
17094-
with expansion:
17095-
0.99752083845315409
17096-
==
17097-
Approx( 0.99752083845315409 )
17098-
17099-
InternalBenchmark.tests.cpp:<line number>: PASSED:
17100-
CHECK( normal_cdf(-1.352570) == Approx(0.08809652095066035) )
17101-
with expansion:
17102-
0.08809652095066035
17103-
==
17104-
Approx( 0.08809652095066035 )
17105-
1710617067
-------------------------------------------------------------------------------
1710717068
normal_quantile
1710817069
-------------------------------------------------------------------------------
@@ -18922,6 +18883,6 @@ Misc.tests.cpp:<line number>
1892218883
Misc.tests.cpp:<line number>: PASSED:
1892318884

1892418885
===============================================================================
18925-
test cases: 417 | 312 passed | 85 failed | 6 skipped | 14 failed as expected
18926-
assertions: 2260 | 2079 passed | 146 failed | 35 failed as expected
18886+
test cases: 416 | 311 passed | 85 failed | 6 skipped | 14 failed as expected
18887+
assertions: 2255 | 2074 passed | 146 failed | 35 failed as expected
1892718888

‎tests/SelfTest/Baselines/junit.sw.approved.txt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<testsuitesloose text artifact
33
>
4-
<testsuite name="<exe-name>" errors="17" failures="129" skipped="12" tests="2272" hostname="tbd" time="{duration}" timestamp="{iso8601-timestamp}">
4+
<testsuite name="<exe-name>" errors="17" failures="129" skipped="12" tests="2267" hostname="tbd" time="{duration}" timestamp="{iso8601-timestamp}">
55
<properties>
66
<property name="random-seed" value="1"/>
77
<property name="filters" value="&quot;*&quot; ~[!nonportable] ~[!benchmark] ~[approvals]"/>
@@ -1932,7 +1932,6 @@ b1!
19321932
</testcase>
19331933
<testcase classname="<exe-name>.global" name="non streamable - with conv. op" time="{duration}" status="run"/>
19341934
<testcase classname="<exe-name>.global" name="non-copyable objects" time="{duration}" status="run"/>
1935-
<testcase classname="<exe-name>.global" name="normal_cdf" time="{duration}" status="run"/>
19361935
<testcase classname="<exe-name>.global" name="normal_quantile" time="{duration}" status="run"/>
19371936
<testcase classname="<exe-name>.global" name="not allowed" time="{duration}" status="run"/>
19381937
<testcase classname="<exe-name>.global" name="not prints unscoped info from previous failures" time="{duration}" status="run">

‎tests/SelfTest/Baselines/junit.sw.multi.approved.txt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<testsuites>
3-
<testsuite name="<exe-name>" errors="17" failures="129" skipped="12" tests="2272" hostname="tbd" time="{duration}" timestamp="{iso8601-timestamp}">
3+
<testsuite name="<exe-name>" errors="17" failures="129" skipped="12" tests="2267" hostname="tbd" time="{duration}" timestamp="{iso8601-timestamp}">
44
<properties>
55
<property name="random-seed" value="1"/>
66
<property name="filters" value="&quot;*&quot; ~[!nonportable] ~[!benchmark] ~[approvals]"/>
@@ -1931,7 +1931,6 @@ b1!
19311931
</testcase>
19321932
<testcase classname="<exe-name>.global" name="non streamable - with conv. op" time="{duration}" status="run"/>
19331933
<testcase classname="<exe-name>.global" name="non-copyable objects" time="{duration}" status="run"/>
1934-
<testcase classname="<exe-name>.global" name="normal_cdf" time="{duration}" status="run"/>
19351934
<testcase classname="<exe-name>.global" name="normal_quantile" time="{duration}" status="run"/>
19361935
<testcase classname="<exe-name>.global" name="not allowed" time="{duration}" status="run"/>
19371936
<testcase classname="<exe-name>.global" name="not prints unscoped info from previous failures" time="{duration}" status="run">

‎tests/SelfTest/Baselines/sonarqube.sw.approved.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,6 @@ at AssertionHandler.tests.cpp:<line number>
121121
<testCase name="estimate_clock_resolution" duration="{duration}"/>
122122
<testCase name="mean" duration="{duration}"/>
123123
<testCase name="measure" duration="{duration}"/>
124-
<testCase name="normal_cdf" duration="{duration}"/>
125124
<testCase name="normal_quantile" duration="{duration}"/>
126125
<testCase name="resolution" duration="{duration}"/>
127126
<testCase name="run_for_at_least, chronometer" duration="{duration}"/>

0 commit comments

Comments
 (0)