React Native 0.60 support (#87)

* chore: ios example

* chore: fix lib on ios

* chore: fix android build

* chore: fix android events

* chore: fix lint, tests and flow

* chore: disable detox on CI, update README

* chore: update .gitignore

Co-Authored-By: Michał Pierzchała <[email protected]>

* setup autolinking for iOS

* use latest CLI to fix autolinking

Author: michalchudziak

.circleci/config.yml

@@ -1,7 +1,7 @@
 version: 2.1
 
 orbs:
-  rn: react-native-community/react-native@1.1.0
+  rn: react-native-community/react-native@1.2.1
 
 jobs:
   checkout_code:
@@ -51,33 +51,34 @@ workflows:
       - analyse:
           requires:
             - checkout_code
-      - rn/android_build:
-          name: build_android_debug
-          project_path: "example/android"
-          build_type: debug
-          requires:
-            - analyse
-      - rn/android_build:
-          name: build_android_release
-          project_path: "example/android"
-          build_type: release
-          requires:
-            - analyse
-      - rn/android_test:
-          detox_configuration: "android.emu.release"
-          detox_loglevel: "trace"
-          requires:
-            - build_android_release
-      - rn/ios_build_and_test:
-          project_path: "example/ios/example.xcodeproj"
-          derived_data_path: "example/ios/build"
-          device: "iPhone X"
-          build_configuration: "Release"
-          scheme: "example"
-          detox_configuration: "ios.sim.release"
-          detox_loglevel: "trace"
-          requires:
-            - analyse
+      # Disabled until Detox works correctly with 0.60
+      # - rn/android_build:
+      #     name: build_android_debug
+      #     project_path: "example/android"
+      #     build_type: debug
+      #     requires:
+      #       - analyse
+      # - rn/android_build:
+      #     name: build_android_release
+      #     project_path: "example/android"
+      #     build_type: release
+      #     requires:
+      #       - analyse
+      # - rn/android_test:
+      #     detox_configuration: "android.emu.release"
+      #     detox_loglevel: "trace"
+      #     requires:
+      #       - build_android_release
+      # - rn/ios_build_and_test:
+      #     project_path: "example/ios/example.xcworkspace"
+      #     derived_data_path: "example/ios/build"
+      #     device: "iPhone X"
+      #     build_configuration: "Release"
+      #     scheme: "example"
+      #     detox_configuration: "ios.sim.release"
+      #     detox_loglevel: "trace"
+      #     requires:
+      #       - analyse
       # To be uncommented as a part of https://github.com/react-native-community/react-native-slider/issues/34
       # - publish:
       #     requires:

.flowconfig

@@ -11,27 +11,37 @@
 ; Ignore duplicate module providers
 ; For RN Apps installed via npm, "Libraries" folder is inside
 ; "node_modules/react-native" but in the source repo it is in the root
-.*/Libraries/react-native/React.js
+node_modules/react-native/Libraries/react-native/React.js
 
 ; Ignore polyfills
-.*/Libraries/polyfills/.*
+node_modules/react-native/Libraries/polyfills/.*
 
-; Ignore metro
-.*/node_modules/metro/.*
+; These should not be required directly
+; require from fbjs/lib instead: require('fbjs/lib/warning')
+node_modules/warning/.*
+
+; Flow doesn't support platforms
+.*/Libraries/Utilities/HMRLoadingView.js
+
+[untyped]
+.*/node_modules/@react-native-community/cli/.*/.*
 
 [include]
 
 [libs]
 node_modules/react-native/Libraries/react-native/react-native-interface.js
 node_modules/react-native/flow/
-node_modules/react-native/flow-github/
 
 [options]
 emoji=true
 
 esproposal.optional_chaining=enable
 esproposal.nullish_coalescing=enable
 
+module.file_ext=.js
+module.file_ext=.json
+module.file_ext=.ios.js
+
 module.system=haste
 module.system.haste.use_name_reducers=true
 # get basename
@@ -44,28 +54,47 @@ module.system.haste.name_reducers='^\(.*\)\.android$' -> '\1'
 module.system.haste.name_reducers='^\(.*\)\.native$' -> '\1'
 module.system.haste.paths.blacklist=.*/__tests__/.*
 module.system.haste.paths.blacklist=.*/__mocks__/.*
-module.system.haste.paths.blacklist=<PROJECT_ROOT>/node_modules/react-native/Libraries/Animated/src/polyfills/.*
 module.system.haste.paths.whitelist=<PROJECT_ROOT>/node_modules/react-native/Libraries/.*
+module.system.haste.paths.whitelist=<PROJECT_ROOT>/node_modules/react-native/RNTester/.*
+module.system.haste.paths.whitelist=<PROJECT_ROOT>/node_modules/react-native/IntegrationTests/.*
+module.system.haste.paths.blacklist=<PROJECT_ROOT>/node_modules/react-native/Libraries/react-native/react-native-implementation.js
+module.system.haste.paths.blacklist=<PROJECT_ROOT>/node_modules/react-native/Libraries/Animated/src/polyfills/.*
 
 munge_underscores=true
 
-module.name_mapper='\(@react-native-community/slider\)' -> '<PROJECT_ROOT>/js/Slider.js'
 module.name_mapper='^[./a-zA-Z0-9$_-]+\.\(bmp\|gif\|jpg\|jpeg\|png\|psd\|svg\|webp\|m4v\|mov\|mp4\|mpeg\|mpg\|webm\|aac\|aiff\|caf\|m4a\|mp3\|wav\|html\|pdf\)$' -> 'RelativeImageStub'
-
-module.file_ext=.js
-module.file_ext=.jsx
-module.file_ext=.json
-module.file_ext=.native.js
+module.name_mapper='^\@react-native-community/slider\(.*\)$' -> '<PROJECT_ROOT>/js/Slider.js\1'
 
 suppress_type=$FlowIssue
 suppress_type=$FlowFixMe
 suppress_type=$FlowFixMeProps
 suppress_type=$FlowFixMeState
 
-suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(<VERSION>\\)? *\\(site=[a-z,_]*react_native[a-z,_]*\\)?)\\)
-suppress_comment=\\(.\\|\n\\)*\\$FlowIssue\\((\\(<VERSION>\\)? *\\(site=[a-z,_]*react_native[a-z,_]*\\)?)\\)?:? #[0-9]+
-suppress_comment=\\(.\\|\n\\)*\\$FlowFixedInNextDeploy
+suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(<VERSION>\\)? *\\(site=[a-z,_]*react_native\\(_ios\\)?_\\(oss\\|fb\\)[a-z,_]*\\)?)\\)
+suppress_comment=\\(.\\|\n\\)*\\$FlowIssue\\((\\(<VERSION>\\)? *\\(site=[a-z,_]*react_native\\(_ios\\)?_\\(oss\\|fb\\)[a-z,_]*\\)?)\\)?:? #[0-9]+
 suppress_comment=\\(.\\|\n\\)*\\$FlowExpectedError
 
+[lints]
+sketchy-null-number=warn
+sketchy-null-mixed=warn
+sketchy-number=warn
+untyped-type-import=warn
+nonstrict-import=warn
+deprecated-type=warn
+unsafe-getters-setters=warn
+inexact-spread=warn
+unnecessary-invariant=warn
+signature-verification-failure=warn
+deprecated-utility=error
+
+[strict]
+deprecated-type
+nonstrict-import
+sketchy-null
+unclear-type
+unsafe-getters-setters
+untyped-import
+untyped-type-import
+
 [version]
-^0.86.0
+^0.98.0

.gitignore

@@ -54,4 +54,6 @@ buck-out/
 
 # Bundle artifact
 *.jsbundle
-.tmp/
+.tmp/
+
+*/ios/Pods

README.md

@@ -14,11 +14,14 @@ or
 
 `npm install @react-native-community/slider --save`
 
-### Mostly automatic installation
+### Linking the module (React Native <= 0.59.X)
 
-`react-native link @react-native-community/slider`
+<details>
+<summary>Automatically link the library</summary>
+Run the following commannd in your terminal:
 
-### Manual installation
+`react-native link @react-native-community/slider`
+</details>
 
 <details>
 <summary>Manually link the library on iOS</summary>

android/build.gradle

@@ -37,6 +37,5 @@ repositories {
 
 dependencies {
   //noinspection GradleDynamicVersion
-  api "com.android.support:appcompat-v7:${rootProject.ext.supportLibVersion}"
   api 'com.facebook.react:react-native:+'
 }

android/src/main/java/com/reactnativecommunity/slider/ReactSlider.java

@@ -8,7 +8,7 @@
 
 import android.content.Context;
 import android.os.Build;
-import android.support.v7.widget.AppCompatSeekBar;
+import androidx.appcompat.widget.AppCompatSeekBar;
 import android.util.AttributeSet;
 import javax.annotation.Nullable;
 

android/src/main/java/com/reactnativecommunity/slider/ReactSliderManager.java

@@ -193,7 +193,7 @@ protected void addEventEmitters(final ThemedReactContext reactContext, final Rea
 
   @Override
   public Map getExportedCustomDirectEventTypeConstants() {
-    return MapBuilder.of(ReactSlidingCompleteEvent.EVENT_NAME, MapBuilder.of("registrationName", "onSlidingComplete"),
-        ReactSlidingStartEvent.EVENT_NAME, MapBuilder.of("registrationName", "onSlidingStart"));
+    return MapBuilder.of(ReactSlidingCompleteEvent.EVENT_NAME, MapBuilder.of("registrationName", "onRNCSliderSlidingComplete"),
+        ReactSlidingStartEvent.EVENT_NAME, MapBuilder.of("registrationName", "onRNCSliderSlidingStart"));
   }
 }