Skip to content

Commit 1eb6df0

Browse files
authored
Replace dispatchModern() calls with getEventData() (#444)
1 parent 98d5960 commit 1eb6df0

File tree

3 files changed

+12
-9
lines changed

3 files changed

+12
-9
lines changed

package/android/src/main/java/com/reactnativecommunity/slider/ReactSliderEvent.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@
77

88
package com.reactnativecommunity.slider;
99

10+
import androidx.annotation.Nullable;
1011
import com.facebook.react.bridge.Arguments;
1112
import com.facebook.react.bridge.WritableMap;
1213
import com.facebook.react.uimanager.events.Event;
13-
import com.facebook.react.uimanager.events.RCTModernEventEmitter;
1414

1515
/**
1616
* Event emitted by a ReactSliderManager when user changes slider position.
@@ -47,9 +47,10 @@ public short getCoalescingKey() {
4747
return 0;
4848
}
4949

50+
@Nullable
5051
@Override
51-
public void dispatchModern(RCTModernEventEmitter rctEventEmitter) {
52-
rctEventEmitter.receiveEvent(getViewTag(), getEventName(), serializeEventData());
52+
protected WritableMap getEventData() {
53+
return serializeEventData();
5354
}
5455

5556
private WritableMap serializeEventData() {

package/android/src/main/java/com/reactnativecommunity/slider/ReactSlidingCompleteEvent.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@
77

88
package com.reactnativecommunity.slider;
99

10+
import androidx.annotation.Nullable;
1011
import com.facebook.react.bridge.Arguments;
1112
import com.facebook.react.bridge.WritableMap;
1213
import com.facebook.react.uimanager.events.Event;
13-
import com.facebook.react.uimanager.events.RCTModernEventEmitter;
1414

1515
/**
1616
* Event emitted when the user finishes dragging the slider.
@@ -45,9 +45,10 @@ public boolean canCoalesce() {
4545
return false;
4646
}
4747

48+
@Nullable
4849
@Override
49-
public void dispatchModern(RCTModernEventEmitter rctEventEmitter) {
50-
rctEventEmitter.receiveEvent(getViewTag(), getEventName(), serializeEventData());
50+
protected WritableMap getEventData() {
51+
return serializeEventData();
5152
}
5253

5354
private WritableMap serializeEventData() {

package/android/src/main/java/com/reactnativecommunity/slider/ReactSlidingStartEvent.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@
77

88
package com.reactnativecommunity.slider;
99

10+
import androidx.annotation.Nullable;
1011
import com.facebook.react.bridge.Arguments;
1112
import com.facebook.react.bridge.WritableMap;
1213
import com.facebook.react.uimanager.events.Event;
13-
import com.facebook.react.uimanager.events.RCTModernEventEmitter;
1414

1515
/**
1616
* Event emitted when the user starts dragging the slider.
@@ -45,9 +45,10 @@ public boolean canCoalesce() {
4545
return false;
4646
}
4747

48+
@Nullable
4849
@Override
49-
public void dispatchModern(RCTModernEventEmitter rctEventEmitter) {
50-
rctEventEmitter.receiveEvent(getViewTag(), getEventName(), serializeEventData());
50+
protected WritableMap getEventData() {
51+
return serializeEventData();
5152
}
5253

5354
private WritableMap serializeEventData() {

0 commit comments

Comments
 (0)