Merge pull request #662 from cakephp/dev-tld

Don't treat "dev" as a safe TLD by default.

Author: saeideng

src/ToolbarService.php

@@ -131,7 +131,7 @@ protected function isSuspiciouslyProduction()
         }
 
         $tld = end($host);
-        $safeTopLevelDomains = ['localhost', 'dev', 'invalid', 'test', 'example', 'local'];
+        $safeTopLevelDomains = ['localhost', 'invalid', 'test', 'example', 'local'];
         $safeTopLevelDomains = array_merge($safeTopLevelDomains, (array)$this->getConfig('safeTld'));
 
         if (!in_array($tld, $safeTopLevelDomains, true) && !$this->getConfig('forceEnable')) {

tests/TestCase/ToolbarServiceTest.php

@@ -382,7 +382,7 @@ public function domainsProvider()
             ['10.14.34.5:80', true],
             ['myapp.localhost', true],
             ['myapp.local', true],
-            ['myapp.dev', true],
+            ['myapp.dev', false],
             ['myapp', true],
             ['myapp.invalid', true],
             ['myapp.test', true],