remove unnecessary debug level logging for autoscaler event (#1453)

What changed?

Emit metrics logging happens every "cooldown time" (10s by default) and thus created a ton of debug logging. These logging are not needed.

Why?

Some user complains about too much debug level logging

How did you test it?

unit test

Author: shijiesheng

internal/worker/concurrency_auto_scaler.go

@@ -216,11 +216,13 @@ func (c *ConcurrencyAutoScaler) logEvent(event autoScalerEvent) {
 	}
 	c.scope.Histogram(metricsPollerQuota, metricsPollerQuotaBuckets).RecordValue(float64(c.concurrency.PollerPermit.Quota()))
 	c.scope.Histogram(metricsPollerWaitTime, metricsPollerWaitTimeBuckets).RecordDuration(c.pollerWaitTime.Average())
-	c.log.Debug(autoScalerEventLogMsg,
-		zap.String("event", string(event)),
-		zap.Bool("enabled", c.enabled),
-		zap.Int("poller_quota", c.concurrency.PollerPermit.Quota()),
-	)
+	if event != autoScalerEventEmitMetrics {
+		c.log.Debug(autoScalerEventLogMsg,
+			zap.String("event", string(event)),
+			zap.Bool("enabled", c.enabled),
+			zap.Int("poller_quota", c.concurrency.PollerPermit.Quota()),
+		)
+	}
 }
 
 func (c *ConcurrencyAutoScaler) updatePollerPermit() {

internal/worker/concurrency_auto_scaler_test.go

@@ -301,15 +301,13 @@ func TestConcurrencyAutoScaler(t *testing.T) {
 
 			var actualEvents []eventLog
 			for _, event := range obs.FilterMessage(autoScalerEventLogMsg).All() {
-				if event.ContextMap()["event"] != string(autoScalerEventEmitMetrics) {
-					t.Log("event: ", event.ContextMap())
+				t.Log("event: ", event.ContextMap())
 
-					actualEvents = append(actualEvents, eventLog{
-						eventType:   autoScalerEvent(event.ContextMap()["event"].(string)),
-						enabled:     event.ContextMap()["enabled"].(bool),
-						pollerQuota: event.ContextMap()["poller_quota"].(int64),
-					})
-				}
+				actualEvents = append(actualEvents, eventLog{
+					eventType:   autoScalerEvent(event.ContextMap()["event"].(string)),
+					enabled:     event.ContextMap()["enabled"].(bool),
+					pollerQuota: event.ContextMap()["poller_quota"].(int64),
+				})
 			}
 			assert.ElementsMatch(t, tt.expectedEvents, actualEvents)
 		})