Add group test for serializations (#30)

* added tests for invalid groups in serializations

* remove leftover check

Signed-off-by: bytemare <[email protected]>

Author: bytemare

.github/workflows/ci.yml

@@ -1,10 +1,8 @@
 name: OPAQUE
 on:
-  push:
-    branches: [ main ]
   pull_request:
-    # The branches below must be a subset of the branches above
-    branches: [ main ]
+    branches:
+      - main
 
 permissions:
   contents: read
@@ -55,7 +53,6 @@ jobs:
 
   analyze:
     name: Analyze
-    if: github.event_name == 'push'
     runs-on: ubuntu-latest
     steps:
       - name: Checkout repo
@@ -87,6 +84,8 @@ jobs:
           args: >
             -Dsonar.projectKey=bytemare_opaque
             -Dsonar.organization=bytemare-github
-            -Dsonar.go.coverage.reportPaths=coverage.out -Dsonar.sources=.
-            -Dsonar.test.exclusions=tests/** -Dsonar.tests=tests/
+            -Dsonar.go.coverage.reportPaths=coverage.out
+            -Dsonar.sources=.
+            -Dsonar.test.exclusions=examples_test.go,tests/**
+            -Dsonar.tests=tests/
             -Dsonar.verbose=true

.github/workflows/codeql.yml

@@ -1,11 +1,9 @@
 name: "CodeQL"
 
 on:
-  push:
-    branches: [ main ]
   pull_request:
-    # The branches below must be a subset of the branches above
-    branches: [ main ]
+    branches:
+      - main
   schedule:
     - cron: '31 10 * * 0'
 

.github/workflows/snyk.yml

@@ -1,10 +1,7 @@
 name: Snyk
 
 on:
-  push:
-    branches: [ main ]
   pull_request:
-    # The branches below must be a subset of the branches above
     branches: [ main ]
   schedule:
     - cron: '31 10 * * 0'

deserializer.go

@@ -10,7 +10,6 @@ package opaque
 
 import (
 	"errors"
-	"log"
 
 	"github.com/bytemare/crypto/group"
 
@@ -191,8 +190,6 @@ func (d *Deserializer) KE2(ke2 []byte) (*message.KE2, error) {
 		return nil, errInvalidServerEPK
 	}
 
-	log.Printf("group %v", d.conf.Group)
-
 	return &message.KE2{
 		G:                  d.conf.Group,
 		CredentialResponse: cresp,

internal/encoding/group.go

@@ -9,7 +9,9 @@
 // Package encoding provides encoding utilities.
 package encoding
 
-import "github.com/bytemare/crypto/group"
+import (
+	"github.com/bytemare/crypto/group"
+)
 
 const (
 	ristrettoPointLength   = 32
@@ -46,7 +48,10 @@ var PointLength = map[group.Group]int{
 
 // SerializeScalar pads the given scalar if necessary.
 func SerializeScalar(s *group.Scalar, g group.Group) []byte {
-	length := ScalarLength[g]
+	length, ok := ScalarLength[g]
+	if !ok {
+		panic("invalid group identifier")
+	}
 
 	e := s.Bytes()
 

tests/encoding_test.go

@@ -11,9 +11,12 @@ package opaque_test
 import (
 	"bytes"
 	"encoding/hex"
+	"errors"
 	"fmt"
 	"testing"
 
+	"github.com/bytemare/crypto/group"
+
 	"github.com/bytemare/opaque/internal/encoding"
 )
 
@@ -215,3 +218,57 @@ func expectPanic(expectedError error, f func()) (bool, string) {
 
 	return true, ""
 }
+
+func TestSerializeScalarGroups(t *testing.T) {
+	// Valid Configurations
+	for _, conf := range confs {
+		g := group.Group(conf.Conf.AKE)
+		s := g.NewScalar().Random()
+		if hasPanic, err := hasPanic(func() { _ = encoding.SerializeScalar(s, g) }); hasPanic {
+			t.Fatalf("unexpected panic for valid group and scalar: %v", err)
+		}
+	}
+
+	// Invalid Configuration
+	g := group.Group(0)
+	expect := errors.New("invalid group identifier")
+	if hasPanic, err := expectPanic(expect, func() { _ = encoding.SerializeScalar(nil, g) }); !hasPanic {
+		t.Fatalf("expected panic for invalid group and scalar:\n\twant: %v\n\tgot: %v", expect, err)
+	}
+}
+
+func TestSerializeScalar(t *testing.T) {
+	length := 16
+	for _, conf := range confs {
+		g := group.Group(conf.Conf.AKE)
+		encoded := [32]byte{}
+		encoded[length] = 1
+		s, err := g.NewScalar().Decode(encoded[:])
+		if err != nil {
+			t.Fatal(err)
+		}
+
+		ser := encoding.SerializeScalar(s, g)
+		if len(ser) == length {
+			t.Fatalf("serialization did not pad correctly. Before %d / After %d", length, len(ser))
+		}
+	}
+}
+
+func TestSerializePointGroups(t *testing.T) {
+	// Valid Configurations
+	for _, conf := range confs {
+		g := group.Group(conf.Conf.AKE)
+		p := g.Base()
+		if hasPanic, err := hasPanic(func() { _ = encoding.SerializePoint(p, g) }); hasPanic {
+			t.Fatalf("unexpected panic for valid group and point: %v", err)
+		}
+	}
+
+	// Invalid Configuration
+	g := group.Group(0)
+	expect := errors.New("invalid group identifier")
+	if hasPanic, err := expectPanic(expect, func() { _ = encoding.SerializePoint(nil, g) }); !hasPanic {
+		t.Fatalf("expected panic for invalid group and point:\n\twant: %v\n\tgot: %v", expect, err)
+	}
+}

tests/oprf_test.go

@@ -26,11 +26,6 @@ import (
 	"github.com/bytemare/opaque/internal/tag"
 )
 
-func TestOPRFString(t *testing.T) {
-	p := oprf.RistrettoSha512
-	fmt.Println(p)
-}
-
 type oprfVector struct {
 	DST       string           `json:"groupDST"`
 	Hash      string           `json:"hash"`