Skip to content

Commit 885fda8

Browse files
committed
Support new deployments with non-latest Docker version
1 parent 8d9f058 commit 885fda8

File tree

3 files changed

+11
-21
lines changed

3 files changed

+11
-21
lines changed

Dockerfile.dapper

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -87,9 +87,6 @@ ARG SYSTEM_DOCKER_VERSION=17.06.107
8787
ARG SYSTEM_DOCKER_URL_amd64=https://github.com/burmilla/os-system-docker/releases/download/${SYSTEM_DOCKER_VERSION}/docker-amd64-${SYSTEM_DOCKER_VERSION}.tgz
8888
ARG SYSTEM_DOCKER_URL_arm64=https://github.com/burmilla/os-system-docker/releases/download/${SYSTEM_DOCKER_VERSION}/docker-arm64-${SYSTEM_DOCKER_VERSION}.tgz
8989

90-
ARG USER_DOCKER_VERSION=latest
91-
ARG USER_DOCKER_ENGINE_VERSION=docker-${USER_DOCKER_VERSION}
92-
9390
ARG AZURE_SERVICE=false
9491
ARG PROXMOXVE_SERVICE=false
9592
ARG SKIP_BUILD=false
@@ -132,8 +129,6 @@ ENV BUILD_DOCKER_URL=BUILD_DOCKER_URL_${ARCH} \
132129
SYSTEM_DOCKER_URL=SYSTEM_DOCKER_URL_${ARCH} \
133130
SYSTEM_DOCKER_URL_amd64=${SYSTEM_DOCKER_URL_amd64} \
134131
SYSTEM_DOCKER_URL_arm64=${SYSTEM_DOCKER_URL_arm64} \
135-
USER_DOCKER_VERSION=${USER_DOCKER_VERSION} \
136-
USER_DOCKER_ENGINE_VERSION=${USER_DOCKER_ENGINE_VERSION} \
137132
AZURE_SERVICE=${AZURE_SERVICE} \
138133
PROXMOXVE_SERVICE=${PROXMOXVE_SERVICE} \
139134
SKIP_BUILD=${SKIP_BUILD}

cmd/control/console_init.go

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -290,10 +290,14 @@ $(tput sgr0)
290290
log.Error(err)
291291
}
292292

293-
// Check if user Docker has ever run in this installation yet and switch to latest version if not
293+
// Check if user Docker has ever run in this installation yet and switch to latest/user defined version if not
294294
if _, err := os.Stat("/var/lib/docker/engine-id"); os.IsNotExist(err) {
295-
log.Warn("User Docker does not exist, switching to latest version")
296-
cmd := exec.Command("/usr/bin/ros", "engine", "switch", "latest")
295+
dockerVersion := "latest"
296+
if cfg.Rancher.Docker.Engine != dockerVersion {
297+
dockerVersion = cfg.Rancher.Docker.Engine
298+
}
299+
log.Warn("User Docker does not exist, switching to " + dockerVersion)
300+
cmd := exec.Command("/usr/bin/ros", "engine", "switch", dockerVersion)
297301
cmd.Stdout = os.Stdout
298302
cmd.Stderr = os.Stderr
299303
if err := cmd.Run(); err != nil {

os-config.tpl.yml

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,8 @@ rancher:
77
REGISTRY_DOMAIN: "docker.io"
88
defaults:
99
hostname: {{.HOSTNAME_DEFAULT}}
10-
{{if eq "amd64" .ARCH -}}
11-
docker:
12-
engine: {{.USER_DOCKER_ENGINE_VERSION}}
13-
{{else -}}
1410
docker:
15-
engine: {{.USER_DOCKER_ENGINE_VERSION}}
16-
{{end -}}
11+
engine: latest
1712
network:
1813
dhcp_timeout: 10
1914
dns:
@@ -371,9 +366,9 @@ rancher:
371366
- system-volumes
372367
docker:
373368
{{if eq "amd64" .ARCH -}}
374-
image: {{.OS_REPO}}/os-docker:{{.USER_DOCKER_VERSION}}{{.SUFFIX}}
369+
image: {{.OS_REPO}}/os-docker:latest
375370
{{else -}}
376-
image: {{.OS_REPO}}/os-docker:{{.USER_DOCKER_VERSION}}{{.SUFFIX}}
371+
image: {{.OS_REPO}}/os-docker:latest
377372
{{end -}}
378373
command: ros user-docker
379374
environment:
@@ -414,11 +409,7 @@ rancher:
414409
image: {{.OS_REPO}}/os
415410
policy: download
416411
docker:
417-
{{if eq "amd64" .ARCH -}}
418-
engine: {{.USER_DOCKER_ENGINE_VERSION}}
419-
{{else -}}
420-
engine: {{.USER_DOCKER_ENGINE_VERSION}}
421-
{{end -}}
412+
engine: latest
422413
group: docker
423414
host: ["unix:///var/run/docker.sock"]
424415
log_opts:

0 commit comments

Comments
 (0)