macOS/darwin compilation fails due to MIN_STATIC_FEATURES assertions

[zachschuermann]

Our github actions macOS job is failing due to failing compile time assertions in ring:

error[E0080]: evaluation of constant value failed
  --> /Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/ring-0.17.14/src/cpu/arm/darwin.rs:44:5
   |
44 |     assert!((CAPS_STATIC & MIN_STATIC_FEATURES) == MIN_STATIC_FEATURES);
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ evaluation panicked: assertion failed: (CAPS_STATIC & MIN_STATIC_FEATURES) == MIN_STATIC_FEATURES

error[E0080]: evaluation of constant value failed
  --> /Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/ring-0.17.14/src/cpu/arm/darwin.rs:51:5
   |
51 |     assert!(CAPS_STATIC == MIN_STATIC_FEATURES);
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ evaluation panicked: assertion failed: CAPS_STATIC == MIN_STATIC_FEATURES

For more information about this error, try `rustc --explain E0080`.
error: could not compile `ring` (lib) due to 2 previous errors

Reference to those assertions just to make investigation easier:

// MSRV: Enforce 1.61.0 onaarch64-apple-*, in particular) prior to. Earlier
// versions of Rust before did not report the AAarch64 CPU features correctly
// for these targets. Cargo.toml specifies `rust-version` but versions before
// Rust 1.56 don't know about it.
#[allow(clippy::assertions_on_constants)]
const _AARCH64_APPLE_TARGETS_EXPECTED_FEATURES: () =
    assert!((CAPS_STATIC & MIN_STATIC_FEATURES) == MIN_STATIC_FEATURES);

// Ensure we don't accidentally allow features statically beyond
// `MIN_STATIC_FEATURES` so that dynamic detection is done uniformly for
// all of these targets.
#[allow(clippy::assertions_on_constants)]
const _AARCH64_APPLE_DARWIN_TARGETS_EXPECTED_FEATURES: () =
    assert!(CAPS_STATIC == MIN_STATIC_FEATURES);

Unfortunately i'm not really aware of the hardware github uses to run these - and was unable to repro locally on my M1 macbook pro. Let me know if there are any more useful details I can provide!

[justinkahrs]

I am having the same issues, but I'm not sure it's an issue with ring, I tested with [email protected] through [email protected] and saw the same error for each.

My guess is that the macos-latest runner was updated somehow and broke our builds, still investigating.

[briansmith]

[I've converted this from an issue into a discussion in the "Building" forum.]

See delta-io/delta-kernel-rs#959 (comment) and rust-lang/rust#133414. It seems like it you use RUSTFLAGS="-C target_cpu=native" then you will experience brittle behavior. I recommend that you avoid using "native" and instead use a specific CPU name.

[justinkahrs]

Wow thank you Brian, that was definitely it. I appreciate the quick reply!

[Esgrove]

I had the same build issue with GitHub macOS runner. Can confirm that adding this fixed the issue since I have rustflags = ["-C", "target-cpu=native"] in there:

- name: Remove cargo config
  run: rm -f .cargo/config.toml