Skip to content

Conversation

@Sneagan
Copy link
Collaborator

@Sneagan Sneagan commented Dec 5, 2025

  1. Remove unused and confusing constant.
  2. Start each processing phase with a clean slate by deleting the file state

@Sneagan Sneagan requested a review from mrose17 December 5, 2025 02:38
mrose17
mrose17 previously approved these changes Dec 5, 2025
Copy link
Collaborator

@mrose17 mrose17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! The POSSIBLE_ASSETS variable was OBE over a year ago, so it's just clutter. More importantly, getting rid of now empty files should address the problem we saw earlier.

Copy link
Collaborator

@mrose17 mrose17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good test additions!

@Sneagan Sneagan merged commit 65a3bab into main Dec 5, 2025
13 checks passed
@Sneagan Sneagan deleted the fix/address-removal branch December 5, 2025 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants