Satisfy linter

Author: Sneagan

generate-address-list.py

@@ -10,8 +10,8 @@
 
 FEATURE_TYPE_TEXT = "Digital Currency Address - "
 NAMESPACE = {
-    'sdn': 'https://sanctionslistservice.ofac.treas.gov/api/PublicationPreview/exports/'
-    'ADVANCED_XML'
+    "sdn": "https://sanctionslistservice.ofac.treas.gov/api/PublicationPreview/exports/"
+    "ADVANCED_XML"
 }
 
 # List of implemented output formats
@@ -22,41 +22,42 @@
 
 def parse_arguments():
     parser = argparse.ArgumentParser(
-        description='Tool to extract sanctioned digital currency addresses from the '
-        'OFAC special designated nationals XML file (sdn_advanced.xml)')
+        description="Tool to extract sanctioned digital currency addresses from the "
+        "OFAC special designated nationals XML file (sdn_advanced.xml)"
+    )
     parser.add_argument(
-        'assets',
-        nargs='*',
+        "assets",
+        nargs="*",
         default=[],
-        help='the asset for which the sanctioned addresses should be extracted '
-        '(default: XBT (Bitcoin))'
+        help="the asset for which the sanctioned addresses should be extracted "
+        "(default: XBT (Bitcoin))",
     )
     parser.add_argument(
-        '-sdn',
-        '--special-designated-nationals-list',
-        dest='sdn',
-        type=argparse.FileType('rb'),
-        help='the path to the sdn_advanced.xml file (can be downloaded from '
-        'https://www.treasury.gov/ofac/downloads/sanctions/1.0/sdn_advanced.xml)',
-        default=SDN_ADVANCED_FILE_PATH
+        "-sdn",
+        "--special-designated-nationals-list",
+        dest="sdn",
+        type=argparse.FileType("rb"),
+        help="the path to the sdn_advanced.xml file (can be downloaded from "
+        "https://www.treasury.gov/ofac/downloads/sanctions/1.0/sdn_advanced.xml)",
+        default=SDN_ADVANCED_FILE_PATH,
     )
     parser.add_argument(
-        '-f',
-        '--output-format',
-        dest='format',
-        nargs='*',
+        "-f",
+        "--output-format",
+        dest="format",
+        nargs="*",
         choices=OUTPUT_FORMATS,
         default=OUTPUT_FORMATS[0],
-        help='the output file format of the address list (default: TXT)'
+        help="the output file format of the address list (default: TXT)",
     )
     parser.add_argument(
-        '-path',
-        '--output-path',
-        dest='outpath',
+        "-path",
+        "--output-path",
+        dest="outpath",
         type=pathlib.Path,
         default=pathlib.Path("./"),
-        help='the path where the lists should be written to (default: current working '
-        'directory ("./")'
+        help="the path where the lists should be written to (default: current working "
+        'directory ("./")',
     )
     return parser.parse_args()
 
@@ -72,12 +73,11 @@ def get_possible_assets(root):
     """
     assets = []
     feature_types = root.findall(
-        'sdn:ReferenceValueSets/sdn:FeatureTypeValues/sdn:FeatureType',
-        NAMESPACE
+        "sdn:ReferenceValueSets/sdn:FeatureTypeValues/sdn:FeatureType", NAMESPACE
     )
     for feature_type in feature_types:
-        if feature_type.text.startswith('Digital Currency Address - '):
-            asset = feature_type.text.replace('Digital Currency Address - ', '')
+        if feature_type.text.startswith("Digital Currency Address - "):
+            asset = feature_type.text.replace("Digital Currency Address - ", "")
             assets.append(asset)
     return assets
 
@@ -87,7 +87,7 @@ def get_address_id(root, asset):
     feature_type = root.find(
         f"sdn:ReferenceValueSets/sdn:FeatureTypeValues"
         f"/*[.='{feature_type_text(asset)}']",
-        NAMESPACE
+        NAMESPACE,
     )
     if feature_type is None:
         raise LookupError(
@@ -99,10 +99,9 @@ def get_address_id(root, asset):
 
 def get_sanctioned_addresses(root, address_id):
     """returns a list of sanctioned addresses for the given address_id"""
-    addresses = list()
+    addresses = []
     for feature in root.findall(
-        f"sdn:DistinctParties//*[@FeatureTypeID='{address_id}']",
-        NAMESPACE
+        f"sdn:DistinctParties//*[@FeatureTypeID='{address_id}']", NAMESPACE
     ):
         for version_detail in feature.findall(".//sdn:VersionDetail", NAMESPACE):
             addresses.append(version_detail.text)
@@ -117,13 +116,13 @@ def write_addresses(addresses, asset, output_formats, outpath):
 
 
 def write_addresses_txt(addresses, asset, outpath):
-    with open(f"{outpath}/sanctioned_addresses_{asset}.txt", 'w') as out:
+    with open(f"{outpath}/sanctioned_addresses_{asset}.txt", "w") as out:
         for address in addresses:
             out.write(address + "\n")
 
 
 def write_addresses_json(addresses, asset, outpath):
-    with open(f"{outpath}/sanctioned_addresses_{asset}.json", 'w') as out:
+    with open(f"{outpath}/sanctioned_addresses_{asset}.json", "w") as out:
         out.write(json.dumps(addresses, indent=2) + "\n")
 
 
@@ -157,7 +156,7 @@ def main():
     tree = ET.parse(args.sdn)
     root = tree.getroot()
 
-    assets = list()
+    assets = []
     if isinstance(args.format, str):
         assets.append(args.assets)
     else:
@@ -166,7 +165,7 @@ def main():
     if len(assets) == 0:
         assets = get_possible_assets(root)
 
-    output_formats = list()
+    output_formats = []
     if isinstance(args.format, str):
         output_formats.append(args.format)
     else:

ofac_scraper.py

@@ -6,7 +6,7 @@
 from selenium.webdriver.chrome.service import Service
 from selenium.webdriver.common.action_chains import ActionChains
 from selenium.webdriver.common.by import By
-from selenium.webdriver.support import expected_conditions as EC
+from selenium.webdriver.support import expected_conditions as ec
 from selenium.webdriver.support.ui import WebDriverWait
 
 
@@ -28,20 +28,20 @@ def open_website(self, url):
 
     def wait_for_element(self, by, value, timeout=30):
         return WebDriverWait(self.driver, timeout).until(
-            EC.presence_of_element_located((by, value))
+            ec.presence_of_element_located((by, value))
         )
 
     def get_element_text(self, by, value):
         return self.driver.find_element(by, value).text
 
     def get_sha256_checksum(self):
-        MAX_RETRIES = 10
-        RETRY_DELAY = 10  # seconds to wait before retrying
+        max_retries = 10
+        retry_delay = 10
 
-        for attempt in range(MAX_RETRIES):
+        for attempt in range(max_retries):
             print(
                 f"Attempting to get SHA-256 checksum (attempt"
-                f" {attempt + 1}/{MAX_RETRIES})..."
+                f" {attempt + 1}/{max_retries})..."
             )
             try:
                 self.open_website("https://sanctionslist.ofac.treas.gov/Home/SdnList")
@@ -54,8 +54,7 @@ def get_sha256_checksum(self):
                 # Scroll to (waiting for animation) and Click the 'File
                 # Signatures' button with the known ID
                 header_element = self.driver.find_element(
-                    By.ID,
-                    "accordion__heading-:r1:"
+                    By.ID, "accordion__heading-:r1:"
                 )
                 ActionChains(self.driver).move_to_element(header_element).perform()
                 time.sleep(1)
@@ -79,16 +78,16 @@ def get_sha256_checksum(self):
                 sha256_checksum = checksums_content.split("SHA-256: ")[1].split("\n")[0]
                 return sha256_checksum
 
-            except TimeoutException:
+            except TimeoutException as e:
                 print(
-                    f"Timeout occurred on attempt {attempt + 1}/{MAX_RETRIES}. "
-                    f"Retrying in {RETRY_DELAY} seconds..."
+                    f"Timeout occurred on attempt {attempt + 1}/{max_retries}. "
+                    f"Retrying in {retry_delay} seconds..."
                 )
-                time.sleep(RETRY_DELAY)
-                if attempt == MAX_RETRIES - 1:
+                time.sleep(retry_delay)
+                if attempt == max_retries - 1:
                     raise TimeoutException(
                         "Max retries reached. The website is not responding."
-                    )
+                    ) from e
 
     def close(self):
         self.driver.quit()