Fix metrics registration failure after panic #830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sneagan
added a commit
that referenced
this pull request
Sep 19, 2025
* Remove bat-go dialer * Fix dependency naming * Make log level configurable * Add Integration Tests (#816) * Add Integration Tests - Kafka token issuance - Kafka token redemption - V1 HTTP Issuer GET endpoint - V1 HTTP Token Redemption POST endpoint - V3 HTTP Token Redemption POST endpoint This checks the entire token redemption flow for all known production use cases as well as checks that duplicate redemtion fails. There are some cases with time limited issuers where a token is issued for a future issuer whose redemption fails. These tokens are tested and verified to fail as expected. * Tidy * Correct test name * Correct README * Rename integration test file * Address simple PR feedback * Remove unneeded type * Integration testing pr feedback (#827) Address PR comments regarding testing structure. * Enable specifying an integration test * Address feedback * Adjust import order * Alter error handling for dynamo change * Add suggested change * Remove dependency (#819) * Add MSK TLS v1.2 to Kafka dialer (#826) Co-authored-by: Jackson <[email protected]> * Fix prod branch naming (#829) * Fix metrics registration failure after panic (#830) --------- Co-authored-by: Harold Spencer Jr. <[email protected]>
Sneagan
added a commit
that referenced
this pull request
Sep 19, 2025
* Release Simple Dependency Removal (#828) * Remove bat-go dialer * Fix dependency naming * Make log level configurable * Add Integration Tests (#816) * Add Integration Tests - Kafka token issuance - Kafka token redemption - V1 HTTP Issuer GET endpoint - V1 HTTP Token Redemption POST endpoint - V3 HTTP Token Redemption POST endpoint This checks the entire token redemption flow for all known production use cases as well as checks that duplicate redemtion fails. There are some cases with time limited issuers where a token is issued for a future issuer whose redemption fails. These tokens are tested and verified to fail as expected. * Tidy * Correct test name * Correct README * Rename integration test file * Address simple PR feedback * Remove unneeded type * Integration testing pr feedback (#827) Address PR comments regarding testing structure. * Enable specifying an integration test * Address feedback * Adjust import order * Alter error handling for dynamo change * Add suggested change * Remove dependency (#819) * Add MSK TLS v1.2 to Kafka dialer (#826) Co-authored-by: Jackson <[email protected]> * Fix prod branch naming (#829) --------- Co-authored-by: Harold Spencer Jr. <[email protected]> * Release 2025-09-19 (#834) * Remove bat-go dialer * Fix dependency naming * Make log level configurable * Add Integration Tests (#816) * Add Integration Tests - Kafka token issuance - Kafka token redemption - V1 HTTP Issuer GET endpoint - V1 HTTP Token Redemption POST endpoint - V3 HTTP Token Redemption POST endpoint This checks the entire token redemption flow for all known production use cases as well as checks that duplicate redemtion fails. There are some cases with time limited issuers where a token is issued for a future issuer whose redemption fails. These tokens are tested and verified to fail as expected. * Tidy * Correct test name * Correct README * Rename integration test file * Address simple PR feedback * Remove unneeded type * Integration testing pr feedback (#827) Address PR comments regarding testing structure. * Enable specifying an integration test * Address feedback * Adjust import order * Alter error handling for dynamo change * Add suggested change * Remove dependency (#819) * Add MSK TLS v1.2 to Kafka dialer (#826) Co-authored-by: Jackson <[email protected]> * Fix prod branch naming (#829) * Fix metrics registration failure after panic (#830) --------- Co-authored-by: Harold Spencer Jr. <[email protected]> --------- Co-authored-by: husobee <[email protected]> Co-authored-by: eV <[email protected]> Co-authored-by: Ian Krieger <[email protected]> Co-authored-by: Harold Spencer Jr. <[email protected]>
Sneagan
added a commit
that referenced
this pull request
Sep 19, 2025
* Release Simple Dependency Removal (#828) * Remove bat-go dialer * Fix dependency naming * Make log level configurable * Add Integration Tests (#816) * Add Integration Tests - Kafka token issuance - Kafka token redemption - V1 HTTP Issuer GET endpoint - V1 HTTP Token Redemption POST endpoint - V3 HTTP Token Redemption POST endpoint This checks the entire token redemption flow for all known production use cases as well as checks that duplicate redemtion fails. There are some cases with time limited issuers where a token is issued for a future issuer whose redemption fails. These tokens are tested and verified to fail as expected. * Tidy * Correct test name * Correct README * Rename integration test file * Address simple PR feedback * Remove unneeded type * Integration testing pr feedback (#827) Address PR comments regarding testing structure. * Enable specifying an integration test * Address feedback * Adjust import order * Alter error handling for dynamo change * Add suggested change * Remove dependency (#819) * Add MSK TLS v1.2 to Kafka dialer (#826) * Fix prod branch naming (#829) --------- * Release 2025-09-19 (#834) * Remove bat-go dialer * Fix dependency naming * Make log level configurable * Add Integration Tests (#816) * Add Integration Tests - Kafka token issuance - Kafka token redemption - V1 HTTP Issuer GET endpoint - V1 HTTP Token Redemption POST endpoint - V3 HTTP Token Redemption POST endpoint This checks the entire token redemption flow for all known production use cases as well as checks that duplicate redemtion fails. There are some cases with time limited issuers where a token is issued for a future issuer whose redemption fails. These tokens are tested and verified to fail as expected. * Tidy * Correct test name * Correct README * Rename integration test file * Address simple PR feedback * Remove unneeded type * Integration testing pr feedback (#827) Address PR comments regarding testing structure. * Enable specifying an integration test * Address feedback * Adjust import order * Alter error handling for dynamo change * Add suggested change * Remove dependency (#819) * Add MSK TLS v1.2 to Kafka dialer (#826) * Fix prod branch naming (#829) * Fix metrics registration failure after panic (#830) --------- --------- Co-authored-by: husobee <[email protected]> Co-authored-by: eV <[email protected]> Co-authored-by: Ian Krieger <[email protected]> Co-authored-by: Harold Spencer Jr. <[email protected]>
Sneagan
added a commit
that referenced
this pull request
Sep 19, 2025
* Align Prod and Master (#836) * Release Simple Dependency Removal (#828) * Remove bat-go dialer * Fix dependency naming * Make log level configurable * Add Integration Tests (#816) * Add Integration Tests - Kafka token issuance - Kafka token redemption - V1 HTTP Issuer GET endpoint - V1 HTTP Token Redemption POST endpoint - V3 HTTP Token Redemption POST endpoint This checks the entire token redemption flow for all known production use cases as well as checks that duplicate redemtion fails. There are some cases with time limited issuers where a token is issued for a future issuer whose redemption fails. These tokens are tested and verified to fail as expected. * Tidy * Correct test name * Correct README * Rename integration test file * Address simple PR feedback * Remove unneeded type * Integration testing pr feedback (#827) Address PR comments regarding testing structure. * Enable specifying an integration test * Address feedback * Adjust import order * Alter error handling for dynamo change * Add suggested change * Remove dependency (#819) * Add MSK TLS v1.2 to Kafka dialer (#826) Co-authored-by: Jackson <[email protected]> * Fix prod branch naming (#829) --------- Co-authored-by: Harold Spencer Jr. <[email protected]> * Release 2025-09-19 (#834) * Remove bat-go dialer * Fix dependency naming * Make log level configurable * Add Integration Tests (#816) * Add Integration Tests - Kafka token issuance - Kafka token redemption - V1 HTTP Issuer GET endpoint - V1 HTTP Token Redemption POST endpoint - V3 HTTP Token Redemption POST endpoint This checks the entire token redemption flow for all known production use cases as well as checks that duplicate redemtion fails. There are some cases with time limited issuers where a token is issued for a future issuer whose redemption fails. These tokens are tested and verified to fail as expected. * Tidy * Correct test name * Correct README * Rename integration test file * Address simple PR feedback * Remove unneeded type * Integration testing pr feedback (#827) Address PR comments regarding testing structure. * Enable specifying an integration test * Address feedback * Adjust import order * Alter error handling for dynamo change * Add suggested change * Remove dependency (#819) * Add MSK TLS v1.2 to Kafka dialer (#826) Co-authored-by: Jackson <[email protected]> * Fix prod branch naming (#829) * Fix metrics registration failure after panic (#830) --------- Co-authored-by: Harold Spencer Jr. <[email protected]> --------- Co-authored-by: husobee <[email protected]> Co-authored-by: eV <[email protected]> Co-authored-by: Ian Krieger <[email protected]> Co-authored-by: Harold Spencer Jr. <[email protected]> * Remove extra UUID package from dependencies (#821) --------- Co-authored-by: husobee <[email protected]> Co-authored-by: eV <[email protected]> Co-authored-by: Ian Krieger <[email protected]> Co-authored-by: Harold Spencer Jr. <[email protected]>
Sneagan
added a commit
that referenced
this pull request
Sep 19, 2025
* Fix metrics registration failure after panic (#830) * Align Prod and Master (#836) * Release Simple Dependency Removal (#828) * Remove bat-go dialer * Fix dependency naming * Make log level configurable * Add Integration Tests (#816) * Add Integration Tests - Kafka token issuance - Kafka token redemption - V1 HTTP Issuer GET endpoint - V1 HTTP Token Redemption POST endpoint - V3 HTTP Token Redemption POST endpoint This checks the entire token redemption flow for all known production use cases as well as checks that duplicate redemtion fails. There are some cases with time limited issuers where a token is issued for a future issuer whose redemption fails. These tokens are tested and verified to fail as expected. * Tidy * Correct test name * Correct README * Rename integration test file * Address simple PR feedback * Remove unneeded type * Integration testing pr feedback (#827) Address PR comments regarding testing structure. * Enable specifying an integration test * Address feedback * Adjust import order * Alter error handling for dynamo change * Add suggested change * Remove dependency (#819) * Add MSK TLS v1.2 to Kafka dialer (#826) Co-authored-by: Jackson <[email protected]> * Fix prod branch naming (#829) --------- Co-authored-by: Harold Spencer Jr. <[email protected]> * Release 2025-09-19 (#834) * Remove bat-go dialer * Fix dependency naming * Make log level configurable * Add Integration Tests (#816) * Add Integration Tests - Kafka token issuance - Kafka token redemption - V1 HTTP Issuer GET endpoint - V1 HTTP Token Redemption POST endpoint - V3 HTTP Token Redemption POST endpoint This checks the entire token redemption flow for all known production use cases as well as checks that duplicate redemtion fails. There are some cases with time limited issuers where a token is issued for a future issuer whose redemption fails. These tokens are tested and verified to fail as expected. * Tidy * Correct test name * Correct README * Rename integration test file * Address simple PR feedback * Remove unneeded type * Integration testing pr feedback (#827) Address PR comments regarding testing structure. * Enable specifying an integration test * Address feedback * Adjust import order * Alter error handling for dynamo change * Add suggested change * Remove dependency (#819) * Add MSK TLS v1.2 to Kafka dialer (#826) Co-authored-by: Jackson <[email protected]> * Fix prod branch naming (#829) * Fix metrics registration failure after panic (#830) --------- Co-authored-by: Harold Spencer Jr. <[email protected]> --------- Co-authored-by: husobee <[email protected]> Co-authored-by: eV <[email protected]> Co-authored-by: Ian Krieger <[email protected]> Co-authored-by: Harold Spencer Jr. <[email protected]> * Remove extra UUID package from dependencies (#821) * Add alert implementation and simple test on init --------- Co-authored-by: husobee <[email protected]> Co-authored-by: eV <[email protected]> Co-authored-by: Ian Krieger <[email protected]> Co-authored-by: Harold Spencer Jr. <[email protected]>
Sneagan
added a commit
that referenced
this pull request
Sep 25, 2025
* Fix metrics registration failure after panic (#830) * Align Prod and Master (#836) * Release Simple Dependency Removal (#828) * Remove bat-go dialer * Fix dependency naming * Make log level configurable * Add Integration Tests (#816) * Add Integration Tests - Kafka token issuance - Kafka token redemption - V1 HTTP Issuer GET endpoint - V1 HTTP Token Redemption POST endpoint - V3 HTTP Token Redemption POST endpoint This checks the entire token redemption flow for all known production use cases as well as checks that duplicate redemtion fails. There are some cases with time limited issuers where a token is issued for a future issuer whose redemption fails. These tokens are tested and verified to fail as expected. * Tidy * Correct test name * Correct README * Rename integration test file * Address simple PR feedback * Remove unneeded type * Integration testing pr feedback (#827) Address PR comments regarding testing structure. * Enable specifying an integration test * Address feedback * Adjust import order * Alter error handling for dynamo change * Add suggested change * Remove dependency (#819) * Add MSK TLS v1.2 to Kafka dialer (#826) Co-authored-by: Jackson <[email protected]> * Fix prod branch naming (#829) --------- Co-authored-by: Harold Spencer Jr. <[email protected]> * Release 2025-09-19 (#834) * Remove bat-go dialer * Fix dependency naming * Make log level configurable * Add Integration Tests (#816) * Add Integration Tests - Kafka token issuance - Kafka token redemption - V1 HTTP Issuer GET endpoint - V1 HTTP Token Redemption POST endpoint - V3 HTTP Token Redemption POST endpoint This checks the entire token redemption flow for all known production use cases as well as checks that duplicate redemtion fails. There are some cases with time limited issuers where a token is issued for a future issuer whose redemption fails. These tokens are tested and verified to fail as expected. * Tidy * Correct test name * Correct README * Rename integration test file * Address simple PR feedback * Remove unneeded type * Integration testing pr feedback (#827) Address PR comments regarding testing structure. * Enable specifying an integration test * Address feedback * Adjust import order * Alter error handling for dynamo change * Add suggested change * Remove dependency (#819) * Add MSK TLS v1.2 to Kafka dialer (#826) Co-authored-by: Jackson <[email protected]> * Fix prod branch naming (#829) * Fix metrics registration failure after panic (#830) --------- Co-authored-by: Harold Spencer Jr. <[email protected]> --------- Co-authored-by: husobee <[email protected]> Co-authored-by: eV <[email protected]> Co-authored-by: Ian Krieger <[email protected]> Co-authored-by: Harold Spencer Jr. <[email protected]> * Remove extra UUID package from dependencies (#821) * Improve pool management (#840) * Improve pool management * Update comments and skip lint defer expectation in loop * Adjust error handling --------- Co-authored-by: husobee <[email protected]> Co-authored-by: eV <[email protected]> Co-authored-by: Ian Krieger <[email protected]> Co-authored-by: Harold Spencer Jr. <[email protected]>
Sneagan
added a commit
that referenced
this pull request
Sep 26, 2025
* Align Prod and Master (#836) * Release Simple Dependency Removal (#828) * Remove bat-go dialer * Fix dependency naming * Make log level configurable * Add Integration Tests (#816) * Add Integration Tests - Kafka token issuance - Kafka token redemption - V1 HTTP Issuer GET endpoint - V1 HTTP Token Redemption POST endpoint - V3 HTTP Token Redemption POST endpoint This checks the entire token redemption flow for all known production use cases as well as checks that duplicate redemtion fails. There are some cases with time limited issuers where a token is issued for a future issuer whose redemption fails. These tokens are tested and verified to fail as expected. * Tidy * Correct test name * Correct README * Rename integration test file * Address simple PR feedback * Remove unneeded type * Integration testing pr feedback (#827) Address PR comments regarding testing structure. * Enable specifying an integration test * Address feedback * Adjust import order * Alter error handling for dynamo change * Add suggested change * Remove dependency (#819) * Add MSK TLS v1.2 to Kafka dialer (#826) Co-authored-by: Jackson <[email protected]> * Fix prod branch naming (#829) --------- Co-authored-by: Harold Spencer Jr. <[email protected]> * Release 2025-09-19 (#834) * Remove bat-go dialer * Fix dependency naming * Make log level configurable * Add Integration Tests (#816) * Add Integration Tests - Kafka token issuance - Kafka token redemption - V1 HTTP Issuer GET endpoint - V1 HTTP Token Redemption POST endpoint - V3 HTTP Token Redemption POST endpoint This checks the entire token redemption flow for all known production use cases as well as checks that duplicate redemtion fails. There are some cases with time limited issuers where a token is issued for a future issuer whose redemption fails. These tokens are tested and verified to fail as expected. * Tidy * Correct test name * Correct README * Rename integration test file * Address simple PR feedback * Remove unneeded type * Integration testing pr feedback (#827) Address PR comments regarding testing structure. * Enable specifying an integration test * Address feedback * Adjust import order * Alter error handling for dynamo change * Add suggested change * Remove dependency (#819) * Add MSK TLS v1.2 to Kafka dialer (#826) Co-authored-by: Jackson <[email protected]> * Fix prod branch naming (#829) * Fix metrics registration failure after panic (#830) --------- Co-authored-by: Harold Spencer Jr. <[email protected]> --------- Co-authored-by: husobee <[email protected]> Co-authored-by: eV <[email protected]> Co-authored-by: Ian Krieger <[email protected]> Co-authored-by: Harold Spencer Jr. <[email protected]> * Remove extra UUID package from dependencies (#821) * Improve pool management (#840) * Improve pool management * Update comments and skip lint defer expectation in loop * Adjust error handling --------- Co-authored-by: husobee <[email protected]> Co-authored-by: eV <[email protected]> Co-authored-by: Ian Krieger <[email protected]> Co-authored-by: Harold Spencer Jr. <[email protected]>
Sneagan
added a commit
that referenced
this pull request
Oct 2, 2025
* Fix metrics registration failure after panic (#830) * Align Prod and Master (#836) * Release Simple Dependency Removal (#828) * Remove bat-go dialer * Fix dependency naming * Make log level configurable * Add Integration Tests (#816) * Add Integration Tests - Kafka token issuance - Kafka token redemption - V1 HTTP Issuer GET endpoint - V1 HTTP Token Redemption POST endpoint - V3 HTTP Token Redemption POST endpoint This checks the entire token redemption flow for all known production use cases as well as checks that duplicate redemtion fails. There are some cases with time limited issuers where a token is issued for a future issuer whose redemption fails. These tokens are tested and verified to fail as expected. * Tidy * Correct test name * Correct README * Rename integration test file * Address simple PR feedback * Remove unneeded type * Integration testing pr feedback (#827) Address PR comments regarding testing structure. * Enable specifying an integration test * Address feedback * Adjust import order * Alter error handling for dynamo change * Add suggested change * Remove dependency (#819) * Add MSK TLS v1.2 to Kafka dialer (#826) Co-authored-by: Jackson <[email protected]> * Fix prod branch naming (#829) --------- Co-authored-by: Harold Spencer Jr. <[email protected]> * Release 2025-09-19 (#834) * Remove bat-go dialer * Fix dependency naming * Make log level configurable * Add Integration Tests (#816) * Add Integration Tests - Kafka token issuance - Kafka token redemption - V1 HTTP Issuer GET endpoint - V1 HTTP Token Redemption POST endpoint - V3 HTTP Token Redemption POST endpoint This checks the entire token redemption flow for all known production use cases as well as checks that duplicate redemtion fails. There are some cases with time limited issuers where a token is issued for a future issuer whose redemption fails. These tokens are tested and verified to fail as expected. * Tidy * Correct test name * Correct README * Rename integration test file * Address simple PR feedback * Remove unneeded type * Integration testing pr feedback (#827) Address PR comments regarding testing structure. * Enable specifying an integration test * Address feedback * Adjust import order * Alter error handling for dynamo change * Add suggested change * Remove dependency (#819) * Add MSK TLS v1.2 to Kafka dialer (#826) Co-authored-by: Jackson <[email protected]> * Fix prod branch naming (#829) * Fix metrics registration failure after panic (#830) --------- Co-authored-by: Harold Spencer Jr. <[email protected]> --------- Co-authored-by: husobee <[email protected]> Co-authored-by: eV <[email protected]> Co-authored-by: Ian Krieger <[email protected]> Co-authored-by: Harold Spencer Jr. <[email protected]> * Remove extra UUID package from dependencies (#821) * Add alert implementation and simple test on init --------- Co-authored-by: husobee <[email protected]> Co-authored-by: eV <[email protected]> Co-authored-by: Ian Krieger <[email protected]> Co-authored-by: Harold Spencer Jr. <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We encountered an issue where the service encounters a Prometheus registration error if the service encounters and recovers from a panic. Theory at this time is that there is state cleanup or instance uniqueness on the Prometheus side that does not get cleaned up or regenerated by the time the instance recovers from the panic. To handle this error we check if the collector already exists and use the one that already exists if so.