💄 Declaration -> Modifier

Author: dannyfritz

docs/rules/member-access.md

@@ -1,6 +1,6 @@
-# Enforces visibility declaration on class properties and methods (method-access)
+# Enforces visibility modifier on class properties and methods (method-access)
 
-Leaving off visibility modifiers and making everything public can make
+Leaving off visibility modifier and making everything public can make
 your interface hard to use by others.
 If you make all internal pieces private or protected, your interface will
 be easier to use.
@@ -14,17 +14,17 @@ The following patterns are considered warnings:
 
 ```ts
 class Animal {
-  name: string // No visibility declaration
-  getName (): string {} // No visibility declaration
+  name: string // No visibility modifier
+  getName (): string {} // No visibility modifier
 }
 ```
 
 The following patterns are not warnings:
 
 ```ts
 class Animal {
-  private name: string // explicit visibility declaration
-  public getName (): string {} // explicit visibility declaration
+  private name: string // explicit visibility modifier
+  public getName (): string {} // explicit visibility modifier
 }
 ```
 

lib/rules/member-access.js

@@ -1,5 +1,5 @@
 /**
- * @fileoverview Enforces explicit visibility declarations for class members
+ * @fileoverview Enforces explicit visibility modifier for class members
  * @author Danny Fritz
  */
 "use strict";
@@ -11,7 +11,7 @@
 module.exports = {
     meta: {
         docs: {
-            description: "Enforces explicity visibility declarations for class members",
+            description: "Enforces explicity visibility modifiers for class members",
             category: "TypeScript"
         },
         schema: []
@@ -27,7 +27,7 @@ module.exports = {
         //----------------------------------------------------------------------
 
         /**
-         * Checks if a string starts with a visibility declaration.
+         * Checks if a string starts with a visibility modifier.
          * @param {string} nodeText The text representing a node.
          * @returns {boolean} true if it has a visibility decorator
          * @private
@@ -40,31 +40,31 @@ module.exports = {
         }
 
         /**
-         * Checks if a method declaration has visibility declarations.
+         * Checks if a method declaration has visibility modifier.
          * @param {ASTNode} methodDefinition The node representing a MethodDefinition.
          * @returns {void}
          * @private
          */
-        function checkMethodVisibilityDeclaration(methodDefinition) {
+        function checkMethodVisibilityModifier(methodDefinition) {
             if (!hasVisibilityDeclaration(sourceCode.getText(methodDefinition))) {
                 context.report({
                     node: methodDefinition,
-                    message: "Missing visibility declaration on method definition " + methodDefinition.key.name + "."
+                    message: "Missing visibility modifier on method definition " + methodDefinition.key.name + "."
                 });
             }
         }
 
         /**
-         * Checks if property declaration has visibility declarations.
+         * Checks if property has visibility modifiers.
          * @param {ASTNode} classProperty The node representing a ClassProperty.
          * @returns {void}
          * @private
          */
-        function checkPropertyVisibilityDeclaration(classProperty) {
+        function checkPropertyVisibilityModifier(classProperty) {
             if (!hasVisibilityDeclaration(sourceCode.getText(classProperty))) {
                 context.report({
                     node: classProperty,
-                    message: "Missing visibility declaration on class property " + classProperty.key.name + "."
+                    message: "Missing visibility modifier on class property " + classProperty.key.name + "."
                 });
             }
         }
@@ -73,8 +73,8 @@ module.exports = {
         // Public
         //----------------------------------------------------------------------
         return {
-            ClassProperty: checkPropertyVisibilityDeclaration,
-            MethodDefinition: checkMethodVisibilityDeclaration
+            ClassProperty: checkPropertyVisibilityModifier,
+            MethodDefinition: checkMethodVisibilityModifier
         };
     }
 };

tests/lib/rules/member-access.js

@@ -1,5 +1,5 @@
 /**
- * @fileoverview Enforces explicit visibility declarations for class members
+ * @fileoverview Enforces explicit visibility modifiers for class members
  * @author Danny Fritz
  */
 "use strict";
@@ -45,7 +45,7 @@ class Test {
           `,
             parser: "typescript-eslint-parser",
             errors: [{
-                message: "Missing visibility declaration on class property x.",
+                message: "Missing visibility modifier on class property x.",
                 line: 3,
                 column: 3
             }]
@@ -61,7 +61,7 @@ class Test {
           `,
             parser: "typescript-eslint-parser",
             errors: [{
-                message: "Missing visibility declaration on method definition getX.",
+                message: "Missing visibility modifier on method definition getX.",
                 line: 4,
                 column: 3
             }]