Refactor changeBitrix24PartnerContactPerson method into linkBitrix24PartnerContactPerson and unlinkBitrix24PartnerContactPerson. Add corresponding unit tests and update CHANGELOG.

Signed-off-by: mesilov <[email protected]>

Author: mesilov

CHANGELOG.md

@@ -111,7 +111,10 @@
     - changed method `public function applicationUninstalled(?string $applicationToken): void` application token now is nullable
     - added method `linkContactPerson(Uuid $uuid)`
     - added method `unlinkContactPerson()`
+    - added method `linkBitrix24PartnerContactPerson()`
+    - added method `unlinkBitrix24PartnerContactPerson()`
     - remove method `changeContactPerson(?Uuid $uuid)`
+    - remove method `changeBitrix24PartnerContactPerson(?Uuid $uuid)`
 
 ### Statistics
 

src/Application/Contracts/ApplicationInstallations/Docs/ApplicationInstallations.md

@@ -17,7 +17,8 @@ Optional can store links to:
 | `linkContactPerson()`                  | `void`                          | Link client contact person                                                             |                            |
 | `unlinkContactPerson()`                | `void`                          | Unlink client contact person                                                           |                            |
 | `getBitrix24PartnerContactPersonId()`  | `?Uuid`                         | Returns Bitrix24 partner contact person id (optional)                                  |                            |
-| `changeBitrix24PartnerContactPerson()` | `void`                          | Changes Bitrix24 partner contact person                                                |                            |
+| `linkBitrix24PartnerContactPerson()`   | `void`                          | Link Bitrix24 partner contact person                                                   |                            |
+| `unlinkBitrix24PartnerContactPerson()` | `void`                          | Unlink Bitrix24 partner contact person                                                 |                            |
 | `getBitrix24PartnerId()`               | `?Uuid`                         | Returns Bitrix24 Partner id related to this installation (optional)                    |                            |
 | `changeBitrix24Partner()`              | `void`                          | Changes Bitrix24 partner                                                               |                            |
 | `getExternalId()`                      | `?string`                       | Returns external id for application installation                                       |                            |

src/Application/Contracts/ApplicationInstallations/Entity/ApplicationInstallationInterface.php

@@ -78,11 +78,18 @@ public function unlinkContactPerson(): void;
     public function getBitrix24PartnerContactPersonId(): ?Uuid;
 
     /**
-     * Change bitrix24 partner contact person
+     * Link Bitrix24 partner contact person
      *
-     * Change bitrix24 partner contact person if partner say he has new responsible for the application
+     * Link Bitrix24 partner contact person if partner say he has new responsible for the application
      */
-    public function changeBitrix24PartnerContactPerson(?Uuid $uuid): void;
+    public function linkBitrix24PartnerContactPerson(Uuid $uuid): void;
+
+    /**
+     * Unlink Bitrix24 partner contact person
+     *
+     * Unlink Bitrix24 partner contacts the person if the partner says they remove this employee
+     */
+    public function unlinkBitrix24PartnerContactPerson(): void;
 
     /**
      * @return Uuid|null get Bitrix24 Partner id related with this installation, optional

tests/Application/Contracts/ApplicationInstallations/Entity/ApplicationInstallationInterfaceTest.php

@@ -332,8 +332,8 @@ final public function testGetBitrix24PartnerContactPersonId(
 
     #[Test]
     #[DataProvider('applicationInstallationDataProvider')]
-    #[TestDox('test changeBitrix24PartnerContactPerson method')]
-    final public function testChangeBitrix24PartnerContactPerson(
+    #[TestDox('test linkBitrix24PartnerContactPerson method')]
+    final public function testLinkBitrix24PartnerContactPerson(
         Uuid $uuid,
         ApplicationInstallationStatus $applicationInstallationStatus,
         CarbonImmutable $createdAt,
@@ -363,11 +363,51 @@ final public function testChangeBitrix24PartnerContactPerson(
         );
 
         $newBitrix24PartnerContactPersonId = Uuid::v7();
-        $installation->changeBitrix24PartnerContactPerson($newBitrix24PartnerContactPersonId);
+        $installation->linkBitrix24PartnerContactPerson($newBitrix24PartnerContactPersonId);
         $this->assertEquals($newBitrix24PartnerContactPersonId, $installation->getBitrix24PartnerContactPersonId());
         $this->assertFalse($installation->getCreatedAt()->equalTo($installation->getUpdatedAt()));
     }
 
+    #[Test]
+    #[DataProvider('applicationInstallationDataProvider')]
+    #[TestDox('test unlinkBitrix24PartnerContactPerson method')]
+    final public function testUnlinkBitrix24PartnerContactPerson(
+        Uuid $uuid,
+        ApplicationInstallationStatus $applicationInstallationStatus,
+        CarbonImmutable $createdAt,
+        CarbonImmutable $updatedAt,
+        Uuid $bitrix24AccountUuid,
+        ApplicationStatus $applicationStatus,
+        PortalLicenseFamily $portalLicenseFamily,
+        ?int $portalUsersCount,
+        ?Uuid $clientContactPersonUuid,
+        ?Uuid $partnerContactPersonUuid,
+        ?Uuid $partnerUuid,
+        ?string $externalId
+    ): void {
+        $installation = $this->createApplicationInstallationImplementation(
+            $uuid,
+            $applicationInstallationStatus,
+            $createdAt,
+            $updatedAt,
+            $bitrix24AccountUuid,
+            $applicationStatus,
+            $portalLicenseFamily,
+            $portalUsersCount,
+            $clientContactPersonUuid,
+            $partnerContactPersonUuid,
+            $partnerUuid,
+            $externalId
+        );
+
+        $newBitrix24PartnerContactPersonId = Uuid::v7();
+        $installation->linkBitrix24PartnerContactPerson($newBitrix24PartnerContactPersonId);
+        $this->assertEquals($newBitrix24PartnerContactPersonId, $installation->getBitrix24PartnerContactPersonId());
+        $installation->unlinkBitrix24PartnerContactPerson();
+        $this->assertNull($installation->getBitrix24PartnerContactPersonId());
+        $this->assertFalse($installation->getCreatedAt()->equalTo($installation->getUpdatedAt()));
+    }
+
     #[Test]
     #[DataProvider('applicationInstallationDataProvider')]
     #[TestDox('test changeBitrix24Partner method')]

tests/Unit/Application/Contracts/ApplicationInstallations/Entity/ApplicationInstallationReferenceEntityImplementation.php

@@ -112,12 +112,18 @@ public function getBitrix24PartnerContactPersonId(): ?Uuid
         return $this->partnerContactPersonUuid;
     }
 
-    public function changeBitrix24PartnerContactPerson(?Uuid $uuid): void
+    public function linkBitrix24PartnerContactPerson(?Uuid $uuid): void
     {
         $this->partnerContactPersonUuid = $uuid;
         $this->updatedAt = new CarbonImmutable();
     }
 
+    public function unlinkBitrix24PartnerContactPerson(): void
+    {
+        $this->partnerContactPersonUuid = null;
+        $this->updatedAt = new CarbonImmutable();
+    }
+
     public function getBitrix24PartnerId(): ?Uuid
     {
         return $this->bitrix24PartnerUuid;