Rename findByMemberId method to findByBitrix24AccountMemberId in ApplicationInstallationRepositoryInterface and update implementations, tests, and CHANGELOG.

Signed-off-by: mesilov <[email protected]>

Author: mesilov

CHANGELOG.md

@@ -100,6 +100,8 @@
 ### Changed
 
 - Added optional argument in method `Bitrix24AccountRepositoryInterface::findByMemberId` [see details](https://github.com/bitrix24/b24phpsdk/issues/223)
+- Changed method name `ApplicationInstallationRepositoryInterface::findByMemberId` to
+  `ApplicationInstallationRepositoryInterface::findByBitrix24AccountMemberId` [see details](https://github.com/bitrix24/b24phpsdk/issues/226)
 
 ## 1.5.0 – 2025.08.01
 

src/Application/Contracts/ApplicationInstallations/Repository/ApplicationInstallationRepositoryInterface.php

@@ -42,11 +42,6 @@ public function getById(Uuid $uuid): ApplicationInstallationInterface;
      */
     public function delete(Uuid $uuid): void;
 
-    /**
-     * Find application installation by bitrix24 account id
-     **/
-    public function findByBitrix24AccountId(Uuid $uuid): ?ApplicationInstallationInterface;
-
     /**
      * Find application installation by external id
      *
@@ -57,16 +52,21 @@ public function findByBitrix24AccountId(Uuid $uuid): ?ApplicationInstallationInt
     public function findByExternalId(string $externalId): array;
 
     /**
-     * Find application installation by memberId
+     * Find application installation by application token
      *
-     * @param non-empty-string $memberId
+     * @param non-empty-string $applicationToken
      */
-    public function findByMemberId(string $memberId): ?ApplicationInstallationInterface;
+    public function findByApplicationToken(string $applicationToken): ?ApplicationInstallationInterface;
 
     /**
-     * Find application installation by application token
+     * Find application installation by related Bitrix24 account member_id
      *
-     * @param non-empty-string $applicationToken
+     * @param non-empty-string $memberId
      */
-    public function findByApplicationToken(string $applicationToken): ?ApplicationInstallationInterface;
+    public function findByBitrix24AccountMemberId(string $memberId): ?ApplicationInstallationInterface;
+
+    /**
+     * Find application installation by bitrix24 account id
+     **/
+    public function findByBitrix24AccountId(Uuid $uuid): ?ApplicationInstallationInterface;
 }

tests/Application/Contracts/ApplicationInstallations/Repository/ApplicationInstallationRepositoryInterfaceTest.php

@@ -434,7 +434,7 @@ final public function testFindByMemberId(
         $flusher->flush();
 
         $memberId = 'test-member-' . Uuid::v7()->toRfc4122();
-        $result = $appInstallationRepo->findByMemberId($memberId);
+        $result = $appInstallationRepo->findByBitrix24AccountMemberId($memberId);
         $this->assertTrue($result === null || $result instanceof ApplicationInstallationInterface);
     }
 
@@ -458,7 +458,7 @@ final public function testFindByMemberIdWithUnknownId(
         $appInstallationRepo = $this->createApplicationInstallationRepositoryImplementation();
 
         $memberId = 'unknown-member-' . Uuid::v7()->toRfc4122();
-        $this->assertNull($appInstallationRepo->findByMemberId($memberId));
+        $this->assertNull($appInstallationRepo->findByBitrix24AccountMemberId($memberId));
     }
 
     #[Test]
@@ -481,7 +481,7 @@ final public function testFindByMemberIdWithEmptyId(
         $appInstallationRepo = $this->createApplicationInstallationRepositoryImplementation();
 
         $this->expectException(InvalidArgumentException::class);
-        $appInstallationRepo->findByMemberId('');
+        $appInstallationRepo->findByBitrix24AccountMemberId('');
     }
 
     #[Test]

tests/Unit/Application/Contracts/ApplicationInstallations/Repository/InMemoryApplicationInstallationRepositoryImplementation.php

@@ -105,7 +105,7 @@ public function findByExternalId(string $externalId): array
     /**
      * @throws InvalidArgumentException
      */
-    public function findByMemberId(string $memberId): ?ApplicationInstallationInterface
+    public function findByBitrix24AccountMemberId(string $memberId): ?ApplicationInstallationInterface
     {
         $this->logger->debug('InMemoryApplicationInstallationRepositoryImplementation.findByMemberId', ['memberId' => $memberId]);