Skip to content

Commit 2c076d9

Browse files
committed
Merge #1711: tests: update Wycheproof
5433648 Fix typos and spellings (Adrien Ufferte) 9ea54c6 tests: update Wycheproof files (fanquake) Pull request description: ACKs for top commit: real-or-random: ACK 5433648 josibake: ACK 5433648 Tree-SHA512: abc39f898263da81b53da5223916f079878d31cca850384dd135ee555e7086ecfdbff1d329bf61438d188d76ad87dc610f119009ad91c0d2f8f3fdf99dc12e7a
2 parents b9313c6 + 5433648 commit 2c076d9

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed

src/ecmult_gen_impl.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ static void secp256k1_ecmult_gen(const secp256k1_ecmult_gen_context *ctx, secp25
213213
* but this would simply discard the bits that fall off at the bottom,
214214
* and thus, for example, bitdata could still have only two values if we
215215
* happen to shift by exactly 31 positions. We use a rotation instead,
216-
* which ensures that bitdata doesn't loose entropy. This relies on the
216+
* which ensures that bitdata doesn't lose entropy. This relies on the
217217
* rotation being atomic, i.e., the compiler emitting an actual rot
218218
* instruction. */
219219
uint32_t bitdata = secp256k1_rotr32(recoded[bit_pos >> 5], bit_pos & 0x1f);

src/tests.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3904,7 +3904,7 @@ static void test_ge(void) {
39043904
free(gej);
39053905
}
39063906

3907-
static void test_intialized_inf(void) {
3907+
static void test_initialized_inf(void) {
39083908
secp256k1_ge p;
39093909
secp256k1_gej pj, npj, infj1, infj2, infj3;
39103910
secp256k1_fe zinv;
@@ -4030,7 +4030,7 @@ static void run_ge(void) {
40304030
test_ge();
40314031
}
40324032
test_add_neg_y_diff_x();
4033-
test_intialized_inf();
4033+
test_initialized_inf();
40344034
test_ge_bytes();
40354035
}
40364036

src/wycheproof/WYCHEPROOF_COPYING

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
* The file `ecdsa_secp256k1_sha256_bitcoin_test.json` in this directory
22
comes from project Wycheproof with git commit
3-
`df4e933efef449fc88af0c06e028d425d84a9495`, see
4-
https://github.com/C2SP/wycheproof/blob/df4e933efef449fc88af0c06e028d425d84a9495/testvectors_v1/ecdsa_secp256k1_sha256_bitcoin_test.json
3+
`1f32ea7bb6cc5bd111cbd5507456b255dc8337c3`, see
4+
https://github.com/C2SP/wycheproof/blob/1f32ea7bb6cc5bd111cbd5507456b255dc8337c3/testvectors_v1/ecdsa_secp256k1_sha256_bitcoin_test.json
55

66
* The file `ecdh_secp256k1_test.json` in this directory
77
comes from project Wycheproof with git commit

src/wycheproof/ecdsa_secp256k1_sha256_bitcoin_test.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"numberOfTests" : 463,
66
"header" : [
77
"Test vectors of type EcdsaBitcoinVerify are meant for the verification",
8-
"of a ECDSA variant used for bitcoin, that add signature non-malleability."
8+
"of a ECDSA variant used for Bitcoin, that add signature non-malleability."
99
],
1010
"notes" : {
1111
"ArithmeticError" : {
@@ -47,7 +47,7 @@
4747
"InvalidSignature" : {
4848
"bugType" : "AUTH_BYPASS",
4949
"description" : "The signature contains special case values such as r=0 and s=0. Buggy implementations may accept such values, if the implementation does not check boundaries and computes s^(-1) == 0.",
50-
"effect" : "Accepting such signatures can have the effect that an adversary can forge signatures without even knowning the message to sign.",
50+
"effect" : "Accepting such signatures can have the effect that an adversary can forge signatures without even knowing the message to sign.",
5151
"cves" : [
5252
"CVE-2022-21449",
5353
"CVE-2021-43572",
@@ -57,7 +57,7 @@
5757
"InvalidTypesInSignature" : {
5858
"bugType" : "AUTH_BYPASS",
5959
"description" : "The signature contains invalid types. Dynamic typed languages sometime coerce such values of different types into integers. If an implementation is careless and has additional bugs, such as not checking integer boundaries then it may be possible that such signatures are accepted.",
60-
"effect" : "Accepting such signatures can have the effect that an adversary can forge signatures without even knowning the message to sign.",
60+
"effect" : "Accepting such signatures can have the effect that an adversary can forge signatures without even knowing the message to sign.",
6161
"cves" : [
6262
"CVE-2022-21449"
6363
]
@@ -95,8 +95,8 @@
9595
},
9696
"SignatureMalleabilityBitcoin" : {
9797
"bugType" : "SIGNATURE_MALLEABILITY",
98-
"description" : "\"BitCoins\"-curves are curves where signature malleability can be a serious issue. An implementation should only accept a signature s where s < n/2. If an implementation is not meant for uses cases that require signature malleability then this implementation should be tested with another set of test vectors.",
99-
"effect" : "In bitcoin exchanges, it may be used to make a double deposits or double withdrawals",
98+
"description" : "Signature malleability can be a serious issue in Bitcoin. An implementation should only accept a signature s where s < n/2. If an implementation is not meant for use cases that require signature malleability then this implementation should be tested with another set of test vectors.",
99+
"effect" : "In Bitcoin exchanges, it may be used to make a double deposits or double withdrawals",
100100
"links" : [
101101
"https://en.bitcoin.it/wiki/Transaction_malleability",
102102
"https://en.bitcoinwiki.org/wiki/Transaction_Malleability"

0 commit comments

Comments
 (0)