Add extra checks

Author: kyzia551

lib/adi-deploy

@@ -109,4 +109,6 @@ library Errors {
   string public constant ONLY_BY_PAYLOADS_MANAGER = '99'; // only payloads manager can call this function
   string public constant ONLY_BY_PAYLOADS_MANAGER_OR_GUARDIAN = '100'; // only payloads manager or guardian can call this function
   string public constant FUNCTION_NOT_SUPPORTED = '101'; // function not supported
+  string public constant FORBIDDEN_TO_SUBMIT_NON_EXISTENT_ROOTS = '102'; // forbidden to submit non existent account roots
+  string public constant FORBIDDEN_TO_SUBMIT_NON_EXISTENT_SLOTS = '103'; // forbidden to submit non existent storage slots
 }

src/contracts/libraries/Errors.sol

@@ -57,6 +57,8 @@ contract DataWarehouse is IDataWarehouse {
         accountStateProofRLP.toRlpItem().toList()
       );
 
+    require(accountData.exists, Errors.FORBIDDEN_TO_SUBMIT_NON_EXISTENT_ROOTS);
+
     _storageRoots[account][blockHash] = accountData.storageRoot;
 
     emit StorageRootProcessed(msg.sender, account, blockHash);
@@ -99,6 +101,7 @@ contract DataWarehouse is IDataWarehouse {
       slot,
       storageProof
     );
+    require(storageSlot.exists, Errors.FORBIDDEN_TO_SUBMIT_NON_EXISTENT_SLOTS);
 
     _slotsRegistered[account][blockHash][slot] = storageSlot.value;
 

src/contracts/voting/DataWarehouse.sol

@@ -155,6 +155,12 @@ library MerklePatriciaProofVerifier {
           } else {
             nodeHashHash = node[nibble].rlpBytesKeccak256();
           }
+
+          // sanity check
+          if (i == stack.length - 1) {
+            // need to process the child now
+            revert();
+          }
         } else {
           // we have consumed the entire mptKey, so we need to look at what's contained in this node.