Fix code inscpector violations

Fix code inscpector violations

Signed-off-by: Bensuperpc <[email protected]>

Author: bensuperpc

.github/workflows/code-inspector.yml

@@ -3,30 +3,30 @@ name: code-inspector
 on:
   push:
     branches:
-    - '*'
+      - '*'
     paths-ignore:
       - '**/README.md'
   pull_request:
     branches:
-    - '*'
+      - '*'
   workflow_dispatch:
 
 jobs:
   check-quality:
     runs-on: ubuntu-latest
     name: A job to check my code quality
     steps:
-    - name: Check code meets quality standards
-      id: code-inspector
-      uses: codeinspectorio/github-action@master
-      with:
-        repo_token: ${{ secrets.GITHUB_TOKEN }}
-        code_inspector_access_key: ${{ secrets.CODE_INSPECTOR_ACCESS_KEY }}
-        code_inspector_secret_key: ${{ secrets.CODE_INSPECTOR_SECRET_KEY }}
-        min_quality_grade: 'WARNING'
-        min_quality_score: '50'
-        max_defects_rate: '0.0001'
-        max_complex_functions_rate: '0.0001'
-        max_long_functions_rate: '0.0001'
-        project_name: ''
-        max_timeout_sec: '600' 
+      - name: Check code meets quality standards
+        id: code-inspector
+        uses: codeinspectorio/github-action@master
+        with:
+          repo_token: ${{ secrets.GITHUB_TOKEN }}
+          code_inspector_access_key: ${{ secrets.CODE_INSPECTOR_ACCESS_KEY }}
+          code_inspector_secret_key: ${{ secrets.CODE_INSPECTOR_SECRET_KEY }}
+          min_quality_grade: 'WARNING'
+          min_quality_score: '50'
+          max_defects_rate: '0.0001'
+          max_complex_functions_rate: '0.0001'
+          max_long_functions_rate: '0.0001'
+          project_name: ''
+          max_timeout_sec: '600' 

.github/workflows/main.yml

@@ -3,12 +3,12 @@ name: scripts
 on:
   push:
     branches:
-    - '*'
+      - '*'
     paths-ignore:
       - '**/README.md'
   pull_request:
     branches:
-    - '*'
+      - '*'
   schedule:
     - cron: '0 22 */7 * *'  # every 7 days https://crontab.guru/#0_7_*_*_1
   workflow_dispatch:

archive/extract.sh

@@ -25,39 +25,39 @@ set -euo pipefail
 extractAllTypeFiles(){ 
        if [ -f $1 ] ; then 
         case $1 in 
-           *.ark)       arc x $1            ;; 
-           *.arc)       arc x $1            ;; 
-           *.arj)       arj e $1            ;; 
+           *.ark)       arc x "$1"            ;; 
+           *.arc)       arc x "$1"            ;; 
+           *.arj)       arj e "$1"            ;; 
            *.cbt)       tar xvf $1          ;;
-           *.cso)       ciso 0 ./"$n" ./"$n.iso" && \
-                extract $n.iso && \rm -f $n ;;
-           *.tar.bz2)   tar xvjf $1         ;; 
-           *.tar.gz)    tar xvzf $1         ;; 
-           *.tar.lzma)  tar --lzma -xvf $1  ;; 
-           *.tar.xz)    tar -xf $1          ;; 
-           *.tar.lz)    lzip -d $1          ;; #tar --lzip -tf $1   ;;
-           *.tar.7z)    7z x -so $1 | tar -xf - ;; # tar -cJf
-           *.tar.Z)     zcat $1 | tar -xvf - ;; 
-           *.jar)       jar xf $1           ;; 
-           *.bz2)       bunzip2 $1          ;; 
-           *.rar)       unrar x $1          ;;
-           *.cbr)       unrar x -ad $1      ;;
-           *.gz)        gunzip $1           ;; 
-           *.cab)       cabextract $1       ;;
-           *.cpio)      cpio -id < $1       ;;
-           *.cba|*.ace) unace x $1          ;;
-           *.tar)       tar xvf $1          ;; 
-           *.tbz2)      tar xvjf $1         ;; 
-           *.tgz)       tar xvzf $1         ;; 
-           *.lz4)       lz4 -d $1           ;; 
-           *.lzh)       lha x $1            ;; 
-           *.xz)        unxz $1             ;;
-           *.exe)       cabextract $1       ;;
-           *.zip|*.epub|*.cbz)       unzip $1            ;; 
-           *.7z|*.z|*.apk|*.deb|*.dmg|*.lzh|*.msi|*.pkg|*.rpm|*.udf|*.wim|*.xar)        7z x $1             ;; 
-           *.zst)       zstd -dc $1         ;; 
-           *.zpaq)      zpaq x $1           ;;
-           *.zoo)       zoo -extract $1     ;; 
+           *.cso)       ciso 0 ./"$1" ./"$1.iso" && \
+                extract $1.iso && \rm -f "$1" ;;
+           *.tar.bz2)   tar xvjf "$1"         ;; 
+           *.tar.gz)    tar xvzf "$1"         ;; 
+           *.tar.lzma)  tar --lzma -xvf "$1"  ;; 
+           *.tar.xz)    tar -xf "$1"          ;; 
+           *.tar.lz)    lzip -d "$1"          ;; #tar --lzip -tf $1   ;;
+           *.tar.7z)    7z x -so "$1" | tar -xf - ;; # tar -cJf
+           *.tar.Z)     zcat "$1" | tar -xvf - ;; 
+           *.jar)       jar xf "$1"           ;; 
+           *.bz2)       bunzip2 "$1"          ;; 
+           *.rar)       unrar x "$1"          ;;
+           *.cbr)       unrar x -ad "$1"      ;;
+           *.gz)        gunzip "$1"           ;; 
+           *.cab)       cabextract "$1"       ;;
+           *.cpio)      cpio -id < "$1"       ;;
+           *.cba|*.ace) unace x "$1"          ;;
+           *.tar)       tar xvf "$1"          ;; 
+           *.tbz2)      tar xvjf "$1"         ;; 
+           *.tgz)       tar xvzf "$1"         ;; 
+           *.lz4)       lz4 -d "$1"           ;; 
+           *.lzh)       lha x "$1"            ;; 
+           *.xz)        unxz "$1"             ;;
+           *.exe)       cabextract "$1"       ;;
+           *.zip|*.epub|*.cbz)       unzip "$1"            ;; 
+           *.7z|*.z|*.apk|*.deb|*.dmg|*.lzh|*.msi|*.pkg|*.rpm|*.udf|*.wim|*.xar)        7z x "$1"             ;; 
+           *.zst)       zstd -dc "$1"         ;; 
+           *.zpaq)      zpaq x "$1"           ;;
+           *.zoo)       zoo -extract "$1"     ;; 
            *)           echo "File not supported : '$1'..." ;; 
         esac 
        else 

linux/hash/hash_gen.sh

@@ -30,5 +30,5 @@ fi
 #find $1 -type f -name "*" ! -name "checksums.*" | parallel -j $(nproc) ${TYPE}sum > checksums.${TYPE}
 
 TYPE=sha3-512
-find $1 -type f -name "*" ! -name "checksums.*" | parallel -j $(nproc) rhash --${TYPE} > checksums.${TYPE}
+find "$1" -type f -name "*" ! -name "checksums.*" | parallel -j $(nproc) rhash --${TYPE} > checksums.${TYPE}
 echo "OK"

linux/sysinfo.sh

@@ -33,8 +33,8 @@ else
 fi
 
 tmpdir="sysinfo-$(date +'%Y%m%d-%H%M%S-%Z')"
-mkdir $tmpdir || exit $?
-cd $tmpdir
+mkdir "$tmpdir" || exit $?
+cd "$tmpdir"
 
 #PATH=/usr/sbin:/usr/bin:/sbin:/bin
 
@@ -105,8 +105,8 @@ echo "Done"
 find -type f -empty -delete
 
 cd ..
-XZ_OPT=-e9 tar cJf "${tmpdir}.tar.xz" $tmpdir
-rm -rf $tmpdir
+XZ_OPT=-e9 tar cJf "${tmpdir}.tar.xz" "$tmpdir"
+rm -rf "$tmpdir"
 
 echo
 echo "System information archive has been created:"

partition/luks.sh

@@ -35,12 +35,12 @@ fi
 if (( $# == 2 )); then
     UUID=$(uuidgen)
     echo "UUID: ${UUID}"
-    sudo umount $1 || true
-    sudo cryptsetup -v --type luks --cipher aes-xts-plain64 --key-size 512 --hash sha512 --iter-time 1000 --use-urandom --verify-passphrase luksFormat --label=$2 $1
-    sudo cryptsetup -v luksOpen $1 ${UUID}
-    sudo mkfs.btrfs --force --checksum blake2 --label $2 /dev/mapper/${UUID}
+    sudo umount "$1" || true
+    sudo cryptsetup -v --type luks --cipher aes-xts-plain64 --key-size 512 --hash sha512 --iter-time 1000 --use-urandom --verify-passphrase luksFormat --label="$2" "$1"
+    sudo cryptsetup -v luksOpen "$1" "${UUID}"
+    sudo mkfs.btrfs --force --checksum blake2 --label "$2" /dev/mapper/${UUID}
 
-    sudo cryptsetup -v luksClose ${UUID}
+    sudo cryptsetup -v luksClose "${UUID}"
     echo "Partition: OK"
     echo "Now you can unplug, replug device and use it :) "
 else