Skip to content

Commit d2b3a15

Browse files
Test against php 8.4 (#1066)
* Test against php 8.4 * Test against php 8.4 * Parameter is implicitly nullable via default value null
1 parent 48c3ed8 commit d2b3a15

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

.github/workflows/run-static-analysis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
strategy:
2323
fail-fast: false
2424
matrix:
25-
php: [8.1, 8.2, 8.3]
25+
php: [8.1, 8.2, 8.3, 8.4]
2626
laravel: [9.*, 10.*, 11.*]
2727
dependency-version: [prefer-stable]
2828
exclude:

.github/workflows/run-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
strategy:
2323
fail-fast: false
2424
matrix:
25-
php: [8.1, 8.2, 8.3]
25+
php: [8.1, 8.2, 8.3, 8.4]
2626
laravel: ['9.*', '10.*', '11.*']
2727
dependency-version: [prefer-lowest, prefer-stable]
2828
exclude:

src/PDF.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ public function output(array $options = []): string
193193
/**
194194
* Save the PDF to a file
195195
*/
196-
public function save(string $filename, string $disk = null): self
196+
public function save(string $filename, ?string $disk = null): self
197197
{
198198
$disk = $disk ?: $this->config->get('dompdf.disk');
199199

0 commit comments

Comments
 (0)