Skip to content

Commit 7197b4f

Browse files
authored
feat(superchain): publish a bullseye image with node18 & python 3.9 (#4326)
This will become the new default for most use cases. --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
1 parent 68be5e1 commit 7197b4f

File tree

3 files changed

+10
-18
lines changed

3 files changed

+10
-18
lines changed

.github/workflows/docker-images.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,9 @@ jobs:
2323
matrix:
2424
debian:
2525
- 'buster' # 10
26+
- 'bullseye' # 11
2627
node: ['18', '20']
2728
include:
28-
- debian: 'bullseye' # 11
29-
node: '20'
3029
- debian: 'bookworm' #12
3130
node: '20'
3231
env:

CONTRIBUTING.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -228,13 +228,14 @@ The [Python](./packages/jsii-pacmak/lib/targets/python.ts) target is a good
228228
example to work from.
229229

230230
## Releasing
231+
231232
### The `public.ecr.aws/jsii/superchain` Docker image
232233

233-
Upon merging new changes to the `main` branch, the `public.ecr.aws/jsii/superchain:1-buster-slim-nightly`
234+
Upon merging new changes to the `main` branch, the `public.ecr.aws/jsii/superchain:1-bullseye-slim-nightly`
234235
image will be released after a last validation build.
235236

236237
Upon making a new `jsii` release (when the GitHub release entry - and its
237-
corresponding git tag - is created), the `public.ecr.aws/jsii/superchain:1-buster-slim` image will
238+
corresponding git tag - is created), the `public.ecr.aws/jsii/superchain:1-bullseye-slim` image will
238239
be released after a last validation build.
239240

240241
The latest release information (for both of the Docker image tags) can be seen

superchain/README.md

Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -38,16 +38,10 @@ public.ecr.aws/jsii/superchain:<JSII-MAJOR>-<BASE>(-node<NODE-MAJOR>)(-nightly)
3838

3939
The previous image tags have been discontinued:
4040

41-
- `:latest` (users should migrate to `:1-buster-slim`)
42-
- `:nightly` (users should migrate to `:1-buster-slim-nightly`)
43-
- `:node10` (users should migrate to `:1-buster-slim-node18`)
44-
- `:node10-nightly` (users should migrate to `:1-buster-slim-node18-nightly`)
45-
- `:node12` (users should migrate to `:1-buster-slim-node18`)
46-
- `:node12-nightly` (users shoudl migrate to `:1-buster-slim-node18-nightly`)
47-
- `:node14` (users should migrate to `:1-buster-slim-node18`)
48-
- `:node14-nightly` (users shoudl migrate to `:1-buster-slim-node18-nightly`)
49-
- `:node16` (users should migrate to `:1-buster-slim-node18`)
50-
- `:node16-nightly` (users shoudl migrate to `:1-buster-slim-node18-nightly`)
41+
- `:latest` (users should migrate to `:1-bullseye-slim`)
42+
- `:nightly` (users should migrate to `:1-bullseye-slim-nightly`)
43+
- `:nodeX` (users should migrate to an image using a supported node version)
44+
- `:nodeX-nightly` (users should migrate to a nightly image using a supported node version)
5145

5246
## Building
5347

@@ -68,10 +62,8 @@ jsii$ docker build . -f superchain/Dockerfile -t jsii/superchain:local --target=
6862

6963
We build multiple versions of this image, for different versions of Node. They are available as:
7064

71-
* `public.ecr.aws/jsii/superchain:1-buster-slim-node14(-nightly)`
72-
* `public.ecr.aws/jsii/superchain:1-buster-slim-node16(-nightly)`
73-
* `public.ecr.aws/jsii/superchain:1-buster-slim-node18(-nightly)`
74-
* `public.ecr.aws/jsii/superchain:1-buster-slim-node20(-nightly)`
65+
* `public.ecr.aws/jsii/superchain:1-bullseye-slim-node18(-nightly)`
66+
* `public.ecr.aws/jsii/superchain:1-bullseye-slim-node20(-nightly)`
7567

7668
If you are building this image from source, you can control the Node version with the
7769
`NODE_MAJOR_VERSION` build argument:

0 commit comments

Comments
 (0)