Merge pull request #1415 from SergeiPavlov/MemoizeAttribute

Optimization: Memoize `RequiredMemberAttribute` search

Author: tillig

src/Autofac/Core/Activators/Reflection/ReflectionActivator.cs

@@ -81,17 +81,20 @@ public void ConfigurePipeline(IComponentRegistryServices componentRegistryServic
 #if NET7_0_OR_GREATER
         // The RequiredMemberAttribute has Inherit = false on its AttributeUsage options,
         // so we can't use the expected GetCustomAttribute(inherit: true) option, and must walk the tree.
-        var currentType = _implementationType;
-        while (currentType is not null && !currentType.Equals(typeof(object)))
-        {
-            if (currentType.GetCustomAttribute<RequiredMemberAttribute>() is not null)
+        _anyRequiredMembers = ReflectionCacheSet.Shared.Internal.HasRequiredMemberAttribute.GetOrAdd(
+            _implementationType,
+            static t =>
             {
-                _anyRequiredMembers = true;
-                break;
-            }
+                for (var currentType = t; currentType is not null && currentType != typeof(object); currentType = currentType.BaseType)
+                {
+                    if (currentType.GetCustomAttribute<RequiredMemberAttribute>() is not null)
+                    {
+                        return true;
+                    }
+                }
 
-            currentType = currentType.BaseType;
-        }
+                return false;
+            });
 #else
         _anyRequiredMembers = false;
 #endif

src/Autofac/Core/InternalReflectionCaches.cs

@@ -59,6 +59,13 @@ internal class InternalReflectionCaches
     /// </summary>
     public ReflectionCacheDictionary<Type, Type> GenericTypeDefinitionByType { get; }
 
+#if NET7_0_OR_GREATER
+    /// <summary>
+    /// Gets a cache used by <see cref="ReflectionActivator"/>.
+    /// </summary>
+    public ReflectionCacheDictionary<Type, bool> HasRequiredMemberAttribute { get; }
+#endif
+
     /// <summary>
     /// Initializes a new instance of the <see cref="InternalReflectionCaches"/> class.
     /// </summary>
@@ -78,5 +85,8 @@ public InternalReflectionCaches(ReflectionCacheSet set)
         AutowiringInjectableProperties = set.GetOrCreateCache<ReflectionCacheDictionary<Type, IReadOnlyList<PropertyInfo>>>(nameof(AutowiringInjectableProperties));
         DefaultPublicConstructors = set.GetOrCreateCache<ReflectionCacheDictionary<Type, ConstructorInfo[]>>(nameof(DefaultPublicConstructors));
         GenericTypeDefinitionByType = set.GetOrCreateCache<ReflectionCacheDictionary<Type, Type>>(nameof(GenericTypeDefinitionByType));
+#if NET7_0_OR_GREATER
+        HasRequiredMemberAttribute = set.GetOrCreateCache<ReflectionCacheDictionary<Type, bool>>(nameof(HasRequiredMemberAttribute));
+#endif
     }
 }