Skip to content

Commit bc8cf24

Browse files
committed
Made the requested cleanups in semantic_router/index/pinecone.py
1 parent 1b8f234 commit bc8cf24

File tree

1 file changed

+13
-14
lines changed

1 file changed

+13
-14
lines changed

semantic_router/index/pinecone.py

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -958,14 +958,14 @@ def _read_config(self, field: str, scope: str | None = None) -> ConfigParameter:
958958
# Pinecone v7: FetchResponse with .vectors mapping id -> Vector
959959
if hasattr(config_record, "vectors") and config_id in config_record.vectors:
960960
vec = config_record.vectors[config_id]
961-
md = getattr(vec, "metadata", {}) or {}
962-
value = md.get("value", "")
963-
created_raw = md.get("created_at")
964-
created_at: str = (
965-
created_raw
966-
if isinstance(created_raw, str)
967-
else datetime.now(timezone.utc).isoformat()
968-
)
961+
metadata = getattr(vec, "metadata", {}) or {}
962+
value = metadata.get("value", "")
963+
created_raw = metadata.get("created_at")
964+
if not isinstance(created_raw, str):
965+
raise TypeError(
966+
f"Invalid created_at type: {type(created_raw)} for config {field}. Expected str."
967+
)
968+
created_at: str = created_raw
969969
return ConfigParameter(
970970
field=field,
971971
value=value,
@@ -1005,15 +1005,14 @@ async def _async_read_config(
10051005
if config_record:
10061006
try:
10071007
created_raw = config_record.get("created_at")
1008-
created_at: str = (
1009-
created_raw
1010-
if isinstance(created_raw, str)
1011-
else datetime.now(timezone.utc).isoformat()
1012-
)
1008+
if not isinstance(created_raw, str):
1009+
raise TypeError(
1010+
f"Invalid created_at type: {type(created_raw)} for config {field}. Expected str."
1011+
)
10131012
return ConfigParameter(
10141013
field=field,
10151014
value=config_record["value"],
1016-
created_at=created_at,
1015+
created_at=created_raw,
10171016
scope=scope,
10181017
)
10191018
except KeyError:

0 commit comments

Comments
 (0)