fix: inner Java classes weren't getting rendered (#110)

* Changed inner class logic, added logging filter. Fixes: #103

* Added check for objects with no properties.

* Removed unnecessary logIt filter, and unused code in java-class.

Author: MichaelDavisSolace

filters/all.js

@@ -304,6 +304,16 @@ function functionSpecs([asyncapi, params]) {
 }
 filter.functionSpecs = functionSpecs;
 
+// This returns the list of methods belonging to an object, just to help debugging.
+const getMethods = (obj) => {
+  const properties = new Set();
+  let currentObj = obj;
+  do {
+    Object.getOwnPropertyNames(currentObj).forEach(item => properties.add(item));
+  } while ((currentObj = Object.getPrototypeOf(currentObj)));
+  return [...properties.keys()].filter(item => typeof obj[item] === 'function');
+};
+
 function getRealPublisher([info, params, channel]) {
   const pub = scsLib.getRealPublisher(info, params, channel);
   return pub;
@@ -321,15 +331,13 @@ function groupId([info, params]) {
 }
 filter.groupId = groupId;
 
-// This returns the list of methods belonging to an object, just to help debugging.
-const getMethods = (obj) => {
-  const properties = new Set();
-  let currentObj = obj;
-  do {
-    Object.getOwnPropertyNames(currentObj).forEach(item => properties.add(item));
-  } while ((currentObj = Object.getPrototypeOf(currentObj)));
-  return [...properties.keys()].filter(item => typeof obj[item] === 'function');
-};
+function isEmpty(obj) {
+  if (!obj) {
+    return true;
+  }
+  return obj && Object.keys(obj).length === 0 && obj.constructor === Object;
+}
+filter.isEmpty = isEmpty;
 
 function logFull(obj) {
   console.log(obj);

partials/java-class

@@ -25,6 +25,8 @@
 {%- else -%} {# not an array at the top level. #}
 {%- set first = true -%}
 {#- Constructor with all properties -#}
+{%- set hasNoProperties = properties | isEmpty -%}
+{%- if not hasNoProperties -%}
 {{ indent2 }}public {{ className }} (
 {%- for name, prop in properties -%}
 {%- set javaName = name | identifierName -%}
@@ -43,6 +45,7 @@
 {% endfor -%}
 {{ indent2 }}}
 {% endif -%}
+{% endif -%}
 
 {# Members #}
 {% for name, prop in properties -%}
@@ -70,12 +73,9 @@
 {{ indent3 }}return this;
 {{ indent2 }}}
 {# Inner classes #}
-{%- if indentLevel == 0 and  prop.type() === 'object' %}
+{%- if prop.type() === 'object' %}
 {{ javaClass(javaName, null, prop.properties(), prop.required(), indentLevel+1, true) }}
 {% endif -%}
-{%- if indentLevel > 0 and prop.type === 'object' %}
-{{ javaClass(javaName, null, prop.properties, prop.required, indentLevel+1, true) }}
-{% endif -%}
 {%- if isArrayOfObjects %}
 {{ javaClass(javaName, null, prop.items().properties(), prop.items().required(), indentLevel+1, true) }}
 {% endif -%}