fix(mysql): Propagate tables and tableNames options to loader (#8665)

* fix(mysql): Propagate tables and tableNames options to loadGraphQLSchemaFromMySQL

- The `tables` and `tableNames` config options are defined in types and used inside `loadGraphQLSchemaFromMySQL` from `@omnigraph/mysql`, but they were not connected

* fix(mysql): Utilize tableFieldsConfig options

- The `handleTableName` already expects `tableFieldsConfig` to be passed. Hence, simply passing it down

* test(mysql): Add comprehensive tests for mysql schema loader

* test(mysql): Add basic test for legacy mysql handler

* chore(changeset): Add changeset for mysql loader fix

Author: angelsvirkov

.changeset/some-spoons-lead.md

@@ -0,0 +1,6 @@
+---
+'@graphql-mesh/mysql': patch
+'@omnigraph/mysql': patch
+---
+
+Fix tables and tableFields config options inside mysql handler and schema loader

packages/legacy/handlers/mysql/src/index.ts

@@ -64,6 +64,8 @@ export default class MySQLHandler implements MeshHandler {
       }
       return loadGraphQLSchemaFromMySQL(this.name, {
         endpoint: endpointUrl.toString(),
+        tables: this.config.tables,
+        tableFields: this.config.tableFields,
         ssl: {
           rejectUnauthorized: this.config.ssl?.rejectUnauthorized,
           caPath: this.config.ssl?.ca,

packages/legacy/handlers/mysql/test/handler.spec.ts

@@ -0,0 +1,72 @@
+import type { GraphQLSchema } from 'graphql';
+import InMemoryLRUCache from '@graphql-mesh/cache-inmemory-lru';
+import MySQLHandler from '@graphql-mesh/mysql';
+import { InMemoryStoreStorageAdapter, MeshStore } from '@graphql-mesh/store';
+import type { YamlConfig } from '@graphql-mesh/types';
+import { loadFromModuleExportExpression } from '@graphql-mesh/utils';
+import { loadGraphQLSchemaFromMySQL, type LoadGraphQLSchemaFromMySQLOpts } from '@omnigraph/mysql';
+
+jest.mock('@graphql-mesh/utils');
+jest.mock('@omnigraph/mysql');
+
+const noOpFunction: any = () => {};
+
+describe('mysql', () => {
+  let store: MeshStore;
+  using cache = new InMemoryLRUCache();
+  beforeEach(() => {
+    store = new MeshStore('.mesh', new InMemoryStoreStorageAdapter(), {
+      readonly: false,
+      validate: false,
+    });
+  });
+
+  it('correctly builds schema from loadGraphQLSchemaFromMySQL after passing configuration', async () => {
+    const graphQLSchemaMock: GraphQLSchema = {
+      description: 'someGraphQLSchemaMock',
+    } as any;
+
+    const configMock: YamlConfig.MySQLHandler = {
+      database: 'testdb',
+      tables: ['testTable'],
+      tableFields: [
+        {
+          table: 'testTable',
+          fields: ['testField'],
+        },
+      ],
+      ssl: {
+        rejectUnauthorized: true,
+        ca: 'someCA',
+      },
+    };
+
+    jest.mocked(loadGraphQLSchemaFromMySQL).mockResolvedValue(graphQLSchemaMock);
+
+    const handler = new MySQLHandler({
+      name: 'test',
+      config: configMock,
+      baseDir: __dirname,
+      cache,
+      pubsub: noOpFunction,
+      store,
+      importFn: noOpFunction,
+      logger: noOpFunction,
+    });
+
+    const expectedOptions: LoadGraphQLSchemaFromMySQLOpts = {
+      endpoint: 'mysqls://localhost:3306/testdb',
+      ssl: {
+        rejectUnauthorized: configMock.ssl!.rejectUnauthorized,
+        caPath: configMock.ssl!.ca,
+      },
+      tables: configMock.tables,
+      tableFields: configMock.tableFields,
+    };
+
+    const { schema } = await handler.getMeshSource();
+
+    expect(schema).toBe(graphQLSchemaMock);
+    expect(loadGraphQLSchemaFromMySQL).toHaveBeenCalledWith('test', expectedOptions);
+  });
+});

packages/loaders/mysql/src/schema.ts

@@ -36,6 +36,7 @@ export interface LoadGraphQLSchemaFromMySQLOpts {
   endpoint: string;
   ssl?: MySQLSSLOptions;
   tables?: string[];
+  tableFields?: TableFieldConfig[];
 }
 
 export async function loadGraphQLSchemaFromMySQL(
@@ -97,6 +98,7 @@ export async function loadGraphQLSchemaFromMySQL(
         subgraphName,
         tableName,
         tables,
+        tableFieldsConfig: opts.tableFields,
         schemaComposer,
         introspectionConnection,
         autoIncrementedColumns,