Skip to content

Commit b5c05c4

Browse files
committed
Fix unexpected breaking change in types
1 parent 5f013f2 commit b5c05c4

File tree

8 files changed

+25
-9
lines changed

8 files changed

+25
-9
lines changed

.changeset/slimy-ants-bathe.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@graphql-mesh/types': patch
3+
---
4+
5+
Export again accidentially removed RedisConfig
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
diff --git a/dist/directives.js b/dist/directives.js
2+
index bada42374b58093afec2d7290a82e1971bd8d85a..6ff572c1342cb501428614b89e518f1a3e9920de 100644
3+
--- a/dist/directives.js
4+
+++ b/dist/directives.js
5+
@@ -1,3 +1,4 @@
6+
"use strict";
7+
Object.defineProperty(exports, "__esModule", { value: true });
8+
-exports.DIRECTIVES = "\n directive @md on OBJECT\n directive @withAdditionalProperties on OBJECT\n";
9+
+exports.DIRECTIVES =
10+
+ "\n directive @md on OBJECT | UNION\n directive @withAdditionalProperties on OBJECT | UNION\n";

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@
6464
"typecheck": "yarn generate-config-schema && tsc -p tsconfig.json --noEmit"
6565
},
6666
"devDependencies": {
67-
"@ardatan/graphql-to-config-schema": "0.1.25",
67+
"@ardatan/graphql-to-config-schema": "patch:@ardatan/graphql-to-config-schema@npm%3A0.1.25#~/.yarn/patches/@ardatan-graphql-to-config-schema-npm-0.1.25-f8c48d384e.patch",
6868
"@babel/core": "7.26.8",
6969
"@babel/plugin-proposal-class-properties": "7.18.6",
7070
"@babel/plugin-proposal-explicit-resource-management": "7.25.9",

packages/cache/redis/yaml-config.graphql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ type Cache {
22
redis: RedisConfig
33
}
44

5-
union RedisConfig = RedisConfigSentinel | RedisConfigSingle
5+
union RedisConfig @md = RedisConfigSentinel | RedisConfigSingle
66

77
type RedisConfigSentinel @md {
88
"""

packages/legacy/types/src/config-schema.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,8 @@
132132
"family": {
133133
"type": "string"
134134
}
135-
}
135+
},
136+
"required": ["host", "port"]
136137
},
137138
"RedisConfigSingle": {
138139
"additionalProperties": false,

packages/legacy/types/src/config.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1858,8 +1858,8 @@ export interface RedisConfigSentinel {
18581858
lazyConnect?: boolean;
18591859
}
18601860
export interface RedisSentinelConfig {
1861-
host?: string;
1862-
port?: string;
1861+
host: string;
1862+
port: string;
18631863
family?: string;
18641864
}
18651865
export interface RedisConfigSingle {

website/src/generated-markdown/RedisConfigSentinel.generated.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
* `name` (type: `String`, required) - identifies a group of Redis instances composed of a master and one or more slaves
33
* `sentinelPassword` (type: `String`) - (optional) password for Sentinel instances.
44
* `sentinels` (type: `Array of Object`, required) - A list of sentinels to connect to. The list does not need to enumerate all your sentinel instances, but a few so that if one is down the client will try the next one.:
5-
* `host` (type: `String`)
6-
* `port` (type: `String`)
5+
* `host` (type: `String`, required)
6+
* `port` (type: `String`, required)
77
* `family` (type: `String`)
88
* `role` (type: `String (master | slave)`) - (optional) with a value of slave will return a random slave from the Sentinel group.
99
* `enableTLSForSentinelMode` (type: `Boolean`) - (optional) set to true if connecting to sentinel instances that are encrypted
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11

2-
* `host` (type: `String`)
3-
* `port` (type: `String`)
2+
* `host` (type: `String`, required)
3+
* `port` (type: `String`, required)
44
* `family` (type: `String`)

0 commit comments

Comments
 (0)