Allow Error to conform to itself #20629

rjmccall · 2018-11-16T06:49:16Z

Most of the foundation for this was laid in earlier patches.

This PR should not be merged because it arguably requires Evolution approval.

I was considered adding an -enable-error-self-conformance flag and merging this so that people could test it. Unfortunately, testing it would require the stdlib to be built under that flag, and doing that by default would change the ABI of the stdlib — and avoiding that ABI change is exactly why I can't merge this patch yet. So no dice.

PRs this depends on that aren't in the 5.0 branch: #20658, #20662

rjmccall · 2018-11-16T06:49:32Z

@swift-ci Please test.

DougGregor

Huh. This is a not nearly as complicated as I would have thought

DougGregor · 2018-11-16T06:54:43Z

lib/SILGen/SILGenPoly.cpp

You can use protocol->getProtocolSelfType() here, FWIW

DougGregor · 2018-11-16T07:01:34Z

test/Interpreter/error_self_conformance.swift

You'll need to update swift::_conformsToProtocol in the runtime, because it has a path that will need to know that an error existential conforms to the Error protocol. (Right now it only considers @objc existentials to conform to their protocols). You can exercise the code by evaluating a conditional conformance at runtime.

It actually Just Works, probably because I'm generating an ordinary conformance with a conformance descriptor whose conforming type is linked correctly back to the protocol (by a cavalcade of different PRs). But as discussed privately, I'll flesh out the tests for various cases of this.

slavapestov · 2018-11-16T07:03:46Z

test/Interpreter/error_self_conformance.swift

Any reason this is a JIT test and not a build a binary and run it test?

No, I'll fix that.

swift-ci · 2018-11-16T07:48:21Z

Build failed
Swift Test OS X Platform
Git Sha - c86f9579b3fc7779f02aa2ef7b824815b86d4f98

rjmccall · 2018-11-16T08:05:25Z

@swift-ci Please test.

rjmccall · 2018-11-16T08:05:40Z

@swift-ci Please test.

swift-ci · 2018-11-16T09:47:00Z

Build failed
Swift Test OS X Platform
Git Sha - f33dfffe77e69f0ec064fec9420472b624e71ca6

swift-ci · 2018-11-16T09:57:42Z

Build failed
Swift Test Linux Platform
Git Sha - f33dfffe77e69f0ec064fec9420472b624e71ca6

rjmccall · 2018-11-16T21:51:33Z

@swift-ci Please test.

swift-ci · 2018-11-16T21:52:04Z

Build failed
Swift Test OS X Platform
Git Sha - f33dfffe77e69f0ec064fec9420472b624e71ca6

swift-ci · 2018-11-16T21:53:36Z

Build failed
Swift Test Linux Platform
Git Sha - f33dfffe77e69f0ec064fec9420472b624e71ca6

rjmccall · 2018-11-16T22:57:58Z

@swift-ci Please test.

swift-ci · 2018-11-16T22:59:53Z

Build failed
Swift Test Linux Platform
Git Sha - 976e5be00628ee7d9f3a16bf03bd6fa98ad195e5

swift-ci · 2018-11-16T22:59:59Z

Build failed
Swift Test OS X Platform
Git Sha - 976e5be00628ee7d9f3a16bf03bd6fa98ad195e5

rjmccall · 2018-11-17T04:10:16Z

@swift-ci Please test.

rjmccall · 2018-11-17T04:10:27Z

@swift-ci Please test source compatibility.

swift-ci · 2018-11-17T04:10:52Z

Build failed
Swift Test OS X Platform
Git Sha - e6072f563ac79a64bf838045a3d4f5b41d72f9f4

swift-ci · 2018-11-17T04:12:18Z

Build failed
Swift Test Linux Platform
Git Sha - e6072f563ac79a64bf838045a3d4f5b41d72f9f4

rjmccall · 2018-11-17T06:40:15Z

That's a real bug caught by the compatibility suite, not just a source compatibility problem.

rjmccall · 2018-11-17T06:43:37Z

...oh, but I think it's actually caused by the change I made to ProtocolConformanceRef::subst.

rjmccall · 2018-11-17T07:20:22Z

@swift-ci Please test.

swift-ci · 2018-11-17T07:22:22Z

Build failed
Swift Test Linux Platform
Git Sha - c66ad971d0f63f7c4e225586230a61dec681969b

swift-ci · 2018-11-17T07:24:12Z

Build failed
Swift Test OS X Platform
Git Sha - c66ad971d0f63f7c4e225586230a61dec681969b

Test is in swiftlang#20629.

Most of the foundation for this was laid in earlier patches.

rjmccall · 2018-11-17T07:52:25Z

@swift-ci Please test.

swift-ci · 2018-11-17T07:54:27Z

Build failed
Swift Test Linux Platform
Git Sha - 3f6bdc2a8e82fe7c9dfafeee11f37212d1c86fec

swift-ci · 2018-11-17T07:56:31Z

Build failed
Swift Test OS X Platform
Git Sha - 3f6bdc2a8e82fe7c9dfafeee11f37212d1c86fec

rjmccall · 2018-11-17T08:52:00Z

@swift-ci Please test OS X

rjmccall · 2018-12-05T21:16:31Z

@swift-ci Please test.

Test is in swiftlang#20629.

rjmccall requested a review from DougGregor November 16, 2018 06:49

rjmccall changed the title ~~Allow Error to conform to itself~~ [DNM] Allow Error to conform to itself Nov 16, 2018

DougGregor approved these changes Nov 16, 2018

View reviewed changes

slavapestov reviewed Nov 16, 2018

View reviewed changes

rjmccall force-pushed the error-self-conformance branch from c86f957 to f33dfff Compare November 16, 2018 08:05

rjmccall force-pushed the error-self-conformance branch from f33dfff to 976e5be Compare November 16, 2018 21:51

rjmccall force-pushed the error-self-conformance branch from 976e5be to e6072f5 Compare November 16, 2018 22:57

rjmccall force-pushed the error-self-conformance branch from e6072f5 to c66ad97 Compare November 17, 2018 04:10

rjmccall mentioned this pull request Nov 17, 2018

Fix a bug with inlining self-conformances #20658

Merged

rjmccall force-pushed the error-self-conformance branch from c66ad97 to 3f6bdc2 Compare November 17, 2018 07:20

rjmccall added 2 commits November 17, 2018 02:49

Fix a source-compatibility bug in swiftlang#20658.

72e5fc2

Test is in swiftlang#20629.

Allow Error to conform to itself.

49ba9c5

Most of the foundation for this was laid in earlier patches.

rjmccall force-pushed the error-self-conformance branch from 3f6bdc2 to 49ba9c5 Compare November 17, 2018 07:52

rjmccall mentioned this pull request Nov 28, 2018

Revise SE-0235 with core team feedback and put it back in review swiftlang/swift-evolution#961

Merged

mpangburn mentioned this pull request Nov 30, 2018

Pumpmanager updates tidepool-org/LoopKit#1

Closed

jshier mentioned this pull request Dec 3, 2018

SE-0235: Add Result<Success, Failure: Error> to Standard Library #20958

Merged

rjmccall changed the title ~~[DNM] Allow Error to conform to itself~~ Allow Error to conform to itself Dec 5, 2018

rjmccall merged commit 8112f68 into swiftlang:master Dec 6, 2018

rjmccall added a commit to rjmccall/swift that referenced this pull request Dec 6, 2018

Fix a source-compatibility bug in swiftlang#20658.

94b2dd8

Test is in swiftlang#20629.

rjmccall deleted the error-self-conformance branch December 6, 2018 03:12

rjmccall mentioned this pull request Dec 6, 2018

[5.0] Allow Error to conform to itself #21073

Merged

kemchenj mentioned this pull request Dec 9, 2018

Result Merged into Standard library (proposal) SwiftOldDriver/iOS-Weekly#863

Closed

theblixguy mentioned this pull request Jun 23, 2020

Overhaul swift_dynamicCast #29658

Closed

Allow Error to conform to itself #20629

Allow Error to conform to itself #20629

Uh oh!

Conversation

rjmccall commented Nov 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rjmccall commented Nov 16, 2018

Uh oh!

DougGregor left a comment

Choose a reason for hiding this comment

Uh oh!

DougGregor Nov 16, 2018

Choose a reason for hiding this comment

Uh oh!

rjmccall Nov 16, 2018

Choose a reason for hiding this comment

Uh oh!

DougGregor Nov 16, 2018

Choose a reason for hiding this comment

Uh oh!

rjmccall Nov 16, 2018

Choose a reason for hiding this comment

Uh oh!

slavapestov Nov 16, 2018

Choose a reason for hiding this comment

Uh oh!

rjmccall Nov 16, 2018

Choose a reason for hiding this comment

Uh oh!

swift-ci commented Nov 16, 2018

Uh oh!

rjmccall commented Nov 16, 2018

Uh oh!

rjmccall commented Nov 16, 2018

Uh oh!

swift-ci commented Nov 16, 2018

Uh oh!

swift-ci commented Nov 16, 2018

Uh oh!

rjmccall commented Nov 16, 2018

Uh oh!

swift-ci commented Nov 16, 2018

Uh oh!

swift-ci commented Nov 16, 2018

Uh oh!

rjmccall commented Nov 16, 2018

Uh oh!

swift-ci commented Nov 16, 2018

Uh oh!

swift-ci commented Nov 16, 2018

Uh oh!

rjmccall commented Nov 17, 2018

Uh oh!

rjmccall commented Nov 17, 2018

Uh oh!

swift-ci commented Nov 17, 2018

Uh oh!

swift-ci commented Nov 17, 2018

Uh oh!

rjmccall commented Nov 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rjmccall commented Nov 17, 2018

Uh oh!

rjmccall commented Nov 17, 2018

Uh oh!

swift-ci commented Nov 17, 2018

Uh oh!

swift-ci commented Nov 17, 2018

Uh oh!

rjmccall commented Nov 17, 2018

Uh oh!

swift-ci commented Nov 17, 2018

Uh oh!

swift-ci commented Nov 17, 2018

Uh oh!

rjmccall commented Nov 17, 2018

Uh oh!

rjmccall commented Dec 5, 2018

rjmccall commented Nov 16, 2018 •

edited

Loading

rjmccall commented Nov 17, 2018 •

edited

Loading