Skip to content
This repository was archived by the owner on Nov 8, 2024. It is now read-only.

Commit f0960fe

Browse files
test: removes "isValidatable" test suites
1 parent 33dc9b8 commit f0960fe

File tree

2 files changed

+1
-105
lines changed

2 files changed

+1
-105
lines changed

test/unit/mixins/validatable-http-message-test.js

Lines changed: 0 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ const INVALID_SCHEMA = require('../../fixtures/invalid-schema-v4');
1010
describe('Http validatable mixin', () => {
1111
describe('when mixed in any HTTP Message class', () => {
1212
const methods = [
13-
'isValidatable',
1413
'validate',
1514
'isValid',
1615
'validationResults',
@@ -46,34 +45,6 @@ describe('Http validatable mixin', () => {
4645
});
4746
});
4847

49-
describe('#isValidatable()', () => {
50-
describe('when no validatable HTTP component in the object', () => {
51-
it('should return false', () => {
52-
const instance = new HttpResponse({ foo: 'bar' });
53-
assert.isFalse(instance.isValidatable());
54-
});
55-
});
56-
57-
describe('when any validatable HTTP component is present in the object', () => {
58-
it('should return true for some headers', () => {
59-
const instance = new HttpResponse({
60-
headers: { 'content-type:': 'application/json' }
61-
});
62-
assert.isTrue(instance.isValidatable());
63-
});
64-
65-
it('should return true for some body', () => {
66-
const instance = new HttpResponse({ body: '' });
67-
assert.isTrue(instance.isValidatable());
68-
});
69-
70-
it('should return true for some statusCode', () => {
71-
const instance = new HttpResponse({ statusCode: 200 });
72-
assert.isTrue(instance.isValidatable());
73-
});
74-
});
75-
});
76-
7748
describe('any HTTP Message instance', () => {
7849
let instance = {};
7950
let response = {

test/unit/validate-test.js

Lines changed: 1 addition & 76 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
const { assert } = require('chai');
22
const clone = require('clone');
3-
const { validate, isValid, isValidatable } = require('../../lib/gavel');
3+
const { validate, isValid } = require('../../lib/gavel');
44

55
describe('Gavel proxies to functions with callbacks', () => {
66
// Examples from README.md
@@ -42,81 +42,6 @@ describe('Gavel proxies to functions with callbacks', () => {
4242
body: '{"origin":"1.2.3.4"}'
4343
};
4444

45-
describe('isValidatable', () => {
46-
describe('when I provide data from README (good objects)', () => {
47-
['response', 'request'].forEach((variant) => {
48-
describe(`for two cloned ${variant}s`, () => {
49-
let results = null;
50-
let error = null;
51-
52-
before((done) => {
53-
isValidatable(
54-
cloneHttpMessage,
55-
baseHttpMessage,
56-
variant,
57-
(err, result) => {
58-
error = err;
59-
results = result;
60-
done();
61-
}
62-
);
63-
});
64-
65-
it('should call the callback without any errors', () =>
66-
assert.isNull(error));
67-
it('should be ok as a result of isValidatable', () =>
68-
assert.isTrue(results));
69-
});
70-
71-
describe(`for similar ${variant}s`, () => {
72-
let results = null;
73-
let error = null;
74-
75-
before((done) => {
76-
isValidatable(
77-
similarHttpMessage,
78-
baseHttpMessage,
79-
variant,
80-
(err, result) => {
81-
error = err;
82-
results = result;
83-
done();
84-
}
85-
);
86-
});
87-
88-
it('should call the callback without any errors', () =>
89-
assert.isNull(error));
90-
it('should be ok as a result of isValidatable', () =>
91-
assert.isTrue(results));
92-
});
93-
94-
describe(`for different ${variant}s`, () => {
95-
let results = null;
96-
let error = null;
97-
98-
before((done) => {
99-
isValidatable(
100-
differentHttpMessage,
101-
baseHttpMessage,
102-
variant,
103-
(err, result) => {
104-
error = err;
105-
results = result;
106-
done();
107-
}
108-
);
109-
});
110-
111-
it('should call the callback without any errors', () =>
112-
assert.isNull(error));
113-
it('should be ok as a result of isValidatable', () =>
114-
assert.isTrue(results));
115-
});
116-
});
117-
});
118-
});
119-
12045
describe('isValid', () => {
12146
describe('when I provide data', () => {
12247
['response', 'request'].forEach((variant) => {

0 commit comments

Comments
 (0)