fix: adds json schema parsing check during body validation

Author: artem-zakharchenko

lib/units/validateBody.js

@@ -148,6 +148,27 @@ function getBodyValidator(realType, expectedType) {
   return [null, validator[0]];
 }
 
+/**
+ * Parses a given JSON Schema to ensure it's a valid JSON.
+ * @param {string} schema
+ */
+const validateJsonSchema = (schema) => {
+  try {
+    JSON.parse(schema);
+  } catch (error) {
+    throw new Error(`\
+Failed to parse a given JSON Schema:
+
+${schema}
+
+Please check if that is a valid JSON and a valid JSON Schema.
+
+Original parsing error:
+${error.stack}\
+    `);
+  }
+};
+
 /**
  * Validates given bodies of transaction elements.
  * @param {Object<string, any>} expected
@@ -170,6 +191,13 @@ function validateBody(expected, real) {
     real.headers && real.headers['content-type'],
     'real'
   );
+
+  // Attempt to parse a given JSON Schema
+  // in case it's a raw string.
+  if (typeof expected.bodySchema === 'string') {
+    validateJsonSchema(expected.bodySchema);
+  }
+
   const [expectedTypeError, expectedType] = expected.bodySchema
     ? getBodySchemaType(expected.bodySchema)
     : getBodyType(

test/unit/units/validateBody.test.js

@@ -444,4 +444,32 @@ describe('validateBody', () => {
       });
     });
   });
+
+  describe('given malformed JSON schema', () => {
+    const getResult = () =>
+      validateBody(
+        {
+          // Purposely invalid JSON Schema
+          bodySchema: `
+          {
+            "$schema": "http://json-schema.org/draft-04/schema#",
+            "type": "object",
+            "properties": {
+                "href"": {
+                  "type": "string"
+                }
+              }
+            }
+          }
+          `
+        },
+        {
+          body: '{ "foo": "bar" }'
+        }
+      );
+
+    it('must throw with malformed JSON schema error', () => {
+      expect(getResult).to.throw(/^Failed to parse a given JSON Schema:/g);
+    });
+  });
 });