fix: provide custom abstraction above "jju" to stop relying on "fs"

Author: artem-zakharchenko

lib/units/validateBody.js

@@ -1,10 +1,10 @@
-const jph = require('json-parse-helpfulerror');
 const mediaTyper = require('media-typer');
 const contentTypeUtils = require('content-type');
 
+const { isValidField } = require('./isValid');
 const { TextDiff, JsonExample, JsonSchema } = require('../validators');
 const isset = require('../utils/isset');
-const { isValidField } = require('./isValid');
+const parseJson = require('../utils/parseJson');
 
 function isPlainText(mediaType) {
   return mediaType.type === 'text' && mediaType.subtype === 'plain';
@@ -69,7 +69,7 @@ function getBodyType(body, contentType, httpMessageOrigin) {
   const hasJsonContentType = isJsonContentType(contentType);
 
   try {
-    jph.parse(body);
+    parseJson(body);
     const bodyMediaType = parseContentType(
       hasJsonContentType ? contentType : 'application/json'
     );
@@ -101,7 +101,7 @@ function getBodySchemaType(bodySchema) {
   }
 
   try {
-    jph.parse(bodySchema);
+    parseJson(bodySchema);
     return [null, jsonSchemaType];
   } catch (error) {
     // Gavel must throw when given malformed JSON Schema.

lib/utils/parseJson.js

@@ -0,0 +1,11 @@
+const { parse } = require('jju/lib/parse');
+
+const parseJson = (json, revivew) => {
+  try {
+    return parse(json, revivew);
+  } catch (error) {
+    throw error;
+  }
+};
+
+module.exports = parseJson;

package-lock.json

@@ -43,7 +43,6 @@
     "deep-equal": "1.0.1",
     "http-string-parser": "0.0.6",
     "jju": "1.4.0",
-    "json-parse-helpfulerror": "1.0.3",
     "json-pointer": "0.6.0",
     "media-typer": "1.1.0",
     "tv4": "1.3.0"

package.json

@@ -1,5 +1,5 @@
 const chai = require('chai');
-const jhp = require('json-parse-helpfulerror');
+const parseJson = require('../../../lib/utils/parseJson');
 
 chai.config.truncateThreshold = 0;
 const { expect } = chai;
@@ -9,7 +9,7 @@ module.exports = function() {
     fieldName,
     expectedJson
   ) {
-    const expected = jhp.parse(expectedJson);
+    const expected = parseJson(expectedJson);
     expect(this.result.fields[fieldName]).to.deep.equal(expected);
   });
 };

test/cucumber/steps/fields.js

@@ -1,19 +1,19 @@
 const { expect } = require('chai');
-const jhp = require('json-parse-helpfulerror');
+const parseJson = require('../../../lib/utils/parseJson');
 
 module.exports = function() {
   this.Given(
     /^I expect the following HTTP (message|request|response):$/i,
     function(_, expectedMessage) {
-      this.expected = jhp.parse(expectedMessage);
+      this.expected = parseJson(expectedMessage);
     }
   );
 
   this.Given(/^the actual HTTP (message|request|response) equals:$/i, function(
     _,
     actualMessage
   ) {
-    this.actual = jhp.parse(actualMessage);
+    this.actual = parseJson(actualMessage);
   });
 
   // Inline value assertion.
@@ -72,7 +72,7 @@ module.exports = function() {
     const stringifiedActual = JSON.stringify(this.result, null, 2);
 
     expect(this.result).to.deep.equal(
-      jhp.parse(expectedResult),
+      parseJson(expectedResult),
       `\
 Expected the following result: