test: merge submodule test reports #7359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the build configuration to merge submodule test reports and updates the change logs in both Chinese and English to reflect the change.
- In pom.xml, a new execution with id "report-aggregate" is added to generate aggregate test reports during the test phase.
- In changes/zh-cn/2.x.md and changes/en-us/2.x.md, new entries are added to document the merging of submodule test reports.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pom.xml | Added a new execution for aggregating test reports during tests. |
| changes/zh-cn/2.x.md | Updated the change log with an entry for merged test reports. |
| changes/en-us/2.x.md | Updated the change log with an entry for merged test reports. |
Comments suppressed due to low confidence (1)
pom.xml:491
- Consider verifying whether the 'test' phase is the most appropriate phase for the 'report-aggregate' execution. Typically, aggregating reports is performed in the 'verify' phase to ensure that all tests have completed, which might provide more accurate reporting.
<phase>test</phase>
| - [[#7294](https://github.com/apache/incubator-seata/pull/7294)] improved test testGetInsertParamsValue in SqlServerInsertRecognizerTest by splitting and parameterizing | ||
| - [[#7295](https://github.com/apache/incubator-seata/pull/7295)] updated 3 tests in StringUtilsTest to use parameterized unit testing | ||
| - [[#7205](https://github.com/apache/incubator-seata/issues/7205)] add UT for namingserver module | ||
| - [[#7359](https://github.com/apache/incubator-seata/issues/7359)] merge submodule test reports |
There was a problem hiding this comment.
[nitpick] Consider expanding the change log entry to briefly mention how merging submodule test reports improves overall test coverage visibility.
Copilot uses AI. Check for mistakes.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7359 +/- ##
============================================
+ Coverage 54.92% 58.37% +3.45%
+ Complexity 7413 535 -6878
============================================
Files 1181 1272 +91
Lines 42136 45849 +3713
Branches 4945 5519 +574
============================================
+ Hits 23143 26766 +3623
+ Misses 16815 16565 -250
- Partials 2178 2518 +340 see 285 files with indirect coverage changes 🚀 New features to boost your workflow:
|
YongGoose
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews